[pve-devel] applied: [PATCH qemu-server v2] vm start: set higher timeout if using PCI passthrough

2023-10-06 Thread Thomas Lamprecht
Am 06/10/2023 um 14:15 schrieb Friedrich Weber: > The default VM startup timeout is `max(30, VM memory in GiB)` seconds. > Multiple reports in the forum [0] [1] and the bug tracker [2] suggest > this is too short when using PCI passthrough with a large amount of VM > memory, since QEMU needs to map

[pve-devel] applied-series: [PATCH ha-manager 1/2] fix #4984: recompute online usage: add service usage to migration target only if online

2023-10-06 Thread Thomas Lamprecht
Am 05/10/2023 um 16:05 schrieb Fiona Ebner: > Otherwise, when using the 'basic' plugin, this would lead to > autovivification of the $target node in the Perl hash tracking the > usage and it would wrongly be considered online when selecting the > recovery node. > > The 'static' plugin was not affe

Re: [pve-devel] [PATCH proxmox-widget-toolkit v1 2/2] fix #4546: utils: save expiring date of user account for UI

2023-10-06 Thread Stefan Sterz
On Fri Sep 22, 2023 at 4:36 PM CEST, Philipp Hufnagl wrote: -- snip 8< -- > +$text-color-warning: hsl(48deg, 100%, 50%); > > // Borders > $border-color: hsl(0deg, 0%, 40%); > diff --git a/src/proxmox-dark/scss/extjs/_menu.scss > b/src/proxmox-dark/scss/extjs/_menu.scss > index 2983f60..aa51260

Re: [pve-devel] [PATCH proxmox-widget-toolkit v1 1/2] fix #4546: css: Inform user administrator about user accounts expiring soon

2023-10-06 Thread Stefan Sterz
On Fri Oct 6, 2023 at 3:16 PM CEST, Lukas Wagner wrote: -- snip 8< -- > > +$background-hint: hsl(233deg, 99%, 60%); > > That particular color tone looks pretty out of place to me in dark mode. > In light mode, you use the same hue as other interface elements, is > there a reason why you use a diff

Re: [pve-devel] [PATCH proxmox-widget-toolkit v1 1/2] fix #4546: css: Inform user administrator about user accounts expiring soon

2023-10-06 Thread Lukas Wagner
Comments inline. On 9/22/23 16:36, Philipp Hufnagl wrote: Adds a new css class to underlay information urgency in table columns for dark and light mode. This underlay color then is used to notifiy Typo in 'notify' user administrators about user accounts that will expire soon Signed-off-by: Ph

Re: [pve-devel] [PATCH proxmox-widget-toolkit v1 2/2] fix #4546: utils: save expiring date of user account for UI

2023-10-06 Thread Lukas Wagner
Comments inline. On 9/22/23 16:36, Philipp Hufnagl wrote: When an user experation date is send with the /accesss/tickets POST API ^ ^ ^ some minor typos: expiration sent access call, it will be stored in a global variable

Re: [pve-devel] [PATCH manager/access-control/proxmox-widget-toolkit v1 0/4] fix #4546: Show warning hint/badge if user account is expiring in next few days

2023-10-06 Thread Lukas Wagner
On 9/22/23 16:36, Philipp Hufnagl wrote: Currently, when an user account expires, it catches the users by surprise. It would be helpful to notify the the user as well as the administrator. This patch highlights such accounts in the user account pannel and also shows for regular user an exclam

Re: [pve-devel] [PATCH manager v1 1/1] fix #4546: ui: notify user if their user account expires soon

2023-10-06 Thread Lukas Wagner
Comments inline. On 9/22/23 16:36, Philipp Hufnagl wrote: When the user account that is currently logged in will expire soon, the user icon will turn into a yellow exclamation mark. In the user menu there will be a new element informing the user briefly about it. If the

Re: [pve-devel] [PATCH access-control v1 1/1] fix #4546: api: Return user expiration date on access/ticket API call

2023-10-06 Thread Lukas Wagner
Comments inline. On 9/22/23 16:36, Philipp Hufnagl wrote: Adds an additional, optional parameter to the access/tickets api call which tells when the currently used user account will expire. If it will not expire, the parameter will not be added. Signed-off-by: Philipp Hufnagl --- src/PVE/API

[pve-devel] [PATCH qemu-server v2] vm start: set higher timeout if using PCI passthrough

2023-10-06 Thread Friedrich Weber
The default VM startup timeout is `max(30, VM memory in GiB)` seconds. Multiple reports in the forum [0] [1] and the bug tracker [2] suggest this is too short when using PCI passthrough with a large amount of VM memory, since QEMU needs to map the whole memory during startup (see comment #2 in [2])

[pve-devel] [PATCH v2 qemu 8/9] cherry-pick stable fixes to avoid crash in IO error scenarios

2023-10-06 Thread Fiona Ebner
Upstream report of the issue [0]. I ran into it too by chance by filling up my NFS storage with the VM's qcow2 disk. [0]: https://bugzilla.redhat.com/show_bug.cgi?id=2234374 Signed-off-by: Fiona Ebner --- No changes in v2. ...ile-posix-Clear-bs-bl.zoned-on-error.patch | 87 +++

[pve-devel] [PATCH v2 qemu 6/9] add patch to avoid huge snapshot performance regression

2023-10-06 Thread Fiona Ebner
Taking a snapshot became prohibitively slow because of the migration_transferred_bytes() call in migration_rate_exceeded() [0]. This also applied to the async snapshot taking in Proxmox VE, so work around the issue until it is fixed upstream. [0]: https://gitlab.com/qemu-project/qemu/-/issues/182

[pve-devel] [PATCH v2 qemu 9/9] add stable fix to avoid crash in SCSI when guest uses too small blocksize

2023-10-06 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- New in v2. ...k-Disallow-block-sizes-smaller-than-.patch | 43 +++ debian/patches/series | 1 + 2 files changed, 44 insertions(+) create mode 100644 debian/patches/extra/0012-hw-scsi-scsi-disk-Disallow-block-sizes-smaller

[pve-devel] [PATCH v2 qemu 7/9] d/control: add versioned Breaks for qemu-server <= 8.0.6

2023-10-06 Thread Fiona Ebner
Upstream QEMU commit 4271f40383 ("virtio-net: correctly report maximum tx_queue_size value") made setting an invalid tx_queue_size for a non-vDPA/vhost-user net device a hard error. Now, qemu-server before commit 089aed81 ("cfg2cmd: netdev: fix value for tx_queue_size") did just that, so the newer

[pve-devel] [PATCH v2 qemu 2/9] buildsys: fixup submodule target

2023-10-06 Thread Fiona Ebner
It's not enough to initialize the submodules anymore, as some got replaced by wrap files, see QEMU commit 2019cabfee ("meson: subprojects: replace submodules with wrap files"). Download the subprojects during initialization of the QEMU submodule, so building (without the automagical --enable-downl

[pve-devel] [PATCH v2 qemu 1/9] d/rules: use disable-download option instead of git-submodules=ignore

2023-10-06 Thread Fiona Ebner
See the following QEMU commits for reference: 0c5f3dcbb2 ("configure: add --enable-pypi and --disable-pypi") ac4ccac740 ("configure: rename --enable-pypi to --enable-download, control subprojects too") 6f3ae23b29 ("configure: remove --with-git-submodules=") removed The last one removed the option

[pve-devel] [PATCH v2 qemu 5/9] add patch to disable graph locking

2023-10-06 Thread Fiona Ebner
There are still some issues with graph locking, e.g. deadlocks during backup canceling [0] and initial attempts to fix it didn't work [1]. Because the AioContext locks still exist, it should still be safe to disable graph locking. [0]: https://lists.nongnu.org/archive/html/qemu-devel/2023-09/msg00

[pve-devel] [PATCH-SERIES v2 qemu] update to QEMU 8.1.1

2023-10-06 Thread Fiona Ebner
Patch changes: For backup, opening the backup dump block driver needed to be adapted, because of coroutine context changes. Block graph locking was disabled, because of deadlocks. Snapshot code has a huge performance regression which required a workaround. Meta-changes: Use --disable-download

Re: [pve-devel] [PATCH qemu 5/7] add patch to disable graph locking

2023-10-06 Thread Fiona Ebner
Am 28.09.23 um 14:59 schrieb Fiona Ebner: > + void bdrv_graph_wrlock(BlockDriverState *bs) > + { > + AioContext *ctx = NULL; > + > + GLOBAL_STATE_CODE(); > ++/* > ++ * TODO Some callers hold an AioContext lock when this is called, which > ++ * causes deadlocks. Reenable once th