[pve-devel] Thank you for being part of pve-devel

2023-09-25 Thread Alexandre Aguirre via pve-devel
--- Begin Message --- Hello goodnight ! My name is Alexandre, I'm Brazilian and I've been a proxmox user since 2015, I'm an active collaborator in BR communities as well as groups on Telegram and WhatsApp, I'd like to know how I can collaborate with the solution, I'm available to be part of the gr

[pve-devel] [PATCH pve-kernel] cherry-pick fix for new amd64 ucode

2023-09-25 Thread Stoiko Ivanov
The latest amd64-microcode package in sid [0] (which probably will eventually make it to bookworm-security) has a change that requires the added patch to work properly. The changelog-entry refers to stable k.o branches only - but a quick look through the linux-firmware.git log identifies: `f2eb058

[pve-devel] [PATCH v3 manager 3/3] ui: vm selector: gracefully handle undefined/null in setValue function

2023-09-25 Thread Fiona Ebner
Suggested-by: Dominik Csapak Signed-off-by: Fiona Ebner --- New in v3. www/manager6/form/VMSelector.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form/VMSelector.js index 22f7dd11..d59847f2 100644 --- a/www/manager6/form/VMSelector.js +++

[pve-devel] [PATCH v3 manager 2/3] ui: vm selector: don't add invalid not found items

2023-09-25 Thread Fiona Ebner
Doing a simple numericity check and warn in the console so developers can notice if there is something off. Signed-off-by: Fiona Ebner Reviewed-by: Dominik Csapak --- No changes in v3. www/manager6/form/VMSelector.js | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/www

[pve-devel] [PATCH v3 stable-7+master manager 1/3] ui: vm selector: gracefully handle empty IDs in setValue function

2023-09-25 Thread Fiona Ebner
An empty string is passed by the backup job window when using selection mode 'all', would be converted to [""] and wrongly add an entry with VMID 0 because the item "" could not be found in the store. Reported in the community forum: https://forum.proxmox.com/threads/130164/ Fixes: 7a5ca76a ("fix

[pve-devel] [PATCH container v2] setup: fix architecture detection for NixOS containers

2023-09-25 Thread Christoph Heiss
NixOS is special and deviates in many places from a "standard" Linux system. In this case, /bin/sh does not exist in the filesystem, before the initial activation (aka. first boot) - which creates a symlink at /bin/sh. Due to the currently existing fallback code, only an error message is logged an

Re: [pve-devel] [PATCH v2 stable-7+master manager 1/2] ui: vm selector: handle empty string gracefully

2023-09-25 Thread Fiona Ebner
Am 25.09.23 um 13:17 schrieb Dominik Csapak: > > sorry for the late answer > > the patch LGTM, but i would even go a step further and do a > > value ??= []; > > > before the isArray check (that way we'd also handle undefined/null values) > (can ofc be done as a follow-up/later) > > >

Re: [pve-devel] [PATCH qemu-server 1/3] fix #2816: restore: remove timeout when allocating disks

2023-09-25 Thread Dominik Csapak
On 9/25/23 12:30, Fiona Ebner wrote: Am 25.09.23 um 10:57 schrieb Dominik Csapak: On 9/25/23 10:46, Fiona Ebner wrote: Am 20.09.23 um 13:23 schrieb Dominik Csapak: On 9/12/23 11:16, Fiona Ebner wrote: @@ -7483,14 +7483,11 @@ sub restore_vma_archive {    $devinfo->{$devname} = { size

Re: [pve-devel] [PATCH v2 manager 2/2] ui: vm selector: don't add invalid not found items

2023-09-25 Thread Dominik Csapak
On 7/7/23 10:02, Fiona Ebner wrote: Doing a simple numericity check and warn in the console so developers can notice if there is something off. Signed-off-by: Fiona Ebner --- New in v2. www/manager6/form/VMSelector.js | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a

Re: [pve-devel] [PATCH v2 stable-7+master manager 1/2] ui: vm selector: handle empty string gracefully

2023-09-25 Thread Dominik Csapak
On 7/7/23 10:02, Fiona Ebner wrote: which is passed by the backup job window when using selection mode 'all', would be converted to [""] and wrongly add an entry with VMID 0 because the item "" could not be found in the store. Reported in the community forum: https://forum.proxmox.com/threads/13

Re: [pve-devel] [PATCH v2 stable-7+master manager 1/2] ui: vm selector: handle empty string gracefully

2023-09-25 Thread Fiona Ebner
Ping again, because there is another report: https://forum.proxmox.com/threads/133735/ Am 30.08.23 um 11:15 schrieb Fiona Ebner: > Ping for the series > > Am 07.07.23 um 10:02 schrieb Fiona Ebner: >> which is passed by the backup job window when using selection mode >> 'all', would be converted

Re: [pve-devel] [PATCH qemu-server 1/3] fix #2816: restore: remove timeout when allocating disks

2023-09-25 Thread Fiona Ebner
Am 25.09.23 um 10:57 schrieb Dominik Csapak: > On 9/25/23 10:46, Fiona Ebner wrote: >> Am 20.09.23 um 13:23 schrieb Dominik Csapak: >>> On 9/12/23 11:16, Fiona Ebner wrote: @@ -7483,14 +7483,11 @@ sub restore_vma_archive {    $devinfo->{$devname} = { size => $size, dev_id => $dev_

Re: [pve-devel] [PATCH qemu] fix #2874: SATA: avoid unsolicited write to sector 0 during reset

2023-09-25 Thread Fiona Ebner
Am 24.08.23 um 15:51 schrieb Fiona Ebner: > If there is a pending DMA operation during ide_bus_reset(), the fact > that the IDEstate is already reset before the operation is canceled > can be problematic. In particular, ide_dma_cb() might be called and > then use the reset IDEstate which contains t

Re: [pve-devel] [PATCH manager] ui: vm create wizard: default to 2 cores for win 11 os type

2023-09-25 Thread Fiona Ebner
Am 12.09.23 um 16:38 schrieb Alexander Zeidler: > www/manager6/qemu/ProcessorEdit.js | 16 > 1 file changed, 16 insertions(+) > I think this should be done in www/manager6/qemu/OSDefaults.js instead of having this afterrender callback with an explicit check. __

Re: [pve-devel] [PATCH qemu-server 1/3] fix #2816: restore: remove timeout when allocating disks

2023-09-25 Thread Dominik Csapak
On 9/25/23 10:46, Fiona Ebner wrote: Am 20.09.23 um 13:23 schrieb Dominik Csapak: comment inline: Feel free to cut out irrelevant parts in the reply ;) On 9/12/23 11:16, Fiona Ebner wrote: @@ -7483,14 +7483,11 @@ sub restore_vma_archive {   $devinfo->{$devname} = { size => $size, d

Re: [pve-devel] [PATCH qemu-server 1/3] fix #2816: restore: remove timeout when allocating disks

2023-09-25 Thread Fiona Ebner
Am 20.09.23 um 13:23 schrieb Dominik Csapak: > comment inline: Feel free to cut out irrelevant parts in the reply ;) > On 9/12/23 11:16, Fiona Ebner wrote: >> @@ -7483,14 +7483,11 @@ sub restore_vma_archive { >>   $devinfo->{$devname} = { size => $size, dev_id => $dev_id }; >>   }

Re: [pve-devel] [PATCH v3 many 0/7] notifications: add SMTP endpoint

2023-09-25 Thread Lukas Wagner
The notification system overhaul is available in the pvetest repository, however that does not yet include the SMTP endpoint type. Only gotify and sendmail (uses the system's sendmail command to send mails) are available so far. -- - Lukas ___ pve-