[pve-devel] [PATCH manager/access-control/proxmox-widget-toolkit v1 0/4] fix #4546: Show warning hint/badge if user account is expiring in next few days

2023-09-22 Thread Philipp Hufnagl
Currently, when an user account expires, it catches the users by surprise. It would be helpful to notify the the user as well as the administrator. This patch highlights such accounts in the user account pannel and also shows for regular user an exclamation mark in the user info pannel. It also ad

[pve-devel] [PATCH access-control v1 1/1] fix #4546: api: Return user expiration date on access/ticket API call

2023-09-22 Thread Philipp Hufnagl
Adds an additional, optional parameter to the access/tickets api call which tells when the currently used user account will expire. If it will not expire, the parameter will not be added. Signed-off-by: Philipp Hufnagl --- src/PVE/API2/AccessControl.pm | 8 src/PVE/AccessControl.pm

[pve-devel] [PATCH proxmox-widget-toolkit v1 2/2] fix #4546: utils: save expiring date of user account for UI

2023-09-22 Thread Philipp Hufnagl
When an user experation date is send with the /accesss/tickets POST API call, it will be stored in a global variable like the username Signed-off-by: Philipp Hufnagl --- src/Utils.js| 3 +++ src/proxmox-dark/scss/abstracts/_variables.scss | 1 + src/proxmox-da

[pve-devel] [PATCH proxmox-widget-toolkit v1 1/2] fix #4546: css: Inform user administrator about user accounts expiring soon

2023-09-22 Thread Philipp Hufnagl
Adds a new css class to underlay information urgency in table columns for dark and light mode. This underlay color then is used to notifiy user administrators about user accounts that will expire soon Signed-off-by: Philipp Hufnagl --- src/Utils.js| 6 +-

[pve-devel] [PATCH manager v1 1/1] fix #4546: ui: notify user if their user account expires soon

2023-09-22 Thread Philipp Hufnagl
When the user account that is currently logged in will expire soon, the user icon will turn into a yellow exclamation mark. In the user menu there will be a new element informing the user briefly about it. If the element is clicked, a popup will appear informing the user in detail about it Signed-

Re: [pve-devel] [PATCH manager v8 0/2] fix #4849: allow download of compressed ISOs

2023-09-22 Thread Dominik Csapak
LGTM now, and tested fine (this time with ISOs *and* CT templates ;) ) two tiny nits: the commit message of the first message could mention that the parameter is necessary to differentiate between different needs for different content types, but imho not super important now (could be fixed up e

[pve-devel] [PATCH manager v2 2/2] ceph: api: use snake_case when setting options

2023-09-22 Thread Maximiliano Sandoval
Continuation of ab70343982f36a5343d3fcf4a1a6489bd3f52a66. Discussion at https://lists.proxmox.com/pipermail/pve-devel/2023-September/059013.html. Signed-off-by: Maximiliano Sandoval --- PVE/API2/Ceph.pm | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/PVE/AP

[pve-devel] [PATCH manager v2 1/2] ceph: mark global pg bits setting as deprecated

2023-09-22 Thread Maximiliano Sandoval
This setting was removed in [1] as part of the v13.0.2 tag. Running ceph config set global osd_pg_bits 42 results in Error EINVAL: unrecognized config option 'osd_pg_bits' So we mark this api as deprecated and make it a no-op operation. [1] https://github.com/ceph/ceph/commit/e6acf2d1d