Re: [pve-devel] [PATCH pve-ceph] fix compatibility with CPUs not supporting SSE 4.1 instructions

2023-09-18 Thread Dietmar Maurer
> One of our users ran into issues with running Ceph on older CPU > architectures [1]. This is apparently due to a bug in gcc-12 that > leads to SSE 4.1 instructions always being executed rather than > dynamically dispatching functions using those instructions. Cant we fix the GCC bug instead? _

[pve-devel] [PATCH pve-ceph] fix compatibility with CPUs not supporting SSE 4.1 instructions

2023-09-18 Thread Stefan Hanreich
One of our users ran into issues with running Ceph on older CPU architectures [1]. This is apparently due to a bug in gcc-12 that leads to SSE 4.1 instructions always being executed rather than dynamically dispatching functions using those instructions. Those binaries then break on older CPUs that

Re: [pve-devel] [PATCH qemu-server] fix #3963: Skip TPM startup for template VMs

2023-09-18 Thread Thomas Lamprecht
Am 09/08/2023 um 11:09 schrieb Filip Schauer: > Skip the software TPM startup when starting a template VM for performing > a backup. This fixes an error that occurs when the TPM state disk is > write-protected. > > Signed-off-by: Filip Schauer > --- > PVE/QemuServer.pm | 2 +- > 1 file changed,

[pve-devel] applied-series: [PATCH-SERIES qemu-server] avoid cyclic use of main module in memory module

2023-09-18 Thread Thomas Lamprecht
Am 04/09/2023 um 13:39 schrieb Fiona Ebner: > Mostly cleanup, moving some code out of the main module and as > indirect preparation for Alexandre's series reworking memory hotplug > [0]. At one point during development, the cyclic use caused actual > problems [1]. Let's avoid any future surprises c

[pve-devel] applied-series: [PATCH v4 manager/container/guest-common/docs 0/4] fix #3069: add pbs-entries-max to vzdump.conf

2023-09-18 Thread Thomas Lamprecht
Am 28/07/2023 um 15:28 schrieb Alexander Zeidler: > Users reported[1] about failing container backups to PBS when having a large > amount of files in a directory. > > proxmox-backup-client has already 'entries-max' implemented. The default > value prevents out of memory (OOM) situations. Overrid

[pve-devel] [PATCH v3 proxmox 3/7] notify: add api for smtp endpoints

2023-09-18 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- proxmox-notify/src/api/mod.rs | 48 + proxmox-notify/src/api/smtp.rs | 373 + 2 files changed, 421 insertions(+) create mode 100644 proxmox-notify/src/api/smtp.rs diff --git a/proxmox-notify/src/api/mod.rs b/proxmox-notify/sr

[pve-devel] [PATCH v3 proxmox-perl-rs 4/7] notify: add bindings for smtp API calls

2023-09-18 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- common/src/notify.rs | 110 +++ 1 file changed, 110 insertions(+) diff --git a/common/src/notify.rs b/common/src/notify.rs index 203acca..b0a7d44 100644 --- a/common/src/notify.rs +++ b/common/src/notify.rs @@ -13,6 +13,10 @

[pve-devel] [PATCH v3 proxmox 1/7] notify: fix typo in doc comments

2023-09-18 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- proxmox-notify/src/lib.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxmox-notify/src/lib.rs b/proxmox-notify/src/lib.rs index eebc57a..ca68388 100644 --- a/proxmox-notify/src/lib.rs +++ b/proxmox-notify/src/lib.rs @@ -106,7 +106,7 @@ pub

[pve-devel] [PATCH v3 proxmox 2/7] notify: add 'smtp' endpoint

2023-09-18 Thread Lukas Wagner
This commit adds a new endpoint type, namely 'smtp'. This endpoint uses the `lettre` crate to directly send emails to SMTP relays. The `lettre` crate was chosen since it is by far the most popular SMTP implementation for Rust that looks like it is well maintained. Also, it includes async support (

[pve-devel] [PATCH v3 proxmox-widget-toolkit 6/7] panel: notification: add gui for SMTP endpoints

2023-09-18 Thread Lukas Wagner
This new endpoint configuration panel is embedded in the existing EndpointEditBase dialog window. This commit also factors out some of the non-trivial common form elements that are shared between the new panel and the already existing SendmailEditPanel into a separate panel EmailRecipientPanel. Si

[pve-devel] [PATCH v3 pve-manager 5/7] notify: add API routes for smtp endpoints

2023-09-18 Thread Lukas Wagner
The Perl part of the API methods primarily defines the API schema, checks for any needed privileges and then calls the actual Rust implementation exposed via perlmod. Any errors returned by the Rust code are translated into PVE::Exception, so that the API call fails with the correct HTTP error code

[pve-devel] [PATCH v3 pve-docs 7/7] notifications: document SMTP endpoints

2023-09-18 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- notifications.adoc | 28 1 file changed, 28 insertions(+) diff --git a/notifications.adoc b/notifications.adoc index 0b00b1e..c2fe393 100644 --- a/notifications.adoc +++ b/notifications.adoc @@ -73,9 +73,37 @@ accomodate multiple recip

[pve-devel] [PATCH v3 many 0/7] notifications: add SMTP endpoint

2023-09-18 Thread Lukas Wagner
This patch series adds support for a new notification endpoint type, smtp. As the name suggests, this new endpoint allows PVE to talk to SMTP server directly, without using the system's MTA (postfix). On the Rust side, these patches add a new dependency to the `lettre` crate for SMTP communication

[pve-devel] applied: [PATCH proxmox-widget-toolkit] notification config view: add missing parameter for Ext.String.format

2023-09-18 Thread Thomas Lamprecht
Am 18/09/2023 um 11:49 schrieb Lukas Wagner: > Fixes: 7e4b51 ("notification config view: fix using gettext with parameter") > Signed-off-by: Lukas Wagner > --- > src/panel/NotificationConfigView.js | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > applied, thanks! __

[pve-devel] applied: [PATCH manager] ui: notification: remove unneeded gettext calls

2023-09-18 Thread Thomas Lamprecht
Am 18/09/2023 um 10:20 schrieb Lukas Wagner: > 'mail-to-root' is the name of the default notification target and > should thus not be translated. > > Signed-off-by: Lukas Wagner > --- > www/manager6/dc/NotificationEvents.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > applie

[pve-devel] [PATCH proxmox-widget-toolkit] notification config view: add missing parameter for Ext.String.format

2023-09-18 Thread Lukas Wagner
Fixes: 7e4b51 ("notification config view: fix using gettext with parameter") Signed-off-by: Lukas Wagner --- src/panel/NotificationConfigView.js | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/panel/NotificationConfigView.js b/src/panel/NotificationConfigView.js index

[pve-devel] [PATCH manager] ui: notification: remove unneeded gettext calls

2023-09-18 Thread Lukas Wagner
'mail-to-root' is the name of the default notification target and should thus not be translated. Signed-off-by: Lukas Wagner --- www/manager6/dc/NotificationEvents.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/dc/NotificationEvents.js b/www/manager6/dc/