Re: [pve-devel] [PATCH manager v3] ui: improve user experience for vm/container transfer between pools

2023-09-12 Thread Thomas Lamprecht
Am 08/09/2023 um 15:18 schrieb Philipp Hufnagl: > After the implementation of fix #474, it has been suggested that > instead of requiring the user to click a checkbox allowing migration, > it should be allowed automatically and and a warning should be displayed > > Further it has been discussed to

[pve-devel] [PATCH manager] ui: vm create wizard: default to 2 cores for win 11 os type

2023-09-12 Thread Alexander Zeidler
Windows 11 installer requires 2 cores [0]. Tested with Win11_22H2_English_x64v2.iso from [1]. Windows Server 2022 installer still requires only 1 core [2]. Tested with SERVER_EVAL_x64FRE_en-us.iso from [3]. [0] https://support.microsoft.com/en-us/windows/windows-11-system-requirements-86c11283

[pve-devel] [PATCH v2 pve-zsync] parse disks: improve error messages

2023-09-12 Thread Fiona Ebner
The one with the backup flag was reported in the community forum: https://forum.proxmox.com/threads/77254/ Signed-off-by: Fiona Ebner --- Changes in v2: * Further improve message as suggested by Sterzy. pve-zsync | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pve-

Re: [pve-devel] [PATCH pve-zsync] parse disks: improve error messages

2023-09-12 Thread Stefan Sterz
On Tue Sep 12, 2023 at 11:31 AM CEST, Fiona Ebner wrote: > The one with the backup flag was reported in the community forum: > https://forum.proxmox.com/threads/77254/ > > Signed-off-by: Fiona Ebner > --- > pve-zsync | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/pv

[pve-devel] [PATCH qemu] fix #4710: vma create: don't use O_DIRECT for tmpfs

2023-09-12 Thread Fiona Ebner
The implementation of the helper is_path_tmpfs() is similar to the existing (in upstream) qemu_fd_getfs() function in util/mmap-alloc.c, which unfortunately only takes an existing fd. Signed-off-by: Fiona Ebner --- ...VE-Backup-add-vma-backup-format-code.patch | 37 --- 1 file ch

[pve-devel] [PATCH pve-zsync] parse disks: improve error messages

2023-09-12 Thread Fiona Ebner
The one with the backup flag was reported in the community forum: https://forum.proxmox.com/threads/77254/ Signed-off-by: Fiona Ebner --- pve-zsync | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pve-zsync b/pve-zsync index 98190b2..0e48865 100755 --- a/pve-zsync +++ b/p

[pve-devel] [PATCH backup-qemu] Bump build dependencies to bookworm updates

2023-09-12 Thread Filip Schauer
This fixes dependency installation errors when running `mk-build-deps --install` against the proxmox devel bookworm repository. Signed-off-by: Filip Schauer --- Cargo.toml| 2 +- debian/control| 23 --- submodules/proxmox-backup | 2 +- 3 files c

[pve-devel] [PATCH qemu-server 2/3] restore vma: add comment describing timeout

2023-09-12 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 05283562..f7ee7686 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -7367,7 +7367,7 @@ sub restore_vma_archive { $add_pipe

[pve-devel] [PATCH qemu-server 3/3] restore vma: inline one timeout variable and move other closer to usage

2023-09-12 Thread Fiona Ebner
No functional change intended. Signed-off-by: Fiona Ebner --- PVE/QemuServer.pm | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index f7ee7686..b52dfbf4 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -7366,9 +7366,6 @@ s

[pve-devel] [PATCH qemu-server 1/3] fix #2816: restore: remove timeout when allocating disks

2023-09-12 Thread Fiona Ebner
10 minutes is not long enough when disks are large and/or network storages are used when preallocation is not disabled. The default is metadata preallocation for qcow2, so there are still reports of the issue [0][1]. If allocation really does not finish like the comment describing the timeout feare