Re: [pve-devel] [PATCH v2 pve-manager 2/2] ui: qemu : memoryedit: add new max && virtio fields

2023-09-01 Thread DERUMIER, Alexandre
Le vendredi 01 septembre 2023 à 12:24 +0200, Fiona Ebner a écrit : > Am 01.09.23 um 11:48 schrieb Thomas Lamprecht: > > Am 19/06/2023 um 09:28 schrieb Alexandre Derumier: > > > +   xtype: 'pveMemoryField', > > > +   name: 'max', > > > +   minValue: 65536, > > > +

Re: [pve-devel] [PATCH-SERIE v6 qemu-server/pve-manager] rework memory hotplug + virtiomem

2023-09-01 Thread DERUMIER, Alexandre
ok, thanks Fiona ! Le vendredi 01 septembre 2023 à 14:24 +0200, Fiona Ebner a écrit : > I'll send a few patches (likely on Monday) moving a bit of code > around, > to get rid of the cyclic include > PVE::QemuServer <-> PVE::QemuServer::Memory > > While it shouldn't affect your changes directly,

Re: [pve-devel] [PATCH-SERIE v6 qemu-server/pve-manager] rework memory hotplug + virtiomem

2023-09-01 Thread DERUMIER, Alexandre
Hi Gilberto, the idea with virtio-mem (but also classic hotplug), is to define a max memory. (currently it's max=4TB by default without any option). Then for classic memory: this maxmemory is shared by a number de memory slots. (64 by default), So the increment hotplug will be = MAXmem /64 s

Re: [pve-devel] [PATCH pve-manager v2] api: ceph: improve reporting of ceph OSD memory usage

2023-09-01 Thread Thomas Lamprecht
Am 16/08/2023 um 17:21 schrieb Stefan Hanreich: > Currently we are using the MemoryCurrent property of the OSD service > to determine the used memory of a Ceph OSD. This includes, among other > things, the memory used by buffers [1]. Since BlueFS uses buffered > I/O, this can lead to extremely high

Re: [pve-devel] [PATCH-SERIE v6 qemu-server/pve-manager] rework memory hotplug + virtiomem

2023-09-01 Thread Gilberto Ferreira via pve-devel
--- Begin Message --- Hi there. While I am a big zero programmer, I like to follow up these threads about Proxmox development. As always, it's a great piece of software. So I would like to ask if this hotplug memory will solve the problem we encounter when try to address huge memory in VM, like fro

Re: [pve-devel] [PATCH-SERIE v6 qemu-server/pve-manager] rework memory hotplug + virtiomem

2023-09-01 Thread Fiona Ebner
I'll send a few patches (likely on Monday) moving a bit of code around, to get rid of the cyclic include PVE::QemuServer <-> PVE::QemuServer::Memory While it shouldn't affect your changes directly, I think it will affect the patch context, so you might want to wait for that before doing the next r

[pve-devel] applied: [PATCH v6 qemu-server 03/10] memory: use static_memory in foreach_dimm

2023-09-01 Thread Fiona Ebner
applied this one, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v2 pve-manager 2/2] ui: qemu : memoryedit: add new max && virtio fields

2023-09-01 Thread Fiona Ebner
Am 01.09.23 um 11:48 schrieb Thomas Lamprecht: > Am 19/06/2023 um 09:28 schrieb Alexandre Derumier: >> +xtype: 'pveMemoryField', >> +name: 'max', >> +minValue: 65536, >> +maxValue: 4194304, >> +value: '', >> +step: 65536, >> +

Re: [pve-devel] [PATCH v6 qemu-server 01/10] add memory parser

2023-09-01 Thread Fiona Ebner
Am 19.06.23 um 09:28 schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- There's a new usage for get_dervied_property() since this patch was sent. Please add it to the next version: > diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm > index d4230895..0e4b1eb8 100644 > --- a/P

Re: [pve-devel] [PATCH v2 pve-manager 2/2] ui: qemu : memoryedit: add new max && virtio fields

2023-09-01 Thread Thomas Lamprecht
Am 19/06/2023 um 09:28 schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > www/manager6/qemu/MemoryEdit.js | 52 +++-- > 1 file changed, 43 insertions(+), 9 deletions(-) > > diff --git a/www/manager6/qemu/MemoryEdit.js b/www/manager6/qemu/MemoryEdi

[pve-devel] [PATCH ifupdown2] patch: fix bond mac address at boot.

2023-09-01 Thread Alexandre Derumier
since systemd v241, like for bridge, the bond mac is setup randomly at boot, instead inherit from first slave. Then, on next ifreload, ifupdown2 was already fixing it, but with an down/up of the bond (with potentials impact on the network). This patch have been sent upstream: https://github.com/C

[pve-devel] [PATCH container] fix #4846: Avoid the outdated noacl mount option on ext4

2023-09-01 Thread Filip Schauer
Do not use the 'noacl' mount option when mounting a container disk with an ext4 file system. The option was removed from the kernel in commit 2d544ec923db Signed-off-by: Filip Schauer --- src/PVE/LXC.pm | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/PVE/LXC.pm

[pve-devel] applied: [PATCH manager] ui: replication: backup: use renderEnabledIcon to render the enabled column

2023-09-01 Thread Thomas Lamprecht
Am 18/07/2023 um 11:53 schrieb Lukas Wagner: > Signed-off-by: Lukas Wagner > --- > www/manager6/dc/Backup.js| 3 +-- > www/manager6/grid/Replication.js | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > applied, but added context about when this function got available in wi

Re: [pve-devel] [PATCH common/cluster 0/3] fix #4937: fix utf8 encoding issues while saving notification config

2023-09-01 Thread Lukas Wagner
On 8/30/23 14:37, Lukas Wagner wrote: These patches should fix issues with certain special characters (e.g ü) in the notification configuration [1]. Before, when setting a comment for an endpoint to certain values (e.g. 'für admins'), the resulting saved configuration would contain invalid UTF8 t

Re: [pve-devel] [PATCH guest-common] replication: avoid passing removed storages to target

2023-09-01 Thread Thomas Lamprecht
Am 30/08/2023 um 11:42 schrieb Fiona Ebner: > Am 30.08.23 um 11:27 schrieb Thomas Lamprecht: >> Am 23/06/2023 um 12:08 schrieb Fiona Ebner: >>> +# filter out left-over non-existing/removed storages - avoids error on >>> target >>> +$state->{storeid_list} = [ grep { $storecfg->{ids}->{$_} }

Re: [pve-devel] [PATCH manager] ui: replication: backup: use renderEnabledIcon to render the enabled column

2023-09-01 Thread Lukas Wagner
Ping On 7/18/23 11:53, Lukas Wagner wrote: Signed-off-by: Lukas Wagner --- www/manager6/dc/Backup.js| 3 +-- www/manager6/grid/Replication.js | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js index 03a02651.

Re: [pve-devel] [PATCH manager 1/3] ui: ldap: ad: support 'mode' paramter, replacing 'secure'

2023-09-01 Thread Lukas Wagner
Ping. Still applies on master. On 7/27/23 10:57, Lukas Wagner wrote: The backend has supported the 'mode' parameter for quite a while, however it has not yet been exposed in the GUI, contrary to PMG and PBS. The benefit of 'mode' is that it supports LDAP, LDAPS and LDAP via STARTTLS, compared t