Re: [pve-devel] [PATCH ifupdown2] patch: fix ipv6 slaac on bridge

2023-08-09 Thread DERUMIER, Alexandre
Hi, could it be possible to apply this patch ? some users are still waiting for have working slaac https://forum.proxmox.com/threads/mgmt-lan-with-slaac-from-a-delegate-prefix.123969/ Le mardi 27 juin 2023 à 12:56 +0200, Alexandre Derumier a écrit : > reported on the forum > https://antiphi

[pve-devel] [PATCH v3 qemu-server] fix #3963: Skip TPM startup for template VMs

2023-08-09 Thread Filip Schauer
Skip the software TPM startup when starting a template VM for performing a backup. This fixes an error that occurs when the TPM state disk is write-protected. Signed-off-by: Filip Schauer --- Changes since v2: * Do not add the TPM to the command line arguments when VM is a template PVE/QemuServ

[pve-devel] [PATCH manager v3 0/2] fix #474: allow transfer from container/vms

2023-08-09 Thread Philipp Hufnagl
changes to v3: fix subject typo at version log changes to v2: split patch in front and backend When a member of 2 pools wants to transfer a vm/container to an other pool they can not do that. The vm/container would have first to be removed form the current pool resulting in a loss of privilege

[pve-devel] [PATCH manager v3 2/2] fix #474: frontend: allow transfer from container/vms

2023-08-09 Thread Philipp Hufnagl
When a member of 2 pools wants to transfer a vm/container to an other pool they can not do that. The vm/container would have first to be removed form the current pool resulting in a loss of privileges of the pool member for this vm/contianer. This feature introduces a way to transfer a vm betwe

[pve-devel] [PATCH manager v3 1/2] fix #474: backend: allow transfer from container/vms

2023-08-09 Thread Philipp Hufnagl
When a member of 2 pools wants to transfer a vm/container to an other pool they can not do that. The vm/container would have first to be removed form the current pool resulting in a loss of privileges of the pool member for this vm/contianer. This feature introduces a way to transfer a vm betwe

[pve-devel] [PATCH manager v2 2/2] fix #474: backend allow transfer from container/vms

2023-08-09 Thread Philipp Hufnagl
When a member of 2 pools wants to transfer a vm/container to an other pool they can not do that. The vm/container would have first to be removed form the current pool resulting in a loss of privileges of the pool member for this vm/contianer. This feature introduces a way to transfer a vm betwe

[pve-devel] [PATCH manager v2 0/2] fix #474: allow transfer from container/vms

2023-08-09 Thread Philipp Hufnagl
When a member of 2 pools wants to transfer a vm/container to an other pool they can not do that. The vm/container would have first to be removed form the current pool resulting in a loss of privileges of the pool member for this vm/contianer. This feature introduces a way to transfer a vm betwe

[pve-devel] [PATCH manager v2 1/2] fix #474: backend: allow transfer from container/vms

2023-08-09 Thread Philipp Hufnagl
When a member of 2 pools wants to transfer a vm/container to an other pool they can not do that. The vm/container would have first to be removed form the current pool resulting in a loss of privileges of the pool member for this vm/contianer. This feature introduces a way to transfer a vm betwe

Re: [pve-devel] [PATCH manager] fix #474: allow transfer from container/vms

2023-08-09 Thread Philipp Hufnagl
On 8/9/23 13:32, Fiona Ebner wrote: The permission for the original pool should be checked here?! Or is that already done somewhere? The permission of the original pool does not matter. The permission of the VM is important (maybe the original pool granting the user permission on the VM). H

[pve-devel] [PATCH v4 qemu] fix #1534: vma: Add extract filter for disk images

2023-08-09 Thread Filip Schauer
Add a filter to the "vma extract" command. A comma seperated list of disk images that should be extracted can be passed with the "-d" option. Example to extract an IDE drive and an SCSI drive from vzdump.vma: vma extract vzdump.vma -d "drive-ide0,drive-scsi0" extractdir Signed-off-by: Filip Scha

[pve-devel] [PATCH v3 qemu] fix #1534: vma: Add extract filter for disk images

2023-08-09 Thread Filip Schauer
Add a filter to the "vma extract" command. A comma seperated list of disk images that should be extracted can be passed with the "-d" option. Example to extract an IDE drive and an SCSI drive from vzdump.vma: vma extract vzdump.vma -d "drive-ide0,drive-scsi0" extractdir Signed-off-by: Filip Scha

[pve-devel] [PATCH installer 5/6] sys: block: fix possible use of `undef`-value when detecting disk sizes

2023-08-09 Thread Christoph Heiss
`$size` and `$logical_bsize` might get unset if there invalid, but then are unconditionally converted to an int - which throws an error. This was reported on the forum by a user [0]. Fix it by changing the check a bit to skip the disk immediately if detecting either of those two values are invalid

[pve-devel] [PATCH installer 6/6] tui: setup: handle missing disk block size gracefully

2023-08-09 Thread Christoph Heiss
As that value can indeed be undefined, handle that (edge-)case gracefully. There is only one place where it is checked, in the ZFS RAID setup dialog. Aligns it with how the low-level installer handles that case too. Signed-off-by: Christoph Heiss --- proxmox-tui-installer/src/options.rs|

[pve-devel] [PATCH installer 0/6] some small, assorted fixes & cleanups

2023-08-09 Thread Christoph Heiss
#1-#4 are pretty self-explanatory, #5 and #6 might be worth bit more attention. Christoph Heiss (6): tui: drop some leftover, commented-out code tui: password: include minimum password length in error message tui: network: select matching NIC for IP configuration tui: setup: fix disk size

[pve-devel] [PATCH installer 3/6] tui: network: select matching NIC for IP configuration

2023-08-09 Thread Christoph Heiss
Instead of always just selecting an essentially random NIC (depending on the enumeration), use the correct one for the rest of the (DHCP-obtained) IP configuration. Signed-off-by: Christoph Heiss --- proxmox-tui-installer/src/main.rs | 9 - 1 file changed, 8 insertions(+), 1 deletion(-)

[pve-devel] [PATCH installer 2/6] tui: password: include minimum password length in error message

2023-08-09 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- proxmox-tui-installer/src/main.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxmox-tui-installer/src/main.rs b/proxmox-tui-installer/src/main.rs index 83a4d60..4782fa2 100644 --- a/proxmox-tui-installer/src/main.rs +++ b/proxmox-tui-i

[pve-devel] [PATCH installer 1/6] tui: drop some leftover, commented-out code

2023-08-09 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- proxmox-tui-installer/src/main.rs | 2 -- 1 file changed, 2 deletions(-) diff --git a/proxmox-tui-installer/src/main.rs b/proxmox-tui-installer/src/main.rs index 7bfaf9b..83a4d60 100644 --- a/proxmox-tui-installer/src/main.rs +++ b/proxmox-tui-installer/src/ma

[pve-devel] [PATCH installer 4/6] tui: setup: fix disk size for 4Kn block devices

2023-08-09 Thread Christoph Heiss
This can be tested by creating a block device with 4K sectorsize using the following QEMU args: -device virtio-blk,drive=testdrive4k,logical_block_size=4096,physical_block_size=4096 -drive file=/path/to/4k-testdisk.img,if=none,id=testdrive4k The 4k-testdisk.img was created with: qemu-img cr

Re: [pve-devel] [PATCH v2 qemu-server] fix #3963: Skip TPM startup for template VMs

2023-08-09 Thread Fiona Ebner
Am 09.08.23 um 11:22 schrieb Filip Schauer: > Skip the software TPM startup when starting a template VM for performing > a backup. This fixes an error that occurs when the TPM state disk is > write-protected. > > Signed-off-by: Filip Schauer > --- > PVE/QemuServer.pm | 2 +- > 1 file changed, 1

Re: [pve-devel] [PATCH manager] fix #474: allow transfer from container/vms

2023-08-09 Thread Fiona Ebner
Am 08.08.23 um 11:13 schrieb Philipp Hufnagl: > When a member of 2 pools wants to transfer a > vm/container to an other pool they can not do that. The vv/container would > have first to be removed form the current pool resulting in a loss of > privileges of the pool member for this vm/contianer.

Re: [pve-devel] [PATCH v2 qemu] fix #1534: vma: Add extract filter for disk images

2023-08-09 Thread Fiona Ebner
Am 08.08.23 um 14:00 schrieb Filip Schauer: > @@ -1772,7 +1772,7 @@ index 00..304f02bc84 > +"vma list \n" > +"vma config [-c config]\n" > +"vma create [-c config] pathname ...\n" > -+"vma extract [-r ] \n" > ++"vma extract [-f ] [-r ] \n" Not

[pve-devel] [PATCH v2 pmg-gui 4/4] Revert "fix tracking center with newer proxmox-widget-toolkit"

2023-08-09 Thread Christian Ebner
The DateTimeField now defines its own ViewModel, therefore the MailTrackerFilter container doesn't need one to be inherited to the child. This reverts commit 6f3f8ac5cc88ac3c71aed4269688193e5dd6c728. --- changes since v1: - not part of v1, reverts hotfix needed by changes introduced by patch in

[pve-devel] [PATCH v2 manager 3/3] fix #4442: Add date-time filtering for firewall logs

2023-08-09 Thread Christian Ebner
Extend the current firewall log view to add date time based filtering. The user can switch between live view, which shows logs from the unrotated log file, or to filter mode, where date time based filtering, including rotated logs can be performed. Enable the feature by setting the property and th

[pve-devel] [PATCH v2 proxmox-widget-toolkit manager pmg-gui 0/4] #4442: impl firewall log filtering

2023-08-09 Thread Christian Ebner
This series is send to pmg-devel and pve-devel list, as it changes the DateTimeField used by Proxmox Virtual Environment and Proxmox Mail Gateway. This series of patches implements functionality to extend the firewall log panel to filter the logs by date and time. The series consists of patches f

[pve-devel] [PATCH v2 proxmox-widget-toolkit 1/2] fix #4442: adapt DateTimeField to be more declarative

2023-08-09 Thread Christian Ebner
Reworks the current implementation of the DateTimeField to be more declarative by using a ViewModel and data bindings as well as formulas, in order to reduce code and unwanted complexity. Signed-off-by: Christian Ebner --- changes since v1: - This patch was not part of the previous series, but i

[pve-devel] [PATCH v2 proxmox-widget-toolkit 2/2] fix #4442: Extend LogView for firewall datetime filtering

2023-08-09 Thread Christian Ebner
Extends the current panels date filtering capability to date-time based filtering, and adds a config option to switch between livemode and filter mode, analogous to the JournalView panel. The `submitFormat` config is introduced to adapt the formatting of params values for their corresponding api c

Re: [pve-devel] [PATCH v2 qemu-server] fix #3963: Skip TPM startup for template VMs

2023-08-09 Thread Filip Schauer
I messed up the formatting the formatting there. What I meant to say: Changes since v1: * Add a missing not sign in front of the is_template check > On 09.08.2023 11:22 CEST Filip Schauer wrote: > > > Skip the software TPM startup when starting a template VM for performing > a backup. This fi

[pve-devel] [PATCH storage/manager v5 1/1] fix #4849: download to storage: automatically dectect and configure compression

2023-08-09 Thread Philipp Hufnagl
extend the user interface of of the "Download from Url" dialog with an option to choose a decompression algorithm to decomppress the image after download. extended the query_url_metadata function to also automatically determine if a decompression is needed. If it is it will be automatically set in

[pve-devel] [PATCH storage/manager v5 0/2] fix #4849: allow download of compressed ISOs

2023-08-09 Thread Philipp Hufnagl
Many web pages offer the download of the disk images compressed. This patch allows the download of archives (like .gz), automatically detects the format and decompresses it Changes since v4: * add commit messages * fix nit Changes since v3: * generate compression regex from compression list

[pve-devel] [PATCH storage/manager v5 1/1] fix #4849: download-url: allow download and decompression of compressed ISOs

2023-08-09 Thread Philipp Hufnagl
extend the download_url function with the capabillity to handle compression add decopressor info for images build compression algorithm regex dynamically to avoid duplication Signed-off-by: Philipp Hufnagl --- src/PVE/API2/Storage/Status.pm | 14 +- src/PVE/Storage.pm |

[pve-devel] [PATCH v2 qemu-server] fix #3963: Skip TPM startup for template VMs

2023-08-09 Thread Filip Schauer
Skip the software TPM startup when starting a template VM for performing a backup. This fixes an error that occurs when the TPM state disk is write-protected. Signed-off-by: Filip Schauer --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm

[pve-devel] [PATCH qemu-server] fix #3963: Skip TPM startup for template VMs

2023-08-09 Thread Filip Schauer
Skip the software TPM startup when starting a template VM for performing a backup. This fixes an error that occurs when the TPM state disk is write-protected. Signed-off-by: Filip Schauer --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm

[pve-devel] [PATCH manager v7 11/11] ui: add options to add virtio-fs to qemu config

2023-08-09 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/Makefile | 1 + www/manager6/Utils.js | 1 + www/manager6/qemu/HardwareView.js | 19 www/manager6/qemu/VirtiofsEdit.js | 146 ++ 4 files changed, 167 insertions(+) create mode 100644 www/ma

[pve-devel] [PATCH qemu-server v7 4/11] feature #1027: virtio-fs support

2023-08-09 Thread Markus Frank
add support for sharing directories with a guest vm virtio-fs needs virtiofsd to be started. In order to start virtiofsd as a process (despite being a daemon it is does not run in the background), a double-fork is used. virtiofsd should close itself together with qemu. There are the parameters

[pve-devel] [PATCH manager v7 08/11] ui: add edit window for dir mappings

2023-08-09 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/Makefile | 1 + www/manager6/window/DirMapEdit.js | 222 ++ 2 files changed, 223 insertions(+) create mode 100644 www/manager6/window/DirMapEdit.js diff --git a/www/manager6/Makefile b/www/manager6/Makefile i

[pve-devel] [PATCH qemu-server v7 5/11] Permission check for virtiofs directory access

2023-08-09 Thread Markus Frank
Signed-off-by: Markus Frank --- PVE/API2/Qemu.pm | 18 ++ 1 file changed, 18 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 9606e72..65830f9 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -586,6 +586,19 @@ my $check_vm_create_serial_perm = sub {

[pve-devel] [PATCH manager v7 10/11] ui: form: add DIRMapSelector

2023-08-09 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/Makefile | 1 + www/manager6/form/DIRMapSelector.js | 63 + 2 files changed, 64 insertions(+) create mode 100644 www/manager6/form/DIRMapSelector.js diff --git a/www/manager6/Makefile b/www/manager6/Makefile

[pve-devel] [PATCH docs v7 3/11] added shared filesystem doc for virtio-fs

2023-08-09 Thread Markus Frank
Signed-off-by: Markus Frank --- qm.adoc | 70 +++-- 1 file changed, 68 insertions(+), 2 deletions(-) diff --git a/qm.adoc b/qm.adoc index e35dbf0..8f4020d 100644 --- a/qm.adoc +++ b/qm.adoc @@ -997,6 +997,71 @@ recommended to always use a limit

[pve-devel] [PATCH cluster v7 1/11] add mapping/dir.cfg for resource mapping

2023-08-09 Thread Markus Frank
Add it to both, the perl side (PVE/Cluster.pm) and pmxcfs side (status.c). Signed-off-by: Markus Frank --- src/PVE/Cluster.pm | 1 + src/pmxcfs/status.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm index ff777ba..39f2d99 100644 --- a/src/PVE/Clus

[pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v6 0/11] virtiofs

2023-08-09 Thread Markus Frank
qemu-server patches require pve-guest-common and pve-cluster patches pve-manager patches require the pve-doc patch I did not get virtiofsd to run with run_command without creating zombie processes after stutdown. So I replaced run_command with exec for now. Maybe someone can find out why this hap

[pve-devel] [PATCH manager v7 07/11] api: add resource map api endpoints for directories

2023-08-09 Thread Markus Frank
Signed-off-by: Markus Frank --- PVE/API2/Cluster/Mapping.pm | 7 + PVE/API2/Cluster/Mapping/Dir.pm | 309 ++ PVE/API2/Cluster/Mapping/Makefile | 3 +- 3 files changed, 318 insertions(+), 1 deletion(-) create mode 100644 PVE/API2/Cluster/Mapping/Dir.pm dif

[pve-devel] [PATCH manager v7 09/11] ui: ResourceMapTree for DIR

2023-08-09 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/Makefile | 1 + www/manager6/dc/Config.js | 10 +++ www/manager6/dc/DIRMapView.js | 50 +++ 3 files changed, 61 insertions(+) create mode 100644 www/manager6/dc/DIRMapView.js diff --git a/www/manager6/

[pve-devel] [PATCH qemu-server v7 6/11] check_local_resources: virtiofs

2023-08-09 Thread Markus Frank
add dir mapping checks to check_local_resources Signed-off-by: Markus Frank --- PVE/QemuServer.pm| 10 +- test/MigrationTest/Shared.pm | 7 +++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index d547dd6..e74d867 100

[pve-devel] [PATCH guest-common v7 2/11] add Dir mapping config

2023-08-09 Thread Markus Frank
Adds a config file for directories by using a 'map' array propertystring for each node mapping. Next to node & path, there is the optional submounts parameter in the map array. Additionally there are the default settings for xattr & acl. example config: ``` some-dir-id map node=node1,path