Signed-off-by: Philipp Hufnagl
---
src/PVE/Tools.pm | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index 159ec82..28e70f0 100644
--- a/src/PVE/Tools.pm
+++ b/src/PVE/Tools.pm
@@ -92,23 +92,23 @@ our $EMAIL_U
Changes since v3:
* generate compression regex from compression list
* fix logic errors
Changes since v2:
* move compression code to the download function in common
* minor code improvements
Changes since v1:
* Improve code quality as suggested by feedback
Philipp Hufnagl (2):
fix
Signed-off-by: Philipp Hufnagl
---
src/PVE/Storage/Plugin.pm | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
index 18cb5d5..1795ae3 100644
--- a/src/PVE/Storage/Plugin.pm
+++ b/src/PVE/Storage/Plugi
Signed-off-by: Philipp Hufnagl
---
src/PVE/Tools.pm | 31 +--
1 file changed, 25 insertions(+), 6 deletions(-)
diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index 9ffac12..159ec82 100644
--- a/src/PVE/Tools.pm
+++ b/src/PVE/Tools.pm
@@ -2013,10 +2013,13 @@ sub down
Signed-off-by: Philipp Hufnagl
---
PVE/API2/Nodes.pm | 21 -
www/manager6/Makefile | 1 +
www/manager6/form/DecompressionSelector.js | 13 +
www/manager6/window/DownloadUrlToStorage.js | 17 +
4 file
Signed-off-by: Philipp Hufnagl
---
PVE/API2/Nodes.pm | 16
www/manager6/window/DownloadUrlToStorage.js | 4 ++--
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index 2bae4e6f..6fa138fb 100644
--- a
Signed-off-by: Philipp Hufnagl
---
src/PVE/API2/Storage/Status.pm | 14 +-
src/PVE/Storage.pm | 6 ++
src/PVE/Storage/Plugin.pm | 3 ++-
3 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage/Status.
The checkbox is enabled by default, setting the new `check-connection`
parameter. See also [0] for the rationale.
[0] https://lists.proxmox.com/pipermail/pve-devel/2023-July/058559.html
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* Add "Check connection" checkbox to AD edit too
As th
First of, remove the dreaded LDAP DN regex.
Further, upon saving a LDAP realm in the UI, it tries to connect & bind
using the provided credentials, providing the user with immediate
feedback whether they are valid or not.
The same approach is already implemented in PBS [0], and I'll plan to
imple
Most codepaths already have explicit error handling (by the means of
checking the return value), which is essential dead code due to setting
`onerror`.
As LDAP errors might get presented to users due to upcoming changes, the
error location should not be present in these error messages, thus
switch
Removes the dreaded DN regex, instead introducing a optional
connect/bind check on creation/update, aligning it with the way PBS does
it.
Additionally, it has the benefit that instead of letting a sync fail on
the first try due to e.g. bad bind credentials, it gives the user some
direct feedback w
On Fri, Jul 28, 2023 at 10:37:12AM +0200, Lukas Wagner wrote:
>
> On Thu Jul 27, 2023 at 3:33 PM CEST, Christoph Heiss wrote:
> > The checkbox is enabled by default for new realms, setting the new
> > `check-connection` parameter.
> >
> > Won't effect existing configurations, i.e. being opt-in fo
Thanks for the review!
On Fri, Jul 28, 2023 at 10:29:26AM +0200, Lukas Wagner wrote:
>
> On Thu Jul 27, 2023 at 3:33 PM CEST, Christoph Heiss wrote:
> > [..]
>
> I think it would be enough to have the 'check-connection' parameter only for
> the API call itself, I wouldn't store it in the domains
... and warn if at least one is present.
Signed-off-by: Christian Ebner
---
changes since v1:
* do not use which to check for dkms, use exit code directly
PVE/CLI/pve7to8.pm | 22 ++
1 file changed, 22 insertions(+)
diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm
inde
14 matches
Mail list logo
