On 13/03/2023 13:56, Friedrich Weber wrote:
> Trying to regenerate a cloudinit drive as a non-root user via the API
> currently throws a Perl error, as reported in the forum [1]. This is
> due to a type mismatch in the permission check, where a string is
> passed but an array is expected.
>
> [1]
On 25/07/2023 13:00, Aaron Lauterer wrote:
> They are underdocumented and finding information is not that easy.
>
> Signed-off-by: Aaron Lauterer
> ---
> changes:
> * added reference anchor for easier linking
> * use link to manpages.debian.org instead of github
>
>
> the corosync-doc package d
On 18/07/2023 11:10, Fabian Grünbichler wrote:
> and force upgrade of proxmox-kernel-helper with support for the new package
> names.
>
> Signed-off-by: Fabian Grünbichler
> ---
>
> Notes:
> we could rename pve-headers to pmg-headers and Provides/Replaces/Breaks
> pve-headers with a version
On 18/07/2023 11:10, Fabian Grünbichler wrote:
> diff --git a/src/PMG/CLI/pmg7to8.pm b/src/PMG/CLI/pmg7to8.pm
> index 85e9f16..8cccde1 100644
> --- a/src/PMG/CLI/pmg7to8.pm
> +++ b/src/PMG/CLI/pmg7to8.pm
> @@ -193,7 +193,7 @@ sub check_pmg_packages {
> }
>
> # FIXME: better different
Fixes #4856 [0].
Patch #1 and #2 are preparatory patches only, #3 the actual fix.
[0] https://bugzilla.proxmox.com/show_bug.cgi?id=4856
Changes v1 -> v2:
* rebased series on latest master; such that it applies cleanly again
v1: https://lists.proxmox.com/pipermail/pve-devel/2023-July/058400.ht
Will be used/passed around quite a lot of times due to future changes,
so simplify it a bit.
No functional changes.
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* No changes
proxmox-tui-installer/src/views/bootdisk.rs | 12
1 file changed, 8 insertions(+), 4 deletions(-)
The size of the install disk was set to the size of the first disk,
regardless of what disk was selected. This only happened if the advanced
options dialog was never opened, and only a disk was selected in the
main bootdisk dialog.
This has quite a bit of churn, but properly solving this involved
This better conveys its role/contents to the reader, as `disks` might be
ambiguous.
No functional changes.
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* No changes
proxmox-tui-installer/src/views/bootdisk.rs | 45 -
1 file changed, 27 insertions(+), 18 deletions(
On 25/07/2023 13:52, Friedrich Weber wrote:
> These two patches add some `htmlEncode` calls/renderers that
> had been missing to proxmox-widget-toolkit and pve-manager.
> Each patch can be individually applied.
>
>
>
> widget-toolkit:
>
> Friedrich Weber (1):
> ui: add some missing `htmlEncod
removed Data::Dumper and a newline
Signed-off-by: Philipp Hufnagl
---
src/PVE/API2/Storage/Status.pm | 18 +--
src/PVE/Storage.pm | 55 +-
src/PVE/Storage/Plugin.pm | 3 +-
3 files changed, 37 insertions(+), 39 deletions(-)
diff --git a/
Signed-off-by: Philipp Hufnagl
---
PVE/API2/Nodes.pm | 21 -
www/manager6/Makefile | 1 +
www/manager6/form/DecompressionSelector.js | 14 +++
www/manager6/window/DownloadUrlToStorage.js | 26 +++--
4 files
Signed-off-by: Philipp Hufnagl
---
src/PVE/API2/Storage/Status.pm | 20 ++--
src/PVE/Storage.pm | 22 ++
2 files changed, 40 insertions(+), 2 deletions(-)
diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage/Status.pm
index e4ce698..9
Many web pages offer the download of the disk images compressed. This
patch allows the download of archives (like .gz), automatically detects
the format and decompresses it
pve-storage:
Philipp Hufnagl (2):
fix #4849: download-url: allow download and decompression of
compressed ISOs
clean:
On 25/07/2023 11:54, Thomas Lamprecht wrote:
> How about a get_vm_user_cloudinit_options helper located directly
> below the format definition, filtering out those keys that do not
> make sense, or are off limits, and use that?
The helper sounds good! AFAICT, $cloudinitoptions contains exactly all
For the most part, query_users() and query_groups() are identical, so
extract the common part into a separate method and let
query_{users,groups}() be simple wrappers over it.
No change in functionality.
Signed-off-by: Christoph Heiss
---
src/PVE/LDAP.pm | 192 --
Signed-off-by: Friedrich Weber
---
src/form/NetworkSelector.js | 1 +
src/node/APTRepositories.js | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/form/NetworkSelector.js b/src/form/NetworkSelector.js
index 86d394d..ed3a02b 100644
--- a/src/form/NetworkSelector.js
+++ b/src/form/NetworkS
These two patches add some `htmlEncode` calls/renderers that
had been missing to proxmox-widget-toolkit and pve-manager.
Each patch can be individually applied.
widget-toolkit:
Friedrich Weber (1):
ui: add some missing `htmlEncode`s
src/form/NetworkSelector.js | 1 +
src/node/APTRepositorie
Signed-off-by: Friedrich Weber
---
www/manager6/Utils.js | 9 ++---
www/manager6/dc/BackupJobDetail.js | 1 +
www/manager6/dc/PCIMapView.js | 2 +-
www/manager6/dc/USBMapView.js | 2 +-
www/manager6/form/PCIMapSelector.js | 1 +
www/manager6/form/USBMapSelector.js |
They are underdocumented and finding information is not that easy.
Signed-off-by: Aaron Lauterer
---
changes:
* added reference anchor for easier linking
* use link to manpages.debian.org instead of github
the corosync-doc package does ship HTML documentation, but no man pages,
therefore on
On 24/07/2023 14:54, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer
> ---
> pvecm.adoc | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>
applied this one for now, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
On 24/07/2023 13:33, Friedrich Weber wrote:
> The new ciupgrade option was missing in $cloudinitoptions in
> PVE::API2::Qemu, so $check_vm_modify_config_perm defaulted to
> requiring root@pam for modifying the option. To fix this, add
> ciupgrade to $cloudinitoptions. This also fixes an issue where
On 24/07/2023 12:14, Christoph Heiss wrote:
> pve-installer:
>
> Christoph Heiss (6):
> tui: simplify duplicate disk checking logic
> tui: deserialize boot type and disk blocksize from runtime env info
> tui: improve bootdisk dialog error handling
> tui: add RAID setup checks for ZFS/Btrfs
On 7/25/23 11:17, Thomas Lamprecht wrote:
On 24/07/2023 14:54, Aaron Lauterer wrote:
They are underdocumented and finding information is not that easy.
Signed-off-by: Aaron Lauterer
---
Found some info in the suse documentation [0] and the sourcecode [1].
Yes, like it was mentioned on the
On 24/07/2023 14:54, Aaron Lauterer wrote:
> They are underdocumented and finding information is not that easy.
>
> Signed-off-by: Aaron Lauterer
> ---
>
> Found some info in the suse documentation [0] and the sourcecode [1].
Yes, like it was mentioned on the chat a bit ago, luckily we use open
On 20/07/2023 16:32, Lukas Wagner wrote:
doesn't hurt to have a commit message describing that the underlying
rust code is just wired up and such a few general (or also gotify
specific) details; doesn't have to be multiple paragraphs, but a bit
of context can only help IME.
> Signed-off-by: Lukas
The size of the install disk was set to the size of the first disk,
regardless of what disk was selected. This only happened if the advanced
options dialog was never opened, and only a disk was selected in the
main bootdisk dialog.
This has quite a bit of churn, but properly solving this involved
This better conveys its role/contents to the reader, as `disks` might be
ambiguous.
No functional changes.
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/views/bootdisk.rs | 45 -
1 file changed, 27 insertions(+), 18 deletions(-)
diff --git a/proxmox-tui-insta
Will be used/passed around quite a lot of times due to future changes,
so simplify it a bit.
No functional changes.
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/views/bootdisk.rs | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/proxmox-tui-insta
Fixes #4856 [0].
Patch #1 and #2 are preparatory patches only, #3 the actual fix.
[0] https://bugzilla.proxmox.com/show_bug.cgi?id=4856
Christoph Heiss (3):
tui: bootdisk: refactor Rc> type into custom type
tui: bootdisk: rename `disks` parameter to `avail_disks`
fix #4856: tui: bootdisk:
Forgot to add to the changelog that symlinked files now also show the
size of the file not of the symlink
On 21-07-2023 14:23, Noel Ullreich wrote:
This patch fixes #623, allowing isos/vztmpl/snippets in subdirectories.
This feature is opt-in and can be set from the API, web interface or
with `
applied, with the missing `_all` suffix after the version ;-)
On Mon, Jul 24, 2023 at 03:29:52PM +0200, Lukas Wagner wrote:
> Signed-off-by: Lukas Wagner
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index 3c4ecec..8b2259c 100644
> --- a/Makefil
31 matches
Mail list logo
