[pve-devel] [PATCH pve-cluster] pve-cluster.service : remove 127.0.1.1 from /etc/hosts

2023-06-27 Thread Alexandre Derumier
stock debian or some hosting company like ovh through cloudinit at each boot, add 127.0.1.1 in /etc/hosts. This is breaking pve-cluster start. fix: https://forum.proxmox.com/threads/proxmox-7-to-8-upgrade-problem-ovh.129678/ https://forum.proxmox.com/threads/update-7-to-8-issue-with-cloud-init.1

[pve-devel] applied: [PATCH installer v2] tui: persist disk selection for zfs and btrfs

2023-06-27 Thread Thomas Lamprecht
Am 27/06/2023 um 16:15 schrieb Stefan Sterz: > previously the disk selection was reset if the advanced options > dialogue was re-opened. this commit adapts the behavior to restore > the previous selection. > > Signed-off-by: Stefan Sterz > --- > changes since v2 (thanks @Maximiliano Sandoval): >

[pve-devel] [PATCH installer v2] tui: persist disk selection for zfs and btrfs

2023-06-27 Thread Stefan Sterz
previously the disk selection was reset if the advanced options dialogue was re-opened. this commit adapts the behavior to restore the previous selection. Signed-off-by: Stefan Sterz --- changes since v2 (thanks @Maximiliano Sandoval): * added a comment that the updated `change_default` function

Re: [pve-devel] [PATCH installer] tui: persist disk selection for zfs and btrfs

2023-06-27 Thread Stefan Sterz
On 27.06.23 15:57, Lukas Wagner wrote: > > > On 6/27/23 15:34, Maximiliano Sandoval wrote: >>>     impl BtrfsBootdiskOptions { >>> -    pub fn defaults_from(disk: &Disk) -> Self { >>> +    pub fn defaults_from(disks: &[Disk]) -> Self { >>> +    let disk = &disks[0]; >>>   Self { >>>  

Re: [pve-devel] [PATCH installer] tui: persist disk selection for zfs and btrfs

2023-06-27 Thread Lukas Wagner
On 6/27/23 15:34, Maximiliano Sandoval wrote: impl BtrfsBootdiskOptions { -pub fn defaults_from(disk: &Disk) -> Self { +pub fn defaults_from(disks: &[Disk]) -> Self { +let disk = &disks[0]; Self { disk_size: disk.size, +selected_disks: (

[pve-devel] applied: [PATCH proxmox-backup/docs 2/2] Fixed spelling of command line/command-line

2023-06-27 Thread Thomas Lamprecht
Am 27/06/2023 um 14:40 schrieb Noel Ullreich: > Commandline/command line/command-line where being used interchangably, > which is not correct > (see: > https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/c/command-line). > use command-line when it is an adjective (e.g. "co

[pve-devel] applied: [PATCH proxmox-backup/docs 1/2] consistenct of USB flash drive spelling

2023-06-27 Thread Thomas Lamprecht
Am 27/06/2023 um 14:40 schrieb Noel Ullreich: > To be consistent, replaced all synonyms of USB flash drive (e.g. thumb > drive, drive, stick) > > Signed-off-by: Noel Ullreich > --- > docs/backup-client.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, albeit spotted the

Re: [pve-devel] [PATCH installer] tui: persist disk selection for zfs and btrfs

2023-06-27 Thread Maximiliano Sandoval
> On 27.06.2023 14:54 CEST Stefan Sterz wrote: > > > previously the disk selection was reset if the advanced options > dialogue was re-opened. this commit adapts the behavior to restore > the previous selection. > > Signed-off-by: Stefan Sterz > --- > proxmox-tui-installer/src/options.rs

[pve-devel] [PATCH installer] tui: persist disk selection for zfs and btrfs

2023-06-27 Thread Stefan Sterz
previously the disk selection was reset if the advanced options dialogue was re-opened. this commit adapts the behavior to restore the previous selection. Signed-off-by: Stefan Sterz --- proxmox-tui-installer/src/options.rs| 11 +-- proxmox-tui-installer/src/views/bootdisk.rs | 36 ++

[pve-devel] [PATCH proxmox-backup/docs 2/2] Fixed spelling of command line/command-line

2023-06-27 Thread Noel Ullreich
Commandline/command line/command-line where being used interchangably, which is not correct (see: https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/c/command-line). use command-line when it is an adjective (e.g. "command-line interface") and use command line when it is a

[pve-devel] [PATCH pve-docs 3/4] consistenct of USB flash drive spelling

2023-06-27 Thread Noel Ullreich
To be consistent, replaced all synonyms of USB flash drive (e.g. thumb drive, drive, stick) Signed-off-by: Noel Ullreich --- pve-installation-media.adoc | 2 +- pve-storage-pbs.adoc| 2 +- qm.conf.5-opts.adoc | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/

[pve-devel] [PATCH pve-docs 1/4] consistency of passthrough/pass-through

2023-06-27 Thread Noel Ullreich
Fix consistency issues as well as grammatical mistakes with the spelling of passthough/pass-through/pass through in the pve docs Signed-off-by: Noel Ullreich --- qm.adoc | 8 qm.conf.5-opts.adoc | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/qm.

[pve-devel] [PATCH pmg-docs; pmg-docs; proxmox-backup/docs 0/8] fix consistency of some words

2023-06-27 Thread Noel Ullreich
In the docs for pve, pmg, and pbs, the consistency and grammatical correctnes of some common words was not always good. I fixed the words: * USB flash drive * command line/command-line/commandline * motherboard/mainboard/main board * passhrough/pass-through Really, these are just some quick ones I

[pve-devel] [PATCH pve-docs 4/4] Fixed spelling of command line/command-line

2023-06-27 Thread Noel Ullreich
Commandline/command line/command-line where being used interchangably, which is not correct (see: https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/c/command-line). use command-line when it is an adjective (e.g. "command-line interface") and use command line when it is a

[pve-devel] [PATCH pmg-docs 2/2] Fixed spelling of command line/command-line

2023-06-27 Thread Noel Ullreich
Commandline/command line/command-line where being used interchangably, which is not correct (see: https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/c/command-line). use command-line when it is an adjective (e.g. "command-line interface") and use command line when it is a

[pve-devel] [PATCH pmg-docs 1/2] consistenct of USB flash drive spelling

2023-06-27 Thread Noel Ullreich
To be consistent, replaced all synonyms of USB flash drive (e.g. thumb drive, drive, stick) Signed-off-by: Noel Ullreich --- pmg-installation-media.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pmg-installation-media.adoc b/pmg-installation-media.adoc index 53d7e1a..ba

[pve-devel] [PATCH pve-docs 2/4] consistency: change mainboard to motherboard

2023-06-27 Thread Noel Ullreich
To be consistent, replaced all instances of mainboard/main board with motherboard. Signed-off-by: Noel Ullreich --- ha-manager.adoc | 2 +- pve-system-requirements.adoc | 2 +- qm-pci-passthrough.adoc | 2 +- qm.adoc | 2 +- 4 files changed, 4 insertions(+)

[pve-devel] [PATCH proxmox-backup/docs 1/2] consistenct of USB flash drive spelling

2023-06-27 Thread Noel Ullreich
To be consistent, replaced all synonyms of USB flash drive (e.g. thumb drive, drive, stick) Signed-off-by: Noel Ullreich --- docs/backup-client.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/backup-client.rst b/docs/backup-client.rst index 2b5c481e..a54b5499 100644

[pve-devel] [PATCH ifupdown2] patch: fix ipv6 slaac on bridge

2023-06-27 Thread Alexandre Derumier
reported on the forum https://forum.proxmox.com/threads/hi-i-stumble-upon-ipv6-slaac-issue-after-updating-to-pve8-0-3.129553 the sysctl accept_ra|autoconf was not applied on bridge interfaces Signed-off-by: Alexandre Derumier --- ...6-slaac-support-inet6-auto-accept_ra.patch | 45 +-

[pve-devel] [PATCH storage] cifs: bubble up NT_STATUS_INVALID_PARAMETER during connection check

2023-06-27 Thread Fiona Ebner
instead of claiming that the storage is not online. Would've made the issue fixed by b27da68 ("cifs: fix check connection call") more obvious, because (the UI passes along an empty string for domain if not set and) the smbclient call returns that status with > -W '' in Bookworm. Signed-off-by: Fi