Re: [pve-devel] [RFC PATCH common] section config: implement array support

2023-05-10 Thread Wolfgang Bumiller
On Wed, May 10, 2023 at 01:48:11PM +0200, Fabian Grünbichler wrote: > On May 10, 2023 10:18 am, Dominik Csapak wrote: > > @@ -124,6 +130,24 @@ sub updateSchema { > > > > next if defined($filter_type) && !defined($copts->{$p}); > > > > + if ($propertyList->{$p}->{type} eq 'array') { > > +

Re: [pve-devel] [RFC PATCH common] section config: implement array support

2023-05-10 Thread Fabian Grünbichler
On May 10, 2023 10:18 am, Dominik Csapak wrote: > enables section configs in the style of: > > > type: id > property value > property value2 > property value3 > > > can be combined with property strings > > the provided createSchema just uses the name of the property but th

Re: [pve-devel] [PATCH qemu-server 1/2] migration: avoid migrating disk images multiple times

2023-05-10 Thread Fiona Ebner
Am 10.05.23 um 11:57 schrieb Aaron Lauterer: > > > On 5/9/23 16:43, Fiona Ebner wrote: >> Am 09.05.23 um 14:55 schrieb Aaron Lauterer: >>> >>> * Don't scan all storages and only look at disk images that are >>> referenced in the config. With this, we should have removed most >>> situations where

Re: [pve-devel] [PATCH qemu-server 1/2] migration: avoid migrating disk images multiple times

2023-05-10 Thread Aaron Lauterer
On 5/9/23 16:43, Fiona Ebner wrote: Am 09.05.23 um 14:55 schrieb Aaron Lauterer: * Don't scan all storages and only look at disk images that are referenced in the config. With this, we should have removed most situations where aliases would happen, and a migration is less likely to fail, bec

Re: [pve-devel] [PATCH pve-container 0/1] Proposal for adding zfs dataset mounting possibility

2023-05-10 Thread Roland via pve-devel
--- Begin Message --- what about adding zfs datasets as a general type of storage? currently, you need to create a dataset manually and add that as type "dir" to proxmox, to be able to use file backed instead of zvol backed VMs that feels ugly. Am 10.05.23 um 02:08 schrieb Konstantin Filippov:

[pve-devel] [PATCH pve-container 1/1] Adding new mount point type named 'zfs' to let configure a ZFS dataset as mount point for LXC container

2023-05-10 Thread Konstantin Filippov via pve-devel
--- Begin Message --- Signed-off-by: Konstantin Filippov --- src/PVE/LXC.pm| 4 src/PVE/LXC/Config.pm | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index d138161..30cf48d 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -183

[pve-devel] [PATCH pve-container 0/1] Proposal for adding zfs dataset mounting possibility

2023-05-10 Thread Konstantin Filippov via pve-devel
--- Begin Message --- As we know, ProxMox have only three possible "categories" of mount points: ProxMox storage provider supplied, block device and bind mount. I've prepared a little patch for pve-container package which adds a fourth "category" named "zfs" - so with this patch it's possible to

[pve-devel] [RFC PATCH common] section config: implement array support

2023-05-10 Thread Dominik Csapak
enables section configs in the style of: type: id property value property value2 property value3 can be combined with property strings the provided createSchema just uses the name of the property but the schema of the inner item the api call is supposed to check if the ove