[pve-devel] [PATCH-SERIES qemu, qemu-server, manager 1/1] add patch: add memory allocator detection and use malloc_trim for glibc only

2023-03-22 Thread Alexandre Derumier
Detect if a different allocator than glibc malloc is linked with LD_PRELOAD, and call malloc_trim() only for glibc malloc This patch is mostly copy/paste from haproxy https://github.com/haproxy/haproxy/blob/master/src/pool.c Signed-off-by: Alexandre Derumier --- ...-and-call-malloc_trim-only-f

[pve-devel] [PATCH pve-manager 1/1] ui: qemu : add tuning option

2023-03-22 Thread Alexandre Derumier
with memory allocator property Signed-off-by: Alexandre Derumier --- www/manager6/Makefile | 1 + www/manager6/Utils.js | 13 + www/manager6/form/TuningSelector.js | 41 + www/manager6/qemu/Options.js| 14 ++ 4 file

[pve-devel] [PATCH-SERIES qemu, qemu-server, manager 0/1] add tcmalloc support

2023-03-22 Thread Alexandre Derumier
This patches series add support for tcmalloc allocator with a new optionnal tuning option in qemu-server. tcmalloc improve librbd performance by 30% in latency and iops. some performance bench results: malloc: 60k iops 4k randread tcmalloc : 90k iops 4k randread a qemu patch is provided, to de

[pve-devel] [PATCH qemu-server 1/1] qemu options: add tuning allocator

2023-03-22 Thread Alexandre Derumier
Add a new tuning option with allocator property. Available values: - Default is 'system', aka glibc malloc - tcmalloc (improve performance ceph librbd) Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 35 +++ 1 file changed, 35 insertions(+) diff --git

Re: [pve-devel] [PATCH v3 manager 1/3] fix #4552: certhelpers: check if custom cert and key match on change

2023-03-22 Thread Thomas Lamprecht
Am 22/03/2023 um 16:41 schrieb Max Carrara: > On 3/14/23 16:08, Max Carrara wrote: >> It is now checked whether the new custom SSL certificate actually >> matches the provided or existing custom key. >> >> Also, the new custom certificate and key pair is now validated >> *before* it is used or repl

[pve-devel] [RFC ha-manager] manager: clear stale maintenance node in edge case

2023-03-22 Thread Fiona Ebner
where the whole cluster was shut down at the same time and the service was never started on another node since the maintenance node was set. If a user ends up in this edge case, it would be rather surprising that the service would ignore the rebalance on start setting and would be automatically mi

Re: [pve-devel] [PATCH v3 manager 1/3] fix #4552: certhelpers: check if custom cert and key match on change

2023-03-22 Thread Max Carrara
On 3/14/23 16:08, Max Carrara wrote: > It is now checked whether the new custom SSL certificate actually > matches the provided or existing custom key. > > Also, the new custom certificate and key pair is now validated > *before* it is used or replaced with the existing pair. Safety copies > are s

[pve-devel] applied: [PATCH manager] ui: ceph: unmask container after we finished the ceph install

2023-03-22 Thread Thomas Lamprecht
Am 22/03/2023 um 15:28 schrieb Dominik Csapak: > otherwise the container stays masked and we cannot interact with it > > Signed-off-by: Dominik Csapak > --- > www/manager6/Utils.js | 3 +++ > 1 file changed, 3 insertions(+) > > applied, thanks! ___

[pve-devel] [PATCH manager] ui: ceph: unmask container after we finished the ceph install

2023-03-22 Thread Dominik Csapak
otherwise the container stays masked and we cannot interact with it Signed-off-by: Dominik Csapak --- www/manager6/Utils.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index b25445374..94e75d5c4 100644 --- a/www/manager6/Utils.js +++ b/www

[pve-devel] applied: [PATCH i18n] update french translation

2023-03-22 Thread Thomas Lamprecht
Am 22/03/2023 um 13:37 schrieb Alexandre Derumier: > --- > fr.po | 133 +++--- > 1 file changed, 44 insertions(+), 89 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.pro

[pve-devel] [PATCH i18n] update french translation

2023-03-22 Thread Alexandre Derumier
--- fr.po | 133 +++--- 1 file changed, 44 insertions(+), 89 deletions(-) diff --git a/fr.po b/fr.po index fe96c95..0804451 100644 --- a/fr.po +++ b/fr.po @@ -781,9 +781,8 @@ msgid "Back" msgstr "Retour" #: pve-manager/www/manager6/ceph/OSDD

Re: [pve-devel] [PATCH proxmox-i18n] update fr translation

2023-03-22 Thread DERUMIER, Alexandre
Oh sorry, I sent a wrong old patch. I'll resent the good one. ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH i18n] add/reword some italian translations

2023-03-22 Thread Thomas Lamprecht
Am 22/03/2023 um 12:54 schrieb Christian Ebner: > Signed-off-by: Christian Ebner > --- > it.po | 560 +++--- > 1 file changed, 219 insertions(+), 341 deletions(-) > > applied, thanks! ___ pve-devel

[pve-devel] [PATCH i18n] add/reword some italian translations

2023-03-22 Thread Christian Ebner
Signed-off-by: Christian Ebner --- it.po | 560 +++--- 1 file changed, 219 insertions(+), 341 deletions(-) diff --git a/it.po b/it.po index 458e968..a40f9c2 100644 --- a/it.po +++ b/it.po @@ -43,7 +43,7 @@ msgstr "5 minuti" #: proxmox-backup/w

[pve-devel] applied-series: [PATCH widget-toolkit 1/3] dark-mode: fix highlighting of active elements in drop down menus

2023-03-22 Thread Thomas Lamprecht
Am 22/03/2023 um 12:07 schrieb Stefan Sterz: > e.g.,: the filter menu item in the backup job creation window > > Signed-off-by: Stefan Sterz > --- > src/proxmox-dark/scss/extjs/_menu.scss | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > applied all four patches, thanks!

[pve-devel] [PATCH widget-toolkit] dark-mode: style locked guest icons properly

2023-03-22 Thread Stefan Sterz
Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/other/_icons.scss | 4 1 file changed, 4 insertions(+) diff --git a/src/proxmox-dark/scss/other/_icons.scss b/src/proxmox-dark/scss/other/_icons.scss index d492e2e..164cd35 100644 --- a/src/proxmox-dark/scss/other/_icons.scss +++ b/src/

[pve-devel] applied: [PATCH docs] qm: freeze-fs-on-backup: remove reference to GUI

2023-03-22 Thread Thomas Lamprecht
Am 22/03/2023 um 12:09 schrieb Friedrich Weber: > The config option is currently not exposed in the GUI. > > Signed-off-by: Friedrich Weber > --- > qm.adoc | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > applied, thanks! ___ pve-de

[pve-devel] [PATCH docs] qm: freeze-fs-on-backup: remove reference to GUI

2023-03-22 Thread Friedrich Weber
The config option is currently not exposed in the GUI. Signed-off-by: Friedrich Weber --- qm.adoc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/qm.adoc b/qm.adoc index 15ac2fc..0726b29 100644 --- a/qm.adoc +++ b/qm.adoc @@ -1089,9 +1089,8 @@ Writer VSS module in a mode

[pve-devel] [PATCH widget-toolkit 3/3] dark-mode: style checkboxes that don't use blueish active states

2023-03-22 Thread Stefan Sterz
e.g., in the backup job creation window the filter column checkmark Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/other/_icons.scss | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/proxmox-dark/scss/other/_icons.scss b/src/proxmox-dark/scss/other/_icons.scss i

[pve-devel] [PATCH widget-toolkit 1/3] dark-mode: fix highlighting of active elements in drop down menus

2023-03-22 Thread Stefan Sterz
e.g.,: the filter menu item in the backup job creation window Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/extjs/_menu.scss | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/proxmox-dark/scss/extjs/_menu.scss b/src/proxmox-dark/scss/extjs/_menu.scss index 74be90

[pve-devel] [PATCH widget-toolkit 2/3] dark-mode: set the icon color of filtered column headers properly

2023-03-22 Thread Stefan Sterz
Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/other/_icons.scss | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/proxmox-dark/scss/other/_icons.scss b/src/proxmox-dark/scss/other/_icons.scss index b4443ee..aa36b54 100644 --- a/src/proxmox-dark/scss/other/_icons.s

[pve-devel] [PATCH manager] ui: ceph: pool: add pool number as column

2023-03-22 Thread Aaron Lauterer
The pool number is shown in a few places, having it easily accessible can help to understand which pool a warning/error refers to. For example, the PG ID consists of '{pool nr}.{pg nr}' and is shown in every warning concerning that PG. Signed-off-by: Aaron Lauterer --- this is just a small qual

[pve-devel] [PATCH proxmox-i18n] update fr translation

2023-03-22 Thread Alexandre Derumier
--- fr.po | 925 +- 1 file changed, 333 insertions(+), 592 deletions(-) diff --git a/fr.po b/fr.po index 157522e..1e45503 100644 --- a/fr.po +++ b/fr.po @@ -25,13 +25,12 @@ msgstr "" "X-Poedit-SearchPath-1: ../www/manager\n" #: pve-manag

[pve-devel] applied: [PATCH proxmox-resource-scheduling] pve static: add one to avoid boosting tiny relative differences

2023-03-22 Thread Thomas Lamprecht
Am 21/03/2023 um 17:44 schrieb Fiona Ebner: > Only the relative difference for values between different alternatives > is relevant, meaning 0.002 vs 0.004 and 0.2 vs 0.4 will influence the > scoring in the same way. This is not really desirable, because values > closer to 1.0 indicate higher load a