[pve-devel] [PATCH v3 manager 2/3] ui: cert upload: use inputpanel for certificate upload

2023-03-14 Thread Max Carrara
This change replaces the the certificate upload form's items with a single inputpanel widget. The components for the key and cert fields are preserved as-is. Hardcoded values are now explicitly set in `onGetValues` instead of using hidden widgets. Signed-off-by: Max Carrara --- www/manager6/node

[pve-devel] [PATCH v3 manager 0/3] Fix SSL Certificate and Key Upload Issues

2023-03-14 Thread Max Carrara
The respective previous versions can be found here: - v1: https://lists.proxmox.com/pipermail/pve-devel/2023-February/055955.html - v2: https://lists.proxmox.com/pipermail/pve-devel/2023-March/056011.html Note: The changes to pve-common are not included in this series anymore, as they've alrea

[pve-devel] [PATCH v3 manager 1/3] fix #4552: certhelpers: check if custom cert and key match on change

2023-03-14 Thread Max Carrara
It is now checked whether the new custom SSL certificate actually matches the provided or existing custom key. Also, the new custom certificate and key pair is now validated *before* it is used or replaced with the existing pair. Safety copies are still made; if a pair is currently in use, it is t

[pve-devel] [PATCH v3 manager 3/3] ui: cert upload: fix private key field sending empty string

2023-03-14 Thread Max Carrara
The private key's field is now excluded from the upload form's JSON data if it's left empty. Prior to this change, the form still used an empty string for the private key's field, even if no key was provided by the user. Because the key's field is marked as optional in the upload cert API endpoint

[pve-devel] applied: [PATCH v3 widget-toolkit 1/2] ui: SMART: fix eslint error / show correct value

2023-03-14 Thread Thomas Lamprecht
Am 24/02/2023 um 15:40 schrieb Matthias Heiserer: > Signed-off-by: Matthias Heiserer > --- > > Changes from v2: > Calculate the field in a different way... > > Thanks to dominik for simplifying/fixing the logic! > > src/window/DiskSmart.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletio

[pve-devel] applied: [PATCH widget-toolkit v3 1/1] RealmComboBox: add custom store filters for callers

2023-03-14 Thread Thomas Lamprecht
Am 17/01/2023 um 12:46 schrieb Dominik Csapak: > so that a user can filter the underlying store, e.g. for type > > Signed-off-by: Dominik Csapak > --- > src/form/RealmComboBox.js | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > applied, thanks! __

[pve-devel] applied: [PATCH manager] pveproxy/template: switch to using the "auto" theme per default

2023-03-14 Thread Thomas Lamprecht
Am 14/03/2023 um 15:01 schrieb Stefan Sterz: > the auto theme uses media queries to detect a users preferred theme, > switch to using it per default instead of the light theme. > > Signed-off-by: Stefan Sterz > --- > PVE/Service/pveproxy.pm | 5 - > www/index.html.tpl | 8 > 2

[pve-devel] applied: [PATCH widget-toolkit 0/2] Proxmox Dark Theme Fix-ups Round 2

2023-03-14 Thread Thomas Lamprecht
Am 14/03/2023 um 15:01 schrieb Stefan Sterz: > this theme switches the default theme to the 'auto' theme for > all three producs (pve, pmg, pbs) in addition to two minor fix-ups > > * for the widget toolkit a bit of brightness is added to the check-box > icons > * in the pmg-gui the main logo in

[pve-devel] [PATCH widget-toolkit 0/2] Proxmox Dark Theme Fix-ups Round 2

2023-03-14 Thread Stefan Sterz
this theme switches the default theme to the 'auto' theme for all three producs (pve, pmg, pbs) in addition to two minor fix-ups * for the widget toolkit a bit of brightness is added to the check-box icons * in the pmg-gui the main logo in the mobile quarantine is styled properly note that th

[pve-devel] [PATCH manager] pveproxy/template: switch to using the "auto" theme per default

2023-03-14 Thread Stefan Sterz
the auto theme uses media queries to detect a users preferred theme, switch to using it per default instead of the light theme. Signed-off-by: Stefan Sterz --- PVE/Service/pveproxy.pm | 5 - www/index.html.tpl | 8 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/

[pve-devel] [PATCH widget-toolkit 1/2] utils: move to using the auto theme per default

2023-03-14 Thread Stefan Sterz
make the new default theme the "auto" theme that uses media queries to detect a users preferred theme. Signed-off-by: Stefan Sterz --- src/Utils.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Utils.js b/src/Utils.js index 2ab1d0a..c9c00a9 100644 --- a/src/Utils.js

[pve-devel] [PATCH widget-toolkit 2/2] dark-theme: increase contrast on check-boxes

2023-03-14 Thread Stefan Sterz
by adding a bit of brightness to the icons they stand out a bit more, especially when selected but not active (grey check-mark) Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/other/_icons.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/proxmox-dark/scss/other/

Re: [pve-devel] [PATCH pve-docs] update the PCI(e) docs

2023-03-14 Thread Dominik Csapak
a few comments inline On 3/14/23 13:48, Noel Ullreich wrote: A little update to the PCI(e) docs with the plan of reworking the PCI wiki as well. Some questions and reasoning to the patch: * I would only mention the ACS patch in the PCI examples wiki, since it is a last-ditch effort to get IOMMU

[pve-devel] [PATCH v2 manager] gui: expose content-dirs property in storage edit/create

2023-03-14 Thread Leo Nunner
Add a separate tab for the storage edit/create panels to set the recently introduced "content-dirs" property which overrides the default directory locations. Analogous to the API implementation, the tab was added for Directory, CIFS and NFS storages. Signed-off-by: Leo Nunner --- www/manager6/st

[pve-devel] [PATCH v2 storage manager docs] Expose content-dirs through GUI + use relative paths

2023-03-14 Thread Leo Nunner
Changes from v1: - make it clear that all paths are relative to the mountpoint by removing the requirement to have a preceeding / for paths. storage: Leo Nunner (1): config: use relative paths for content overrides PVE/Storage/Plugin.pm | 6 +++--- test/get_subdir_test.pm | 4 ++--

[pve-devel] [PATCH v2 storage] config: use relative paths for content overrides

2023-03-14 Thread Leo Nunner
Remove the requirement for paths to start with a /, as it might be confusing to users. Signed-off-by: Leo Nunner --- RFC: I'm not really sure how much input validation we want to do here. e.g., should we keep the user from appending or prepending slashes (e.g. setting the override as /dir/)? Or s

[pve-devel] [PATCH v2 docs] config: remove reference to preceeding / from content-dirs

2023-03-14 Thread Leo Nunner
Signed-off-by: Leo Nunner --- pve-storage-dir.adoc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pve-storage-dir.adoc b/pve-storage-dir.adoc index 4eb8dcd..3367394 100644 --- a/pve-storage-dir.adoc +++ b/pve-storage-dir.adoc @@ -57,8 +57,7 @@ in the following format:

Re: [pve-devel] [PATCH pve-docs] update the PCI(e) docs

2023-03-14 Thread Lukas Wagner
On 3/14/23 13:48, Noel Ullreich wrote: +Since passthrough is preformed on real hardware, the hardware needs to fulfill Small typo, I guess this should be 'performed'? -- - Lukas ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.p

[pve-devel] [PATCH pve-docs] update the PCI(e) docs

2023-03-14 Thread Noel Ullreich
A little update to the PCI(e) docs with the plan of reworking the PCI wiki as well. Some questions and reasoning to the patch: * I would only mention the ACS patch in the PCI examples wiki, since it is a last-ditch effort to get IOMMU to work and who knows how long we will support the patch. * Sho

[pve-devel] [PATCH docs v4 5/5] added noVNC clipboard documentation

2023-03-14 Thread Markus Frank
Signed-off-by: Markus Frank --- qm.adoc | 17 + 1 file changed, 17 insertions(+) diff --git a/qm.adoc b/qm.adoc index bd535a2..6b95518 100644 --- a/qm.adoc +++ b/qm.adoc @@ -717,6 +717,23 @@ Selecting `serialX` as display 'type' disables the VGA output, and redirects the Web Co

[pve-devel] [PATCH novnc v4 3/5] added show clipboard button patch to series

2023-03-14 Thread Markus Frank
Signed-off-by: Markus Frank --- .../patches/0019-show-clipboard-button.patch | 30 +++ debian/patches/series | 1 + 2 files changed, 31 insertions(+) create mode 100644 debian/patches/0019-show-clipboard-button.patch diff --git a/debian/patches/0019-sho

[pve-devel] [PATCH qemu-server v4 1/5] enable clipboard parameter in vga_fmt

2023-03-14 Thread Markus Frank
added option to use the qemu vdagent implementation to enable the noVNC clipboard. When enabled with SPICE the spice-vdagent gets replaced with the qemu implementation. This patch does not solve #1406, but does allow copy and paste with a running X-session, when spice-vdagent is installed on the g

[pve-devel] [PATCH qemu-server/manager/novnc/docs v4 0/5] Feature noVNC-Clipboard

2023-03-14 Thread Markus Frank
qemu-server: changes v4: * removed duplicate code and created a spicedevices variable to store spice/vdagent devices. * clipboard_check_compatibility function changes v3: * added hint to make clearer that the spice guest tools are required for the noVNC-clipboard * Checkbox changes to ComboBox w

[pve-devel] [PATCH qemu-server v4 2/5] test cases for clipboard spice & std

2023-03-14 Thread Markus Frank
added one test case for a spice display and one for std Signed-off-by: Markus Frank --- test/cfg2cmd/noVNC-clipboard-spice.conf | 1 + test/cfg2cmd/noVNC-clipboard-spice.conf.cmd | 27 + test/cfg2cmd/noVNC-clipboard-std.conf | 1 + test/cfg2cmd/noVNC-clipboard-std

[pve-devel] [PATCH manager v4 4/5] added clipboard checkbox to VM Options

2023-03-14 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/qemu/DisplayEdit.js | 6 ++ www/manager6/qemu/Options.js | 34 2 files changed, 40 insertions(+) diff --git a/www/manager6/qemu/DisplayEdit.js b/www/manager6/qemu/DisplayEdit.js index 9bb1763e..05f12eed 100644

[pve-devel] applied: [PATCH manager] ui: fix not opening 'bulk action' windows

2023-03-14 Thread Thomas Lamprecht
Am 14/03/2023 um 11:20 schrieb Dominik Csapak: > we previously removed the 'filters' property from the store, but this > has the effect that the filter array is only ever initialized when > we try to access them via the specified api of extjs > > so instead of adding them manually to their array,

[pve-devel] applied: [PATCH manager 0/7] backup edit window improvements

2023-03-14 Thread Thomas Lamprecht
Am 06/03/2023 um 15:23 schrieb Dominik Csapak: > two bugfixes (the VMSelector changes are necessary for those) > and a refactor of the edit window (i put that patch at the end, because even > with simplifications, it's still ~30 lines more, and i was not sure if that's > worth it) > > Dominik Csap

[pve-devel] [PATCH manager] ui: fix not opening 'bulk action' windows

2023-03-14 Thread Dominik Csapak
we previously removed the 'filters' property from the store, but this has the effect that the filter array is only ever initialized when we try to access them via the specified api of extjs so instead of adding them manually to their array, use the 'addFilter' method of extjs also use 'getStore()

Re: [pve-devel] [PATCH access-control/docs 0/2] fix #3748: Allow reserved characters in attribute values of LDAP DNs

2023-03-14 Thread Christoph Heiss
Ping. It's a rather minor change and it would be nice to get this in sometime, as this fixes an actual problem some users have :^) On Tue, Jan 31, 2023 at 01:50:41PM +0100, Christoph Heiss wrote: > This fixes #3748 [0] by allowing reserved characters in `bind_dn` (and > other properties of the sam