Re: [pve-devel] applied: [RFC pve-qemu] disable jemalloc

2023-03-10 Thread DERUMIER, Alexandre
Hi, sorry for bumping this old thread. I'm currently benching again qemu with librbd and memory allocator. It's seem that they are still performance problem with default glibc allocator, around 20-25% less iops and bigger latency. From my bench, i'm around 60k iops vs 80-90k iops with 4k randre

Re: [pve-devel] [PATCH widget-toolkit 1/1] inputpanel: improve validitychange check for advanced fields

2023-03-10 Thread Aaron Lauterer
nice. now the advanced part doesn't open on create or edit anymore :) for both patches: Tested-By: Aaron Lauterer ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH] ui: fire config change: always pass required parameters

2023-03-10 Thread Thomas Lamprecht
As otherwise the listeners might choke on the missing records. For our usage it was only a problem when one changed the tree UI options while having the Datacenter -> Summary panel open, as that listens to the UI changes to adapt the shown gauges for e.g., memory, storage, or CPUs, and thus actual

[pve-devel] [PATCH manager] ui: PBSEdit: cleanup iframe for paperkey

2023-03-10 Thread Aaron Lauterer
Otherwise the iframe used to print the paperkey will remain even after the encryption key window is closed. Additionally clean before creating a new one as otherwise we might end up with multiple iframes. Signed-off-by: Aaron Lauterer --- www/manager6/storage/PBSEdit.js | 9 - 1 file cha

[pve-devel] [PATCH manager 1/1] ui: ceph: pool: don't always show advanced fields on create

2023-03-10 Thread Dominik Csapak
since the ruleselector is not allowed to be empty, but the loading of the rules is not instant, the validity change will trigger before the load was finished. Since it is in the advanced section, it will be opened everytime instead of only when there is an invalid value. This patch fixes that by t

[pve-devel] [PATCH widget-toolkit 1/1] inputpanel: improve validitychange check for advanced fields

2023-03-10 Thread Dominik Csapak
instead of only checking the validity of the advanced items when the form validity changed as a whole, add a validitychange listener to each field in the advanced section. This improves the behaviour such that everytime an advanced field gets invalid the items are show, not only when the form was

[pve-devel] [PATCH widget-toolkit 1/6] dark-theme: fix summary row background

2023-03-10 Thread Stefan Sterz
previously an "!important" was missing from the `background-color` property. this meant that the background color wasn't properly overridden. the "!important" is necessary as it is also used in the light theme. Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/extjs/_grid.scss | 4 +++- 1 fi

[pve-devel] [PATCH widget-toolkit 0/6] Proxmox Dark Theme Fix-ups Round 1

2023-03-10 Thread Stefan Sterz
this series adds a couple of fix-ups to the recently introduced dark-theme. it first fixes summary rows again (they wore broken in a refactoring step), then darkens the background mask further, dims buttons more, removes thicker borders that are inconsistent with crisp and removes a border around t

[pve-devel] [PATCH widget-toolkit 5/6] dark-theme: visually remove the border around the pve resource tree

2023-03-10 Thread Stefan Sterz
by setting the color of the border of the resource tree to the panel background color, it doesn't appear visually anymore while keeping alignments in place. Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/extjs/_panel.scss | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/proxm

[pve-devel] [PATCH widget-toolkit 4/6] dark-theme: remove thicker borders around content

2023-03-10 Thread Stefan Sterz
previously the dark theme used thicker borders in certain places to space out the content a bit more. this removes them again to make the appearance more consistent with "crisp". Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/abstracts/_mixins.scss | 7 --- src/proxmox-dark/scss/extj

[pve-devel] [PATCH widget-toolkit 3/6] dark-theme: re-work buttons colors to appear dimmer

2023-03-10 Thread Stefan Sterz
this dims buttons further by removing pure white text color and adjusting backgrounds and border accordingly. it also keeps the help buttons brighter than other buttons to draw (possibly confused) users to them. Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/abstracts/_variables.scss | 10

[pve-devel] [PATCH widget-toolkit 2/6] dark-theme: make windows stand out more against the background mask

2023-03-10 Thread Stefan Sterz
makes the background mask darker so windows stand out a bit more Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/extjs/_presentation.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/proxmox-dark/scss/extjs/_presentation.scss b/src/proxmox-dark/scss/extjs/_prese

[pve-devel] [PATCH manager 6/6] ui: make tree settings button like regular buttons

2023-03-10 Thread Stefan Sterz
the "proxmox-inline-button" class is redundant in the crisp theme as it only sets the buttons text to black. we mainly use that class for "help" buttons. this is useful in the dark theme, because we want help buttons to stand out a bit so (possibly confused) users are drawn to them more easily. rem

[pve-devel] [PATCH manager] api: add 'hardware' endpoint to index

2023-03-10 Thread Dominik Csapak
it was missing there. Without this, it will not show up during cli autocompletion and in the html debug view (/api2/html/). Signed-off-by: Dominik Csapak --- PVE/API2/Nodes.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 47c2d7414..f1b3bca41 100

Re: [pve-devel] [PATCH docs] qm: guest trim: add note mentioning issue with ext4

2023-03-10 Thread Fiona Ebner
Am 10.03.23 um 10:43 schrieb Laurent GUERBY: > On Fri, 2023-03-10 at 10:06 +0100, Fiona Ebner wrote: >> It is rather unexpected and seems worth mentioning. Reported in the >> community forum [0] and the explanation found by Alwin [1]. >> >> [0]: https://forum.proxmox.com/threads/123819/ >> [1]: htt

Re: [pve-devel] [PATCH docs] qm: guest trim: add note mentioning issue with ext4

2023-03-10 Thread Laurent GUERBY
On Fri, 2023-03-10 at 10:06 +0100, Fiona Ebner wrote: > It is rather unexpected and seems worth mentioning. Reported in the > community forum [0] and the explanation found by Alwin [1]. > > [0]: https://forum.proxmox.com/threads/123819/ > [1]: https://serverfault.com/questions/1113127/fstrim-is-ve

[pve-devel] [PATCH docs] qm: guest trim: add note mentioning issue with ext4

2023-03-10 Thread Fiona Ebner
It is rather unexpected and seems worth mentioning. Reported in the community forum [0] and the explanation found by Alwin [1]. [0]: https://forum.proxmox.com/threads/123819/ [1]: https://serverfault.com/questions/1113127/fstrim-is-very-slow-on-xfs-and-always-return-same-value-unlike-ext4/1113129