[pve-devel] [PATCH V3 firewall 1/2] allow non zero ip address host bits to be entered

They can already be set directly via the cluster.fw file. Net::IP is just a bit more picky with what it allows: For example: error: 192.168.1.155/24 correct: 192.168.1.0/24 This cleans the entered IP and removes the non zero host bits. Signed-off-by: Stefan Hrdlicka --- src/PVE/API2/Firew

[pve-devel] [PATCH V3 firewall 0/2] allow non zero ip address host bits to be entered

V2 -> V3 * review fix: removed closure from clean_cidr V1 -> V2 * zero out host bits instead of ignoring error * regex "cleanup" Stefan Hrdlicka (2): allow non zero ip address host bits to be entered cleanup: don't capture "/xx" of CIDR src/PVE/API2/Firewall/IPSet.pm | 2 +- src/PVE/Firewa

[pve-devel] [PATCH V3 firewall 2/2] cleanup: don't capture "/xx" of CIDR

Signed-off-by: Stefan Hrdlicka --- src/PVE/Firewall.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index ae5f221..4924d51 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -68,7 +68,7 @@ PVE::JSONSchema::register_format

[pve-devel] [PATCH pve-docs v2] updated tags docs

updated the tags doc with slight rephrasing, corrected grammar, and fixed typos. Signed-off-by: Noel Ullreich --- changes since v1: * removed changes in datacenter.cfg.5-opts.adoc since it is an autogenerated file (thanks @Dominik;) ) pve-gui.adoc | 70 +--

[pve-devel] [PATCH pve-docs] updated tags docs

updated the tags doc with slight rephrasing, corrected grammar, and fixed typos. Signed-off-by: Noel Ullreich --- datacenter.cfg.5-opts.adoc | 2 +- pve-gui.adoc | 70 ++ 2 files changed, 35 insertions(+), 37 deletions(-) diff --git a/datacente

[pve-devel] applied: [PATCH manager v2 1/3] ui: realm: sync: don't use realm defaults for remove-vanished

Am 06/12/2022 um 12:06 schrieb Dominik Csapak: > if we don't manually set it to the empty string, it will use the > realm default, which might be unexpected. this way, the sync always > does what the user saw in the sync window. > > Signed-off-by: Dominik Csapak > --- > www/manager6/dc/SyncWindo

Re: [pve-devel] [PATCH access-control v2 2/2] add realmsync plugin for jobs and CRUD api for domainsync-jobs

Some mostly API and slightly higher level or cosmetical comments, but also some issue with how you use the cfs domain locks at the end. Also, a patch-wide s/realmsync/realm-sync/ would be great. Am 06/12/2022 um 12:06 schrieb Dominik Csapak: > to be able to define automated jobs that sync ldap/a

Re: [pve-devel] [PATCH V4 qemu-server 5/7] ignore PVE::Storage::path errors when deleting VMs

Some rationale in the commit message would be nice, along the lines of "we already ignore storage errors except these, let's finish the job" Am 25.11.22 um 15:40 schrieb Stefan Hrdlicka: > Signed-off-by: Stefan Hrdlicka > --- > PVE/QemuServer.pm | 10 +- > 1 file changed, 5 insertions(+)

Re: [pve-devel] [PATCH V4 qemu-server 6/7] adapt behavior for detaching drives to deatching container mount points

The info from this commit title is good to have as part of the commit message, but it would be nicer if the title would describe the change rather than just referencing another repository. Am 25.11.22 um 15:40 schrieb Stefan Hrdlicka: > if a storage is not available a volume will be added to the c

Re: [pve-devel] [PATCH V4 pve-container 3/7] add linked clone check for LXC container template deletion

Am 25.11.22 um 15:40 schrieb Stefan Hrdlicka: > prevent partial storage deletion if the template has a linked clone > container > Nit: not too important, but you could mention that we already do the same for VMs > Signed-off-by: Stefan Hrdlicka > --- > src/PVE/LXC.pm | 12 > 1 fil

Re: [pve-devel] [PATCH V4 pve-container 2/7] adapt behavior for detaching/removing a mount point

Am 25.11.22 um 15:40 schrieb Stefan Hrdlicka: > detach of a mount point with a removed underlying storage causes it to > be labeled as a an 'unused disk' > remove of a 'unused disk' with a removed underlying storage causes it to > be removed from the configuration > > Signed-off-by: Stefan Hrdlick

Re: [pve-devel] [PATCH V4 pve-container 1/7] fix #3711: optionally allow CT deletion to complete on disk volume removal errors

Am 25.11.22 um 15:40 schrieb Stefan Hrdlicka: > review fixes > - rename parameter to ignore-storage-errors > - move eval further up the call chain This should go... > > Signed-off-by: Stefan Hrdlicka > --- ...here to not clobber up the commit message > src/PVE/API2/LXC.pm | 8 > src

Re: [pve-devel] [PATCH V2 firewall 1/2] allow non zero ip address host bits to be entered

On Tue, Nov 29, 2022 at 05:01:51PM +0100, Stefan Hrdlicka wrote: > They can already be set directly via the cluster.fw file. Net::IP is just a > bit more picky with what it allows: > For example: > error: 192.168.1.155/24 > correct: 192.168.1.0/24 > > This cleans the entered IP and removes t

[pve-devel] applied: [PATCH v2 docs] storage: iscsi direct: update information about packages

Am 12/12/2022 um 11:30 schrieb Fiona Ebner: > As reported in the community forum [0], libiscsi-bin is required. The > library package on Bullseye would be libiscsi7, but there is no real > need to mention the package explicitly, because it is a dependency of > both, libiscsi-bin and pve-qemu-kvm. >

[pve-devel] applied: [PATCH storage] disk manage: pass full NVMe device path to smartctl

Am 12/12/2022 um 13:33 schrieb Fiona Ebner: > This essentially reverts commit c9bd3d2 ("fix #1123: modify NVME > device path for SMART support"). > > The man page for smartctl states >> Use the forms "/dev/nvme[0-9]" (broadcast namespace) or >> "/dev/nvme[0-9]n[1-9]" (specific namespace 1-9) for

[pve-devel] applied-series: [PATCH v3 http-server 1/3] multipart upload: fix upload of files starting with newlines

Am 12/12/2022 um 16:07 schrieb Matthias Heiserer: > Currently, if a file starts with a newline, it gets removed > and the uploda succeeds (provided no hash is given). > > Signed-off-by: Matthias Heiserer > --- > src/PVE/APIServer/AnyEvent.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-

Re: [pve-devel] [PATCH V6 pve-manager 0/2] fix #2822: add iscsi, lvm, lvmthin & zfs

Am 21/10/2022 um 11:24 schrieb Dominik Csapak: > All in all LGTM, one small UX thing that i am not sure if we can improve > without > making it way more complicated: > > We now preselect the current node and leave the restriction out. > We then restrict when the node changes, but remove the restr