Re: [pve-devel] vncpropxy question

2022-06-30 Thread Dietmar Maurer
> addendum: > > 'it doesn't do anything here' is not completely correct > for 'regular' vm displays it just does not set the ticket which > breaks the connection I think this ("break the connection") is important, because otherwise it would allow unecrypted VNC traffic over the network. I guess

[pve-devel] [PATCH v2 pve-docs 2/4] fix #3593: add affinity to docs

2022-06-30 Thread Daniel Bowder
Added affinity to the resource limiting info in qm.adoc. Added affinity to the qemu conf spec in qm.conf.5-opts.adoc. Signed-off-by: Daniel Bowder --- qm.adoc | 15 +++ qm.conf.5-opts.adoc | 4 2 files changed, 19 insertions(+) diff --git a/qm.adoc b/qm.adoc index

[pve-devel] [PATCH v2 pve-manager 4/4] fix #3593: add js input for affinity

2022-06-30 Thread Daniel Bowder
Adds a textfield for the affinity value. Delete that affinity value when the textbox is empty. Signed-off-by: Daniel Bowder --- www/manager6/qemu/ProcessorEdit.js | 23 +++ 1 file changed, 23 insertions(+) diff --git a/www/manager6/qemu/ProcessorEdit.js b/www/manager6/qemu/

[pve-devel] [PATCH SERIES v2 manager/docs/widget-toolkit/qemu-server 0/4] fix #3593

2022-06-30 Thread Daniel Bowder
Summary: Allows for virtual machines to be pinned to CPU cores via an affinity value added to the qemu configuration. I previously created a v1 of this patch, but it was my first submission and had lots of formatting issues. This patch is v2. The affinity input can be found on the CPU Edit page for

[pve-devel] [PATCH v2 qemu-server 1/4] fix #3593: add affinity to qemu

2022-06-30 Thread Daniel Bowder
Reuse the PVE::CpuSet to validate cpuset formatting. Add new qemu property called 'affinity' to store the cpuset. Push taskset command in front of kvm if 'affinity' is set. Signed-off-by: Daniel Bowder --- PVE/QemuServer.pm | 27 +++ 1 file changed, 27 insertions(+) diff

[pve-devel] [PATCH v2 proxmox-widget-toolkit 3/4] fix #3593: add CpuSet type to js

2022-06-30 Thread Daniel Bowder
Regex parses a cpuset via 2 matches. Find number(s) or range(s) folowed by a comma, then, find a single number or a single range not followed by a comma. E.g., 0-1,4-5,6,7,10,11,14-15 CpuSet function first checks regex, then ensures left num <= right num Signed-off-by: Daniel Bowder --- src/Tool

Re: [pve-devel] vncpropxy question

2022-06-30 Thread Thomas Lamprecht
On 30/06/2022 13:50, Dominik Csapak wrote: > > we could even go a step further and remove support for terminals > over vnc completely, since we have support for that in the > browser with xterm.js since quite some time and spiceterm, which can make some sense to keep to provide a single client th

Re: [pve-devel] vncpropxy question

2022-06-30 Thread Dominik Csapak
On 6/30/22 13:25, Dominik Csapak wrote: On 6/30/22 13:02, Dietmar Maurer wrote: in qemu-server, I wonder why we set $ENV{LC_PVE_TICKET} conditionally? Does not make any sense to me, because it make all other connection failing... diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 99b426e.

Re: [pve-devel] vncpropxy question

2022-06-30 Thread Dominik Csapak
On 6/30/22 13:02, Dietmar Maurer wrote: in qemu-server, I wonder why we set $ENV{LC_PVE_TICKET} conditionally? Does not make any sense to me, because it make all other connection failing... diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 99b426e..c6a3ac1 100644 --- a/PVE/API2/Qemu.pm ++

[pve-devel] applied-series: [PATCH-SERIES qemu] update to 7.0.0

2022-06-30 Thread Wolfgang Bumiller
applied & bumped, thanks On Mon, Jun 27, 2022 at 01:05:39PM +0200, Fabian Ebner wrote: > Clean rebase and didn't run into any obvious issues when testing (I > did when testing the release candidates, but those issues got > addressed before the release :)). Still, more testing is always > appreciat

[pve-devel] vncpropxy question

2022-06-30 Thread Dietmar Maurer
in qemu-server, I wonder why we set $ENV{LC_PVE_TICKET} conditionally? Does not make any sense to me, because it make all other connection failing... diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 99b426e..c6a3ac1 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -2102,7 +2102,7 @@

[pve-devel] applied: [PATCH qemu-server] Qemu-Server: fix wrong quotation

2022-06-30 Thread Wolfgang Bumiller
applied, thanks On Thu, Jun 30, 2022 at 12:12:03PM +0200, Matthias Heiserer wrote: > Before, the two strings were one single string each, rather than multiple > separated by newlines. > > In the docs, this looked very strange as there were linebreaks and the > dots were shown. Can be seen e.g. in

[pve-devel] [PATCH qemu-server] Qemu-Server: fix wrong quotation

2022-06-30 Thread Matthias Heiserer
Before, the two strings were one single string each, rather than multiple separated by newlines. In the docs, this looked very strange as there were linebreaks and the dots were shown. Can be seen e.g. in api-viewer /nodes/{node}/qemu/{vmid}/config. Signed-off-by: Matthias Heiserer --- PVE/Qem

Re: [pve-devel] [PATCH pve-common 1/1] schema: add pve-targetstorage (moved from qemu-server)

2022-06-30 Thread Thomas Lamprecht
On 30/06/2022 09:30, DERUMIER, Alexandre wrote: >> this and "qemu-server: remove json schema pve-targetstorage (moved to >> pve-common)" >> seems rather unrelated from the firewall series. >> > I haved added it, because if you remove "use Firewall.pm" from lxc, > > it's doesn't find the schema any

Re: [pve-devel] [PATCH pve-common 1/1] schema: add pve-targetstorage (moved from qemu-server)

2022-06-30 Thread DERUMIER, Alexandre
Le mercredi 29 juin 2022 à 11:34 +0200, Thomas Lamprecht a écrit : > this and "qemu-server: remove json schema pve-targetstorage (moved to > pve-common)" > seems rather unrelated from the firewall series. > I haved added it, because if you remove "use Firewall.pm" from lxc, it's doesn't find the