Re: [pve-devel] [PATCH pve-cluster] Change log statements to debug

2022-06-01 Thread Matthias Heiserer
On 28.05.2022 09:22, Thomas Lamprecht wrote: On 27/05/2022 11:37, Matthias Heiserer wrote: They have been commented with //fixme for more than 11 years and contain little information, so at least make them debug logs. not really that of a good reason? Was there some actual event from a user re

Re: [pve-devel] [PATCH manager] ceph install wizard: fix #3597: don't autofill network

2022-06-01 Thread Aaron Lauterer
Can someone take a look at this? Patch should still apply. On 5/2/22 16:05, Aaron Lauterer wrote: By not auto filling the Ceph public network we can avoid accidential clicks on 'Next' which will cause the first Mon to be created with a potentially wrong network. While that is fixable, it is tedi

[pve-devel] [PATCH manager/docs] handle missed jobs better

2022-06-01 Thread Dominik Csapak
by adding a config option 'skip-missed' for jobs that skips the jobs on pvescheduler start and when changing from disabled -> enabled i did not use the systemd name 'persistent' since the name does not really convey what it means, so i tried to come up with a better name for it (the logic is just

[pve-devel] [PATCH manager 3/3] ui: dc/Backup: add 'skip-missed' checkbox

2022-06-01 Thread Dominik Csapak
so that the users can configure how to handle missed job runs Signed-off-by: Dominik Csapak --- www/manager6/dc/Backup.js | 9 + 1 file changed, 9 insertions(+) diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js index 3494aa54..6a7dc6b1 100644 --- a/www/manager6/dc/Backu

[pve-devel] [PATCH manager 1/3] fix #4026: add 'skip-missed' option for jobs

2022-06-01 Thread Dominik Csapak
like an inverse of systemd-timers 'persistent'. so that the user can configure it to not be run after powering up when it was previously missed Signed-off-by: Dominik Csapak --- PVE/API2/Backup.pm | 19 ++- PVE/Jobs.pm | 5 + PVE/Jobs/Plugin.pm

[pve-devel] [PATCH manager 2/3] fix #4053: enable 'skip-missed' behaviour also for change from disabled->enabled

2022-06-01 Thread Dominik Csapak
so that if 'persistent' is configured to off, we don't immediately run the job Signed-off-by: Dominik Csapak --- PVE/API2/Backup.pm | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm index 7b00567a..251a892d 100644 --- a/PV

[pve-devel] [PATCH docs 1/1] vzdump: add section about 'skip-missed'

2022-06-01 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- vzdump.adoc | 6 ++ 1 file changed, 6 insertions(+) diff --git a/vzdump.adoc b/vzdump.adoc index 544ed5e..f475b50 100644 --- a/vzdump.adoc +++ b/vzdump.adoc @@ -54,6 +54,12 @@ will in turn be parsed and executed by the `pvescheduler` daemon. These jobs use

[pve-devel] [PATCH qemu-server 3/3] vmstatus: add pressure stats

2022-06-01 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 4fc183e..09f3a0c 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2971,6 +2971,8 @@ sub vmstatus { $d->{cpu} = $old->{cpu

[pve-devel] [PATCH pve-manager 4/4] pvestatd: node : broadcast ksm value

2022-06-01 Thread Alexandre Derumier
only last value is needed for balancing algorithm Signed-off-by: Alexandre Derumier --- PVE/Service/pvestatd.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm index a33b21cd..dfaef7ce 100755 --- a/PVE/Service/pvestatd.pm +++ b/PVE/Service/

[pve-devel] [PATCH pve-manager 3/4] pvestatd: qemu/lxc/node : add hostcpu/hostmem average stats

2022-06-01 Thread Alexandre Derumier
we aggregate each last X second stats to 1min average we aggragate each last 5 1min average to 5min average. vm avgstats are resetted when vm is stopped or removed. Signed-off-by: Alexandre Derumier --- PVE/Service/pvestatd.pm | 94 - 1 file changed, 93 i

[pve-devel] [PATCH pve-manager 1/3] pvestatd: qemu/lxc/host : broadcast rrd pressure metrics

2022-06-01 Thread Alexandre Derumier
only "some" values for now, not sure we need full values Signed-off-by: Alexandre Derumier --- PVE/Service/pvestatd.pm | 35 +++ 1 file changed, 35 insertions(+) diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm index b1e71ec8..832d9dc5 100755 --- a/

[pve-devel] [PATCH pve-manager 2/4] pvestatd: qemu/lxc/node : add pressure stats

2022-06-01 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Service/pvestatd.pm | 34 ++ 1 file changed, 34 insertions(+) diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm index 984877c1..dd578d6b 100755 --- a/PVE/Service/pvestatd.pm +++ b/PVE/Service/pvestatd.pm @@ -1

[pve-devel] [PATCH qemu-server 2/3] vmstatus: add hostmem value

2022-06-01 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 9441cf2..4fc183e 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2933,6 +2933,11 @@ sub vmstatus { if ($pstat->{vsize}) {

[pve-devel] [PATCH-SERIES common/qemu-server/lxc/manager] brodcast new metric stats in kvstore

2022-06-01 Thread Alexandre Derumier
Hi, I'm still working on vm balancing/scheduling, and need some new metrics. As suggested by Thomas, instead sending values to new rrd, and then reparse rrd later in balancer, we broadcast: - last minute && last 5 min average cpu/ram of qemu/lxc/node - pressure average of cpu/mem/io for qemu/lxc

[pve-devel] [PATCH pve-manager 1/4] pvestatd: add broadcast_balancer_stats

2022-06-01 Thread Alexandre Derumier
broadcast each minute as it'll be average stats Signed-off-by: Alexandre Derumier --- PVE/Service/pvestatd.pm | 24 1 file changed, 24 insertions(+) diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm index 72445ec0..984877c1 100755 --- a/PVE/Service/pvestatd

[pve-devel] [PATCH pve-cluster 1/1] add pve2-metrics rrd (single metrics)

2022-06-01 Thread Alexandre Derumier
This create 1 single rrd for each metric allowed paths: pve2-metrics/vms// pve2-metrics/nodes// pve2-metrics/storages/// Signed-off-by: Alexandre Derumier --- data/src/status.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/data/src/status.

[pve-devel] [PATCH pve-common 2/2] cgroup: get_pressure_stat: add cpu full pressure

2022-06-01 Thread Alexandre Derumier
available since kernel 5.13 https://lore.kernel.org/all/20210303034659.91735-2-zhouchengm...@bytedance.com/T/#u Signed-off-by: Alexandre Derumier --- src/PVE/CGroup.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/CGroup.pm b/src/PVE/CGroup.pm index d3873fd..bc5b8

[pve-devel] [PATCH pve-common 1/2] cgroup: get_pressure_stat: use controllers in get_path

2022-06-01 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- src/PVE/CGroup.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/CGroup.pm b/src/PVE/CGroup.pm index 44b3297..d3873fd 100644 --- a/src/PVE/CGroup.pm +++ b/src/PVE/CGroup.pm @@ -380,7 +380,8 @@ sub get_pressure_stat { },