Am 5/9/22 um 12:17 schrieb Stoiko Ivanov:
> libproxmox-rs-perl ships /usr/share/perl5/PVE/RS/CalendarEvent.pm,
> which was also present in libpve-rs-perl until version 0.5.1
>
> This can lead to a (racy) issue while upgrading - depending
> on which of libproxmox-rs-perl or libpve-rs-perl gets unpa
Thanks for the review fabian,
I'll read your comments and work on it tomorrow.
Le vendredi 06 mai 2022 à 12:20 +0200, Fabian Ebner a écrit :
> Am 27.04.22 um 16:05 schrieb Alexandre Derumier:
> > Instead using vm pending options for pending cloudinit generated
> > config,
> >
> > write current g
I applied this patch in a few virtualized Proxmox instances. Existing
VM disk and controller settings were correctly applied, adding new
disks worked as expected.
I tried to find some settings combinations in the Editor panel that
would be wrong or nonsensical. Though, I couldn't find any problems
On May 9, 2022 12:17 pm, Stoiko Ivanov wrote:
> libproxmox-rs-perl ships /usr/share/perl5/PVE/RS/CalendarEvent.pm,
> which was also present in libpve-rs-perl until version 0.5.1
>
> This can lead to a (racy) issue while upgrading - depending
> on which of libproxmox-rs-perl or libpve-rs-perl gets
On 09/05/2022 09:17, Fabian Ebner wrote:
> so users can see that it can be configured here.
>
> Signed-off-by: Fabian Ebner
> ---
>
> Causes a "configuration changed by distributor" dialogue when
> upgrading the package.
>
> configs/vzdump.conf | 1 +
> 1 file changed, 1 insertion(+)
>
> diff
instead of just checking for a newline, do a full check already.
Also do the check at the beginning of generate_notes() for consistency
and remove the check after expansion to avoid failing late for things
like '{{cl{{node}}er}}' (which can even expand to a valid variable
making the error even mor
so users can see that it can be configured here.
Signed-off-by: Fabian Ebner
---
No changes from v1.
Causes a "configuration changed by maintainer dialogue" when
upgrading pve-manager
configs/vzdump.conf | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/vzdump.conf b/configs/vzdump.
like is done for other vzdump options already.
Requested in the community forum:
https://forum.proxmox.com/threads/108970/#post-468655
Signed-off-by: Fabian Ebner
---
No changes from v1.
www/manager6/window/Backup.js | 4
1 file changed, 4 insertions(+)
diff --git a/www/manager6/window/
For VMs, $task->{hostname} might be undef and when running on a
stand-alone node, there is no cluster name.
Reported-by: Marco Gabriel
Signed-off-by: Fabian Ebner
---
Changes from v1:
* Use 'standalone node' rather than empty string if there is no
cluster.
PVE/VZDump.pm | 4 ++--
1
rather than as a tooltip.
Suggested-by: Thomas Lamprecht
Signed-off-by: Fabian Ebner
---
Re-sent v1.
www/manager6/Utils.js | 2 ++
www/manager6/dc/Backup.js | 2 +-
www/manager6/window/Backup.js | 16 ++--
3 files changed, 13 insertions(+), 7 deletions(-)
diff --git
Decided to collect the patches in a series to make it easier to keep
track. Used v2 because everything besides the first patch is.
Fabian Ebner (6):
vzdump: verify parameters: properly verify notes-template
vzdump: generate notes: initialize potentially undef values
ui: manual backup: list p
to avoid warnings like
parse error in '/etc/vzdump.conf' - 'storage': missing property -
'notes-template' requires this property
when there is no default for the required property configured.
In new(), the defaults are mixed in with the regular CLI/API
parameters, so re-check if the required prope
libproxmox-rs-perl ships /usr/share/perl5/PVE/RS/CalendarEvent.pm,
which was also present in libpve-rs-perl until version 0.5.1
This can lead to a (racy) issue while upgrading - depending
on which of libproxmox-rs-perl or libpve-rs-perl gets unpacked first
we potentially run into:
```
dpkg: error
On May 6, 2022 12:59 pm, Fabian Ebner wrote:
> For VMs, $task->{hostname} might be undef and when running on a
> stand-alone node, there is no cluster name.
>
> Reported-by: Marco Gabriel
> Signed-off-by: Fabian Ebner
> ---
> PVE/VZDump.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletion
Am 09.05.22 um 09:17 schrieb Fabian Ebner:
> so users can see that it can be configured here.
>
> Signed-off-by: Fabian Ebner
> ---
>
> Causes a "configuration changed by distributor" dialogue when
> upgrading the package.
>
> configs/vzdump.conf | 1 +
> 1 file changed, 1 insertion(+)
>
> di
depends on change in pve-common
Signed-off-by: Stefan Hrdlicka
---
PVE/CLI/pvenode.pm | 12
debian/control | 1 -
2 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/PVE/CLI/pvenode.pm b/PVE/CLI/pvenode.pm
index acef6c3b..383e1f81 100644
--- a/PVE/CLI/pvenode.pm
+++
Signed-off-by: Stefan Hrdlicka
---
README.dev | 2 +-
src/PVE/PTY.pm | 21 ++---
2 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/README.dev b/README.dev
index cb6bcf8..af17116 100644
--- a/README.dev
+++ b/README.dev
@@ -62,7 +62,7 @@ libstring-shellquote-perl
depends on change in pve-common
Signed-off-by: Stefan Hrdlicka
---
This wasn't in the ticket but I found the dependency here as well and
removed it.
PVE/CLI/qm.pm | 4 ++--
debian/control | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
index
This removes the dependency to libterm-readline-gnu-perl for pve-common,
pve-manager and qemu-server. This is achived by adding a read function
to PVE::PTY.
# pve-common
Stefan Hrdlicka (1):
remove dependency on Term::ReadLine (see #2077)
README.dev | 2 +-
src/PVE/PTY.pm | 21 +++
so users can see that it can be configured here.
Signed-off-by: Fabian Ebner
---
Causes a "configuration changed by distributor" dialogue when
upgrading the package.
configs/vzdump.conf | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/vzdump.conf b/configs/vzdump.conf
index a0075cfa
like is done for other vzdump options already.
Requested in the community forum:
https://forum.proxmox.com/threads/108970/#post-468655
Signed-off-by: Fabian Ebner
---
www/manager6/window/Backup.js | 4
1 file changed, 4 insertions(+)
diff --git a/www/manager6/window/Backup.js b/www/manage
21 matches
Mail list logo
