[pve-devel] applied: [PATCH manager] ceph: services: broadcast versions: improve requesting old version

2022-04-25 Thread Thomas Lamprecht
On 30.11.21 11:38, Fabian Ebner wrote: > to avoid a "malformed JSON string" warning when there is no old > version present (e.g. after starting a cluster). > > get_node_kv will always return something that evaluates to true, so > instead, test if the result has an entry for the current node. Also,

[pve-devel] applied: [PATCH widget-toolkit] StatusView: fix usage calculation for fields without valid values

2022-04-25 Thread Thomas Lamprecht
On 10.03.22 15:31, Dominik Csapak wrote: > Sometimes, total can be zero (e.g. for swap when it's not used), which > leads to the usage being NaN. This led to the progressbar not being > updated for InfoWidgets, leaving a spurious '0%' as text. > > Signed-off-by: Dominik Csapak > --- > src/panel/

[pve-devel] applied: [PATCH installer v3 1/2] remove /mnt/hostrun after install

2022-04-25 Thread Thomas Lamprecht
On 11.03.22 20:05, Stoiko Ivanov wrote: > else the directory lingers around on fresh systems. > follows 8d7ddbde84b3ebde29108b2080977b03853b2b69 > > Signed-off-by: Stoiko Ivanov > --- > proxinstall | 1 + > 1 file changed, 1 insertion(+) > > applied, thanks! _

[pve-devel] applied: [PATCH pve-kernel-meta] proxmox-boot: fix #3729 add --graceful to bootctl invocation

2022-04-25 Thread Thomas Lamprecht
On 25.04.22 18:33, Stoiko Ivanov wrote: > The version of systemd boot in bullseye, tries writing an efivar which > is not writeable on certain (broken) UEFIs (HP thin clients). > > The issue was not present in the version in buster (the variable > simply did not get written) and can be worked arou

[pve-devel] applied: [PATCH xtermjs] detect not running guests and add start button

2022-04-25 Thread Thomas Lamprecht
On 25.02.22 15:10, Dominik Csapak wrote: > akin to what we now have in novnc > css classes copied from novnc, so that we have the same look > > Signed-off-by: Dominik Csapak > --- > src/www/index.html.hbs.in | 6 +++ > src/www/index.html.tpl.in | 6 +++ > src/www/main.js | 89 +++

[pve-devel] [PATCH pve-kernel-meta] proxmox-boot: fix #3729 add --graceful to bootctl invocation

2022-04-25 Thread Stoiko Ivanov
The version of systemd boot in bullseye, tries writing an efivar which is not writeable on certain (broken) UEFIs (HP thin clients). The issue was not present in the version in buster (the variable simply did not get written) and can be worked around by adding --graceful to the `bootctl install` c

[pve-devel] applied: [PATCH manager] ui: fix adding hostpci > 5

2022-04-25 Thread Thomas Lamprecht
On 11.03.22 08:45, Dominik Csapak wrote: > by using the limits from PVE.Utils > > Signed-off-by: Dominik Csapak > --- > www/manager6/qemu/PCIEdit.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing

[pve-devel] applied: [PATCH v2 qemu-server 4/7] restore: also deactivate/destroy cloud-init disk upon error

2022-04-25 Thread Thomas Lamprecht
On 21.04.22 13:26, Fabian Ebner wrote: > by re-using the same hash that's used when allocating/activating the > disks in the helpers doing the opposite. > > Also in preparation to allow skipping certain disks upon restore. > > Signed-off-by: Fabian Ebner > --- > > No changes from v1. > > PVE/

[pve-devel] applied: [PATCH v2 qemu-server 3/7] restore deactivate volumes: never die

2022-04-25 Thread Thomas Lamprecht
On 21.04.22 13:26, Fabian Ebner wrote: > Such an error shouldn't abort the whole operation. > > Signed-off-by: Fabian Ebner > --- > > No changes from v1. > > PVE/QemuServer.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > applied, thanks! ___

[pve-devel] applied: [PATCH v2 qemu-server 2/7] restore destroy volumes: remove check for absolute path

2022-04-25 Thread Thomas Lamprecht
On 21.04.22 13:26, Fabian Ebner wrote: > Only a result from vdisk_alloc is assigned as a volid and that's never > an absolute path. > > Signed-off-by: Fabian Ebner > --- > > No changes from v1. > > PVE/QemuServer.pm | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > applied, th

[pve-devel] applied: [PATCH v2 qemu-server 1/7] restore: cleanup oldconf: also clean up snapshots from kept volumes

2022-04-25 Thread Thomas Lamprecht
On 21.04.22 13:26, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > > No changes from v1. > > PVE/QemuServer.pm | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-dev

[pve-devel] applied: [PATCH common] SysFSTools: factor out the domain fixup and domain regex

2022-04-25 Thread Thomas Lamprecht
On 17.03.22 09:12, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > src/PVE/SysFSTools.pm | 26 -- > 1 file changed, 16 insertions(+), 10 deletions(-) > > applied, thanks! renamed it to normalize_pci_id and made a "normal" private sub in a followup. _

[pve-devel] applied: [PATCH qemu-server] QemuServer: Fix 'keyboard' parameter description

2022-04-25 Thread Thomas Lamprecht
On 25.04.22 17:21, Dylan Whyte wrote: > The option has not defaulted to using the cluster-wide datacenter.cfg > since 2018. > > Signed-off-by: Dylan Whyte > --- > PVE/QemuServer.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > applied, thanks! __

[pve-devel] applied: [PATCH v2 qemu 2/2] vma: allow partial restore

2022-04-25 Thread Thomas Lamprecht
On 21.04.22 13:26, Fabian Ebner wrote: > Introduce a new map line for skipping a certain drive, of the form > skip=drive-scsi0 > > Since in PVE, most archives are compressed and piped to vma for > restore, it's not easily possible to skip reads. > > For the reader, a new skip flag for VmaRestoreS

[pve-devel] applied: [PATCH v2 qemu 1/2] vma: restore: call blk_unref for all opened block devices

2022-04-25 Thread Thomas Lamprecht
On 21.04.22 13:26, Fabian Ebner wrote: > rather than just the last one. This is the only caller registering > block devices with the reader, so other callers are already fine. > > Signed-off-by: Fabian Ebner > --- > > New in v2. > > Best squashed into 0026-PVE-Backup-add-vma-backup-format-code.

[pve-devel] [PATCH qemu-server] QemuServer: Fix 'keyboard' parameter description

2022-04-25 Thread Dylan Whyte
The option has not defaulted to using the cluster-wide datacenter.cfg since 2018. Signed-off-by: Dylan Whyte --- PVE/QemuServer.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 1d176165..a1c2cbb5 100644 --- a/PVE/QemuServer.pm

Re: [pve-devel] [PATCH common] SysFSTools: factor out the domain fixup and domain regex

2022-04-25 Thread Dominik Csapak
ping ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH xtermjs] detect not running guests and add start button

2022-04-25 Thread Dominik Csapak
ping ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager] ui: fix adding hostpci > 5

2022-04-25 Thread Dominik Csapak
ping ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH storage] Plugins: en/decode notes as UTF-8

2022-04-25 Thread Dominik Csapak
ping (i can send a v2 with the typos fixed ofc, if wanted please say so) ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH novnc] don't require confirmation for starting a stopped vm from button

2022-04-25 Thread Dominik Csapak
ping ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH qemu-server 1/2] migrate: add log for guest fstrim

2022-04-25 Thread Fabian Ebner
and make a failure noticable. Suggested-by: Fabian Grünbichler Signed-off-by: Fabian Ebner --- PVE/QemuMigrate.pm | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 891edfb2..c293e294 100644 --- a/PVE/QemuMigr

[pve-devel] [PATCH qemu-server 2/2] migrate: resume initially running VM when failing after convergence

2022-04-25 Thread Fabian Ebner
When phase2() is aborted after the migration already converged, then after migrate_cancel, the VM might be in POSTMIGRATE state. (There also is a conditional for SHUTDOWN state in QEMU's migration_iteration_finish(), so it's likely possible to end up there if the VM is shut down at the right time

Re: [pve-devel] [PATCH qemu-server] migrate: keep VM paused after migration if it was before

2022-04-25 Thread Fabian Ebner
Am 21.04.22 um 11:15 schrieb Fabian Grünbichler: > > this confused me, so I tried to look at different code paths - a > transition from phase2 (after migration has started, any error before > that is irrelevant since it couldn't have triggered a pause) to > phase2_cleanup with $err / $self->{er

[pve-devel] applied: [pbs-devel] [PATCH proxmox-backup v5 1/5] fix #3067: docs: add markdown primer from pve to pbs

2022-04-25 Thread Thomas Lamprecht
On 12.04.22 12:34, Stefan Sterz wrote: > this copies the markdown primer from the pve docs to allow access to > it via the help buttons in the gui > > Signed-off-by: Stefan Sterz > --- > docs/index.rst | 1 + > docs/markdown-primer.rst | 178 +++ >

Re: [pve-devel] [PATCH v2 manager 1/3] ui: restore: disallow empty storage selection if it wouldn't work

2022-04-25 Thread Fabian Ebner
Am 23.04.22 um 11:38 schrieb Thomas Lamprecht: > On 21.04.22 13:26, Fabian Ebner wrote: >> Namely, if there is a storage in the backup configuration that's not >> available on the current node. > > Better than the status quo, but in the long run all the "force all volumes to > a single storage" >