Re: [pve-devel] [PATCH v2 storage] rbd: alloc image: fix #3970 avoid ambiguous rbd path

2022-04-11 Thread Aaron Lauterer
On 4/11/22 14:17, Thomas Lamprecht wrote: [...] Some more (smaller) changes might be necessary, if the implementation we manage to upstream will be a bit different. But that should not be much of an issue AFAICT. We can always ship our downstream solution to be whatever we want and sync up o

Re: [pve-devel] [PATCH container 1/1] Setup: Allow hostname configuration on NixOS

2022-04-11 Thread Harikrishnan R via pve-devel
--- Begin Message --- Can someone please take a look at this patch? It's a minor change that will allow proxmox to set hostname on NixOS LXCs. On Fri, 18 Mar 2022 at 15:51, Harikrishnan R wrote: > While NixOS generally overrides any static contents in /etc/hostname > with the hostname defined in

Re: [pve-devel] [PATCH v2 storage] rbd: alloc image: fix #3970 avoid ambiguous rbd path

2022-04-11 Thread Thomas Lamprecht
On 11.04.22 11:08, Aaron Lauterer wrote: > On 4/11/22 09:39, Thomas Lamprecht wrote: >> The obvious question to me is: why bother with this workaround when we can >> make udev create the symlink now already? >> >> Patching the rules file and/or binary shipped by ceph-common, or shipping our >> own

[pve-devel] [RFC container] api: create: disallow passing along existing disk for restore

2022-04-11 Thread Fabian Ebner
For VMs, the plan is to allow passing along disk options (with the currently configured disks) for a restore operation to cause those disks to be kept instead of removing and restoring them from backup. Users might expect the same behavior for containers once that feature exists, but implementing i

[pve-devel] applied-series: [PATCH v6 manager 0/5] ui: lxc/qemu: disk/volume action simplify menu items

2022-04-11 Thread Thomas Lamprecht
On 05.04.22 14:30, Aaron Lauterer wrote: > Aaron Lauterer (5): > ui: utils: refactor mps to mp > ui: utils: add nextFreeMP > ui: lxc/qemu: add disk reassign and action submenu > ui: BusTypeSelector: change noVirtIO to withVirtIO > ui: hdmove: modernize/refactor > > www/manager6/Makefile

Re: [pve-devel] New API endpoint to manage snippets / bugzilla 2208 / updated patch but missing something, need help

2022-04-11 Thread Laurent GUERBY
On Mon, 2022-04-11 at 11:03 +0200, Matthias Heiserer wrote: > Hi, > > please take a look at our developer documentation. > https://pve.proxmox.com/wiki/Developer_Documentation > > Using `git format-patch` makes applying the changes a whole lot > easier :) > > As far as I can tell from a quick te

Re: [pve-devel] [PATCH v2 storage] rbd: alloc image: fix #3970 avoid ambiguous rbd path

2022-04-11 Thread Aaron Lauterer
On 4/11/22 09:39, Thomas Lamprecht wrote: On 08.04.22 10:04, Fabian Grünbichler wrote: On April 6, 2022 1:46 pm, Aaron Lauterer wrote: If two RBD storages use the same pool, but connect to different clusters, we cannot say to which cluster the mapped RBD image belongs to if krbd is used. To a

Re: [pve-devel] New API endpoint to manage snippets / bugzilla 2208 / updated patch but missing something, need help

2022-04-11 Thread Matthias Heiserer
Hi, please take a look at our developer documentation. https://pve.proxmox.com/wiki/Developer_Documentation Using `git format-patch` makes applying the changes a whole lot easier :) As far as I can tell from a quick test, your changes seem to work. Would you mind using `pvesh create` to test?

Re: [pve-devel] [PATCH v2 storage] rbd: alloc image: fix #3970 avoid ambiguous rbd path

2022-04-11 Thread Thomas Lamprecht
On 08.04.22 10:04, Fabian Grünbichler wrote: > On April 6, 2022 1:46 pm, Aaron Lauterer wrote: >> If two RBD storages use the same pool, but connect to different >> clusters, we cannot say to which cluster the mapped RBD image belongs to >> if krbd is used. To avoid potential data loss, we need to

[pve-devel] [PATCH pve-access-control] api2: ticket: don't require TFA if the only one is disabled

2022-04-11 Thread Hannes Laimer
If TFA was added and disabled afterwards it was not possible to login again. Signed-off-by: Hannes Laimer --- This was reported on the forum. src/PVE/API2/AccessControl.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/API2/AccessControl.pm b/src/PVE/API2/Access