[pve-devel] applied: [PATCH v3 common] REST environment: 'root@pam' fallback in task logs if no user specified for forked worker

2022-03-15 Thread Thomas Lamprecht
On 15.03.22 12:52, Oguz Bektas wrote: > call sites without a defined user parameter (found only push_file and > pull_file from pve-container) were logging the user as 'root@pve' which > doesn't exist. > > for clarity, also add a comment that this is only used for the task > logs. > > Signed-off-b

Re: [pve-devel] [PATCH v12 qemu-server 11/16] api: add endpoint for parsing .ovf files

2022-03-15 Thread Fabian Ebner
Am 14.03.22 um 16:55 schrieb Fabian Grünbichler: > On March 9, 2022 11:09 am, Fabian Ebner wrote: >> +__PACKAGE__->register_method ({ >> +name => 'index', >> +path => '', >> +method => 'GET', >> +proxyto => 'node', >> +description => "Read an .ovf manifest.", > > protected => 1

[pve-devel] applied-series: [PATCH-SERIES v4 container/qemu-server] fix #3424: wait for active replication when deleting a snapshot

2022-03-15 Thread Fabian Grünbichler
with some small follow-ups as discussed off-list: - improve error messages in case of failure to acquire lock - downgrade die to warn in pve-container vzdump patch, since it's not fatal On February 23, 2022 1:03 pm, Fabian Ebner wrote: > Avoid that an attempt to remove a snapshot that's activel

[pve-devel] [PATCH v3 common] REST environment: 'root@pam' fallback in task logs if no user specified for forked worker

2022-03-15 Thread Oguz Bektas
call sites without a defined user parameter (found only push_file and pull_file from pve-container) were logging the user as 'root@pve' which doesn't exist. for clarity, also add a comment that this is only used for the task logs. Signed-off-by: Oguz Bektas --- v2->v3: * drop warning message * p

Re: [pve-devel] [PATCH v2 common] REST environment: default to root@pam in forked workers if no user was specified

2022-03-15 Thread Thomas Lamprecht
On 15.03.22 12:21, Oguz Bektas wrote: > On Tue, Mar 15, 2022 at 09:57:34AM +0100, Thomas Lamprecht wrote: >> On 15.03.22 08:31, Fabian Ebner wrote: >>> Am 14.03.22 um 14:50 schrieb Oguz Bektas: first call $rpcenv->get_user() if user was 'undef'. if that doesn't return then we set it to ro

Re: [pve-devel] [PATCH v2 common] REST environment: default to root@pam in forked workers if no user was specified

2022-03-15 Thread Oguz Bektas
hi, On Tue, Mar 15, 2022 at 09:57:34AM +0100, Thomas Lamprecht wrote: > On 15.03.22 08:31, Fabian Ebner wrote: > > Am 14.03.22 um 14:50 schrieb Oguz Bektas: > >> first call $rpcenv->get_user() if user was 'undef'. if that doesn't > >> return then we set it to root@pam. > > this is just the "whats

[pve-devel] [PATCH pve-manager v4 1/3] fix #3903: jobs: add remove vmid from jobs helper

2022-03-15 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- v3->v4: - fix signature in base plugin - die in base plugin PVE/Jobs.pm| 21 - PVE/Jobs/Plugin.pm | 6 ++ PVE/Jobs/VZDump.pm | 13 + 3 files changed, 39 insertions(+), 1 deletion(-) diff --git a/PVE/Jobs.pm b/PVE/Jo

Re: [pve-devel] [PATCH widget-toolkit 2/2] ComboGrid: fix sorting when filtering

2022-03-15 Thread Dominik Csapak
On 3/9/22 15:18, Matthias Heiserer wrote: When clicking on a column to sort it, the filter doesn't reset. Previously, it forgot the filter until the value was changed. Signed-off-by: Matthias Heiserer --- src/form/ComboGrid.js | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/fo

[pve-devel] applied: [PATCH widget-toolkit 1/2] Combogrid: clear filter on blur

2022-03-15 Thread Dominik Csapak
applied this one ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v2 common] REST environment: default to root@pam in forked workers if no user was specified

2022-03-15 Thread Thomas Lamprecht
On 15.03.22 08:31, Fabian Ebner wrote: > Am 14.03.22 um 14:50 schrieb Oguz Bektas: >> first call $rpcenv->get_user() if user was 'undef'. if that doesn't >> return then we set it to root@pam. this is just the "whats done" description, that's not really interesting for such a short patch, as it can

Re: [pve-devel] [PATCH v2 common] REST environment: default to root@pam in forked workers if no user was specified

2022-03-15 Thread Fabian Ebner
Am 14.03.22 um 14:50 schrieb Oguz Bektas: > first call $rpcenv->get_user() if user was 'undef'. if that doesn't > return then we set it to root@pam. > > Signed-off-by: Oguz Bektas > --- > v1->v2: > * do get_user() first, set to 'root@pam' as fallback > * drop first patch for pve-container (not ne