[pve-devel] [PATCH pve-kernel-meta v2 2/8] proxmox-boot: add reinit subcommand

2022-03-03 Thread Stoiko Ivanov
to iterate over all configured ESPs and refresh the boot-loader installations. the init function was changed to not run refresh directly - to prevent refresh from running once for each ESP currently reinit does not imply refresh Signed-off-by: Stoiko Ivanov --- unchanged bin/grub-install-wrap

[pve-devel] [PATCH pve-kernel-meta v2 6/8] proxmox-boot: init bootloaders based on esp contents

2022-03-03 Thread Stoiko Ivanov
in addition to installing the boot loader for the current bootmode (grub for legacy, systemd-boot for uefi) also install the bootloader if its config is already present on the ESP. Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool | 26 -- 1 file changed, 24 insertio

[pve-devel] [PATCH pve-kernel-meta v2 8/8] proxmox-boot: fix #3729 add --graceful to bootctl invocation

2022-03-03 Thread Stoiko Ivanov
The version of systemd boot in bullseye, tries writing an efivar which is not writeable on certain (broken) UEFIs (HP thin clients). The issue was not present in the version in buster (the variable simply did not get written) and can be worked around by adding --graceful to the `bootctl install` c

[pve-devel] [PATCH installer v2 1/2] remove /mnt/hostrun after install

2022-03-03 Thread Stoiko Ivanov
else the directory lingers around on fresh systems. follows 8d7ddbde84b3ebde29108b2080977b03853b2b69 Signed-off-by: Stoiko Ivanov --- unchanged proxinstall | 1 + 1 file changed, 1 insertion(+) diff --git a/proxinstall b/proxinstall index a39d405..bddcc5d 100755 --- a/proxinstall +++ b/proxins

[pve-devel] [PATCH pve-kernel-meta v2 5/8] proxmox-boot: remove now obsolete EFI/proxmoxdir if it exists

2022-03-03 Thread Stoiko Ivanov
this can be dropped in the next major version - so keeping it as separate commit. Signed-off-by: Stoiko Ivanov --- new in v2 proxmox-boot/zz-proxmox-boot | 6 ++ 1 file changed, 6 insertions(+) diff --git a/proxmox-boot/zz-proxmox-boot b/proxmox-boot/zz-proxmox-boot index fa0ea4a..39e3bea

[pve-devel] [PATCH pve-kernel-meta v2 1/8] rename pve-efiboot-manual-kernels to proxmox-boot-manual-kernels

2022-03-03 Thread Stoiko Ivanov
was forgotten during the general renaming of pve-efiboot -> proxmox-boot. follows commit 8c0a22adfe15dc00cf2194647bb254201d8d187b Signed-off-by: Stoiko Ivanov --- rebased on current master debian/pve-kernel-helper.postinst | 4 proxmox-boot/functions| 2 +- 2 files changed, 5

[pve-devel] [PATCH pve-kernel-meta v2 4/8] proxmox-boot: refresh based on bootloader config instead of bootmode

2022-03-03 Thread Stoiko Ivanov
ignore the current bootmode (uefi/legacy) when deciding which configs to generate - make this decision based on the found boot loader configs on the ESP. Change systemd-boot to load the kernel+initrd from the ESPs root where grub needs them. This prevents the double use of space for systems having

[pve-devel] [PATCH installer v2 2/2] use proxmox-boot-tool for all uefi installs

2022-03-03 Thread Stoiko Ivanov
grub by itself is only used for btrfs/ext4/xfs installs on legacy systems for zfs proxmox-boot-tool is used in legacy and uefi mode Signed-off-by: Stoiko Ivanov --- unchanged proxinstall | 80 ++--- 1 file changed, 14 insertions(+), 66 deletions(-

[pve-devel] [PATCH pve-kernel-meta/pve-installer v2] improve boot-mode switching

2022-03-03 Thread Stoiko Ivanov
these patches are still based on v3 of the pin/unpin addtion [1]. Not sending the pin/unpin again, since the feedback was mostly positive and I think Thomas had already some improvements on top of it prepared locally. changes v1->v2: * added a fix for #3729 to pve-kernel-meta - not directly relate

[pve-devel] [PATCH pve-kernel-meta v2 7/8] proxmox-boot: allow to manually specify bootloader

2022-03-03 Thread Stoiko Ivanov
this commit adds the optional [--legacy|--uefi] arguments to `p-b-t init` and `p-b-t reinit`. If provided the respective boot-loader is installed (regardless of what is found on the esp, and of the boot-mode) This should make switching the boot-mode possible without the need to boot into a live CD

[pve-devel] [PATCH pve-kernel-meta v2 3/8] proxmox-boot: add helpers to check for bootloader configs

2022-03-03 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- new in v2 - should reduce code copying in the future bin/proxmox-boot-tool| 4 ++-- proxmox-boot/functions | 16 proxmox-boot/zz-proxmox-boot | 4 ++-- 3 files changed, 20 insertions(+), 4 deletions(-) diff --git a/bin/proxmox-bo

[pve-devel] [PATCH pve-manager v2 1/3][FIXUP] fix #3903: jobs: add remove vmid from jobs helper

2022-03-03 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- FIXUP: sort was not needed and should not have been there PVE/Jobs.pm | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/PVE/Jobs.pm b/PVE/Jobs.pm index ba3685ec..ea41523b 100644 --- a/PVE/Jobs.pm +++ b/PVE/Jobs.pm @@ -4,7 +4,7

[pve-devel] [PATCH pve-container v2 2/3] fix #3903: api2: remove vmid from jobs.cfg

2022-03-03 Thread Hannes Laimer
... on destroy if 'purge' is selected Signed-off-by: Hannes Laimer --- src/PVE/API2/LXC.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 84712f7..095f421 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -16,6 +16,7 @@ use PVE::

[pve-devel] [PATCH qemu-server v2 3/3] fix #3903: api2: remove vmid from jobs.cfg

2022-03-03 Thread Hannes Laimer
... on destroy if 'purge' is selected Signed-off-by: Hannes Laimer --- PVE/API2/Qemu.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 9be1caf..465abc2 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -31,6 +31,7 @@ use PVE::AccessControl;

[pve-devel] [PATCH-SERIES v2] fix #3903: remove vmid from jobs.cfg on destroy

2022-03-03 Thread Hannes Laimer
... if 'purge'. v2, based on Fabian Ebner 's feedback: - rewrote remove_vmid_from_jobs sub - add missing 'use' statements pve-manager: Hannes Laimer (1): fix #3903: jobs: add remove vmid from jobs helper PVE/Jobs.pm | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-)

[pve-devel] [PATCH pve-manager v2 1/3] fix #3903: jobs: add remove vmid from jobs helper

2022-03-03 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- PVE/Jobs.pm | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/PVE/Jobs.pm b/PVE/Jobs.pm index ba3685ec..a2a84095 100644 --- a/PVE/Jobs.pm +++ b/PVE/Jobs.pm @@ -4,7 +4,7 @@ use strict; use warnings; use JSON; -use PVE::Clust

[pve-devel] [PATCH widget-toolkit] fix #3919: show first task output line correctly

2022-03-03 Thread Dominik Csapak
if a task did not produce output yet, we always get a single line with "no output". our heuristic in the gui counts the total lines + the current position. so to update the first output correctly, we have to update every time in case we only have one line. Otherwise, we only update on the second

[pve-devel] review request for docs patch

2022-03-03 Thread Sylvain Faivre via pve-devel
--- Begin Message --- Hello, I sent a small docs patch to this list on 28/sept/2021. The emails are archived here : https://lists.proxmox.com/pipermail/pve-devel/2021-September/050162.html https://lists.proxmox.com/pipermail/pve-devel/2021-September/050163.html Could anyone please take a look at

[pve-devel] applied series: [PATCH-SERIES container/storage] migration fixes for containers

2022-03-03 Thread Wolfgang Bumiller
applied, thanks On Thu, Mar 03, 2022 at 01:31:18PM +0100, Fabian Ebner wrote: > The recent changes to support setting target storage and allow > renaming led to two problems with unused and unreferenced disks, as > well as exposing a bug in ZFSPoolPlugin.pm's volume_import. > > > container: > >

[pve-devel] [PATCH container 1/2] migrate: also set targetsid for unreferenced disks

2022-03-03 Thread Fabian Ebner
It's expected to be set further below. Reported in the community forum: https://forum.proxmox.com/threads/105685 Fixes: e90ddc4 ("fix #1532: add target-storage support to migration") Signed-off-by: Fabian Ebner --- src/PVE/LXC/Migrate.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PV

[pve-devel] [PATCH-SERIES container/storage] migration fixes for containers

2022-03-03 Thread Fabian Ebner
The recent changes to support setting target storage and allow renaming led to two problems with unused and unreferenced disks, as well as exposing a bug in ZFSPoolPlugin.pm's volume_import. container: Fabian Ebner (2): migrate: also set targetsid for unreferenced disks config: print volume:

[pve-devel] [PATCH container 2/2] config: print volume: support printing unused volume

2022-03-03 Thread Fabian Ebner
In particular, fixes migration with an unused disk, where calling update_volume_ids() failed previously. Signed-off-by: Fabian Ebner --- src/PVE/LXC/Config.pm | 9 + 1 file changed, 9 insertions(+) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index 0ed7bd2..d5b49d3 100644

[pve-devel] [PATCH storage 1/1] zfs: volume import: use correct format for renaming

2022-03-03 Thread Fabian Ebner
Previously, the transport format (which currently is always 'zfs') was passed in, resulting in subvol-disks not to be renamed correctly. Fixes: a97d3ee ("Introduce allow_rename parameter for pvesm import and storage_migrate") Signed-off-by: Fabian Ebner --- PVE/Storage/ZFSPoolPlugin.pm | 6

[pve-devel] applied: [PATCH/RFC qemu] backup: add patch to initialize bcs bitmap early enough for PBS

2022-03-03 Thread Wolfgang Bumiller
applied, thanks On Wed, Mar 02, 2022 at 10:05:16AM +0100, Fabian Ebner wrote: > This is necessary for multi-disk backups where not all jobs are > immediately started after they are created. QEMU commit > 06e0a9c16405c0a4c1eca33cf286cc04c42066a2 did already part of the work, > ensuring that new wri

[pve-devel] applied: Re: [PATCH manager] ui: osd: send in/out cmd to currently used node

2022-03-03 Thread Thomas Lamprecht
On 02/03/2022 11:12, Aaron Lauterer wrote: > The in & out commands for OSDs are not node specific and can be run on > any node in the Ceph cluster. By sending them to the node currently used > to access the UI they can still be sent even if the node on which the > OSDs are located is down. > > Thi

[pve-devel] applied: Re: [PATCH qemu-server] qmp client: increase timeout for thaw

2022-03-03 Thread Thomas Lamprecht
On 02/03/2022 14:21, Fabian Ebner wrote: > Using a loop of freeze, sleep 5, thaw, sleep 5, an idling Windows 11 > VM with 4 cores and 8GiB RAM once took 54 seconds for thawing. It took > less than a second about 90% of the time and maximum of a few seconds > for the majortiy of other cases, but the

Re: [pve-devel] [PATCH pve-container 2/3] fix #3903: api2: remove vmid from jobs.cfg

2022-03-03 Thread Fabian Ebner
Am 02.03.22 um 15:28 schrieb Hannes Laimer: > Am 02.03.22 um 11:16 schrieb Fabian Ebner: >> Am 01.03.22 um 09:51 schrieb Hannes Laimer: >>> ... on destroy if 'purge' is selected >>> >>> Signed-off-by: Hannes Laimer >>> --- >>>   src/PVE/API2/LXC.pm | 1 + >>>   1 file changed, 1 insertion(+) >>> >>