Re: [pve-devel] [PATCH qemu-server v2 4/4] parse vm config: remove "\s*" from multi-line comment regex

2022-02-24 Thread Dietmar Maurer
> On 02/24/2022 3:49 PM Stefan Sterz wrote: > > > To be consistent with PBS's implementation of multi-line comments > remove "\s*" here too. Since the regex isn't lazy .* matches > everything \s* would anyway. But the old regex trimm spaces from the end, so this is quite different! ___

[pve-devel] [PATCH qemu-server v2 4/4] parse vm config: remove "\s*" from multi-line comment regex

2022-02-24 Thread Stefan Sterz
To be consistent with PBS's implementation of multi-line comments remove "\s*" here too. Since the regex isn't lazy .* matches everything \s* would anyway. (Note that new lines occurs after "$"). Signed-off-by: Stefan Sterz --- There was a typo in the previous version of this patch, thanks to @

[pve-devel] [PATCH qemu-server 4/4] parse vm config: remove "\s*" from multi-line comment regex

2022-02-24 Thread Stefan Sterz
To be consistent with PBS's implementation of multi-line comments remove "\s*" here too. Since the regex isn't lazy .* matches everything \s* would anyway. (Note that new lines occurs after "$"). Signed-off-by: Stefan Sterz --- PVE/QemuServer.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 delet

[pve-devel] [PATCH cluster 1/4] parse datacenter config: remove "\s*" from comment regex

2022-02-24 Thread Stefan Sterz
To be consistent with PBS's implementation of multi-line comments remove "\s*" here too. Since the regex isn't lazy .* matches everything \s* would anyway. (Note that new lines occurs after "$"). Signed-off-by: Stefan Sterz --- data/PVE/DataCenterConfig.pm | 2 +- 1 file changed, 1 insertion(+),

[pve-devel] [PATCH manager 2/4] parse node config: remove "\s*" from comment regex

2022-02-24 Thread Stefan Sterz
To be consistent with PBS's implementation of multi-line comments remove "\s*" here too. Since the regex isn't lazy .* matches everything \s* would anyway. (Note that new lines occurs after "$"). Signed-off-by: Stefan Sterz --- PVE/NodeConfig.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[pve-devel] [PATCH container 3/4] parse pct config: remove "\s*" from multi-line comment regex

2022-02-24 Thread Stefan Sterz
To be consistent with PBS's implementation of multi-line comments remove "\s*" here too. Since the regex isn't lazy .* matches everything \s* would anyway. (Note that new lines occurs after "$"). Signed-off-by: Stefan Sterz --- src/PVE/LXC/Config.pm | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [pve-devel] [PATCH manager 5/6] ui: osd: warn if removal could be problematic

2022-02-24 Thread Thomas Lamprecht
On 18.02.22 12:38, Aaron Lauterer wrote: > If an OSD is removed during the wrong conditions, it could lead to > blocked IO or worst case data loss. > > Check against global flags that limit the capabilities of Ceph to heal > itself (norebalance, norecover, noout) and if there are degraded > object

[pve-devel] applied: [PATCH pve-network] controllers: evpn : use frr restart if reload fail

2022-02-24 Thread Thomas Lamprecht
On 23.02.22 08:11, Alexandre Derumier wrote: > frr reload is not 100% perfect, and sometime is not able to > apply correctly changes. > > Use restart in this case to be sure to have the correct config. > > Signed-off-by: Alexandre Derumier > --- > PVE/Network/SDN/Controllers/EvpnPlugin.pm | 8 +

[pve-devel] applied: [PATCH novnc] parse error 'already started' on guest start

2022-02-24 Thread Thomas Lamprecht
On 22.02.22 16:33, Dominik Csapak wrote: > when we start an already started container, we get an error instead > of a task that fails > > so to have similar behaviour between vm and ct, we parse that error > for the start command and behave like it was successful > > put it in the first patch and

[pve-devel] applied: [PATCH qemu-server] fix #3733: add 20 seconds timeout when VM backup stopped

2022-02-24 Thread Thomas Lamprecht
On 23.02.22 10:03, Moayad Almalat wrote: > --- > PVE/QemuServer.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! albeit I'd like to state that I don't like it and that this shouldn't be required at all, but oh well its simple enough and in the "cannot really hurt"

[pve-devel] applied: [PATCH qemu-server v4] fix 3886: QEMU restore: verify storage allows images before writing

2022-02-24 Thread Thomas Lamprecht
On 24.02.22 11:45, Matthias Heiserer wrote: > When restoring a backup and the storage the disks would be created on > doesn't allow 'images', the process errors without cleanup. > This is the same behaviour we currently have when the storage is > disabled. > > Adds the Datastore.AllocateSpace chec

[pve-devel] [PATCH qemu-server v4] fix 3886: QEMU restore: verify storage allows images before writing

2022-02-24 Thread Matthias Heiserer
When restoring a backup and the storage the disks would be created on doesn't allow 'images', the process errors without cleanup. This is the same behaviour we currently have when the storage is disabled. Adds the Datastore.AllocateSpace check to cloudinit drives. Signed-off-by: Matthias Heiserer

Re: [pve-devel] [PATCH qemu-server v3] fix 3886: QEMU restore: verify storage allows images before writing

2022-02-24 Thread Fabian Ebner
Am 24.02.22 um 10:42 schrieb Matthias Heiserer: > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index a99f1a5..a808a0f 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServer.pm > @@ -6243,12 +6243,17 @@ my $parse_backup_hints = sub { > } elsif (!$storeid) { > } >

[pve-devel] [PATCH qemu-server v3] fix 3886: QEMU restore: verify storage allows images before writing

2022-02-24 Thread Matthias Heiserer
When restoring a backup and the storage the disks would be created on doesn't allow 'images', the process errors without cleanup. This is the same behaviour we currently have when the storage is disabled. Adds the Datastore.AllocateSpace check to cloudinit drives. Signed-off-by: Matthias Heiserer