[pve-devel] applied: [PATCH novnc] fix #3882: backport firefox workaround for ResizeObserver

On 11.02.22 14:57, Dominik Csapak wrote: > it's a minor but annoying issue, and novnc does not release that often, > so backport the patch > > also rebases our patches on top > > we can drop this with the next novnc release > > Signed-off-by: Dominik Csapak > --- > debian/patches/0017-make-err

[pve-devel] applied-series: [PATCH container 0/2] 'target-storage' follow-ups

On 11.02.22 11:29, Fabian Grünbichler wrote: > the 'pve-targetstorage' standard option will be moved in a follow-up to > the remote migration series (with patches in qemu-server/pve-common > only, as pve-container picks up the option via pve-ha-manager anyway). > > thanks Fabian Ebner for the quic

[pve-devel] [PATCH pve-kernel-meta v3 2/4] proxmox-boot: fix #3671 add pin/unpin for kernel-version

The 2 commands follow the mechanics of p-b-t kernel add/remove in writing the desired abi-version to a config-file in /etc/kernel and actually modifying the boot-loader configuration upon p-b-t refresh. A dedicated new file is used instead of writing the version (with some kind of annotation) to t

[pve-devel] [PATCH pve-kernel-meta/proxmox-ve v3] proxmox-boot: add kernel pinning functionality (#3761)

changes v2->v3: * incoroporated Fabian's and Thomas' feedback - huge thanks: ** changed `p-b-t kernel next-boot ` to `p-b-t kernel pin --next-boot` ** improved usage output ** style-fixes to proxmox-ve apt-hook ** 'untaint' the fd fetched from the environment in proxmox-ve apt-hook * fixed a glit

[pve-devel] [PATCH proxmox-ve v3 2/3] apt-hook: verify that fd is numeric

since we read it from the environment Co-authored-by: Fabian Grünbichler Signed-off-by: Stoiko Ivanov --- debian/apthook/pve-apt-hook | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/apthook/pve-apt-hook b/debian/apthook/pve-apt-hook index 2053fef..8fa58c5 100755 --- a

[pve-devel] [PATCH pve-kernel-meta v3 1/4] proxmox-boot: return empty if file does not exist in get_first_line

makes using this helper shorter in most cases Signed-off-by: Stoiko Ivanov --- proxmox-boot/functions | 5 + 1 file changed, 5 insertions(+) diff --git a/proxmox-boot/functions b/proxmox-boot/functions index 4515a2d..27da363 100755 --- a/proxmox-boot/functions +++ b/proxmox-boot/functions @

[pve-devel] [PATCH proxmox-ve v3 3/3] apt-hook: add check preventing the removal of pinned kernels

the $file_read_firstline helper code is copied from PVE::Tools, since we do not want to depend on pve-common being in good shape when the apt hook is executed Co-authored-by: Fabian Grünbichler Signed-off-by: Stoiko Ivanov --- debian/apthook/pve-apt-hook | 28 1 fil

[pve-devel] [PATCH pve-kernel-meta v3 3/4] proxmox-boot: add --next-boot option kernel pin command

by setting the desired version in a dedicated file, which is used by the systemd service as condition for removing it and refreshing upon reboot. Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool | 53 ++- debian/pve-kernel-helper.install |

[pve-devel] [PATCH pve-kernel-meta v3 4/4] proxmox-boot: add pin/unpin functionality for non-p-b-t systems

While running `update-grub` directly in this case is a divergence from the semantics of the command when p-b-t handles booting it makes the cleanup in the `next-boot` case a bit tidier. fetching the next-boot version explicitly again before setting the provided version is to cover the sequence: p-

[pve-devel] [PATCH proxmox-ve v3 1/3] apt-hook: fix perlcritic warnings

Co-authored-by: Fabian Grünbichler Signed-off-by: Stoiko Ivanov --- debian/apthook/pve-apt-hook | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/debian/apthook/pve-apt-hook b/debian/apthook/pve-apt-hook index 1f77a1a..2053fef 100755 --- a/debian/apthook/pve-apt-hook +++

[pve-devel] [PATCH novnc] fix #3882: backport firefox workaround for ResizeObserver

it's a minor but annoying issue, and novnc does not release that often, so backport the patch also rebases our patches on top we can drop this with the next novnc release Signed-off-by: Dominik Csapak --- debian/patches/0017-make-error-hideable.patch | 4 +-- ...ow-start-button-on-not-running

Re: [pve-devel] [PATCH-SERIES 0/21] remote migration

Am 09.02.22 um 14:07 schrieb Fabian Grünbichler: > qemu-server: > move map_storage to PVE::JSONSchema::map_id > schema: use pve-bridge-id > parse_config: optional strict mode > update_vm: allow simultaneous setting of boot-order and dev > nbd alloc helper: allow passing in explicit format

Re: [pve-devel] [PATCH v5 qemu-server 08/11] migrate: refactor remote VM/tunnel start

Am 09.02.22 um 14:07 schrieb Fabian Grünbichler: > no semantic changes intended, except for: > - no longer passing the main migration UNIX socket to SSH twice for > forwarding > - dropping the 'unix:' prefix in start_remote_tunnel's timeout error message > > Signed-off-by: Fabian Grünbichler > --

Re: [pve-devel] [PATCH v5 qemu-server 07/11] mtunnel: add API endpoints

Am 09.02.22 um 14:07 schrieb Fabian Grünbichler: > + PVE::Cluster::check_cfs_quorum(); > + > + my $socket_addr = "/run/qemu-server/$vmid.mtunnel"; Nit: since there is another variable with the same name inside $realcmd below, and this one is not used until the end, it could be moved furthe

Re: [pve-devel] [PATCH v5 qemu-server 10/11] api: add remote migrate endpoint

Am 09.02.22 um 14:07 schrieb Fabian Grünbichler: > @@ -4016,6 +4016,206 @@ __PACKAGE__->register_method({ > > }}); > > +__PACKAGE__->register_method({ > +name => 'remote_migrate_vm', > +path => '{vmid}/remote_migrate', > +method => 'POST', > +protected => 1, > +proxyto

Re: [pve-devel] [PATCH container 0/2] 'target-storage' follow-ups

Am 11.02.22 um 11:29 schrieb Fabian Grünbichler: > the 'pve-targetstorage' standard option will be moved in a follow-up to > the remote migration series (with patches in qemu-server/pve-common > only, as pve-container picks up the option via pve-ha-manager anyway). > > thanks Fabian Ebner for the

Re: [pve-devel] [PATCH qemu-server follow-up] schema: move 'pve-targetstorage' to pve-common

Am 11.02.22 um 11:38 schrieb Fabian Grünbichler: > for proper re-use in pve-container. > > Signed-off-by: Fabian Grünbichler > --- > > Notes: > requires dependency on bumped libpve-common-perl > Tricky to build, but FWIW, both patches: Reviewed-by: Fabian Ebner > PVE/QemuServer.pm | 7 -

[pve-devel] [PATCH common follow-up] schema: take over 'pve-targetstorage' option

from qemu-server, for re-use in pve-container. Signed-off-by: Fabian Grünbichler --- Notes: requires versioned breaks on old qemu-server containing the option, to avoid registering twice src/PVE/JSONSchema.pm | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/PVE/JSONSchema

[pve-devel] [PATCH qemu-server follow-up] schema: move 'pve-targetstorage' to pve-common

for proper re-use in pve-container. Signed-off-by: Fabian Grünbichler --- Notes: requires dependency on bumped libpve-common-perl PVE/QemuServer.pm | 7 --- 1 file changed, 7 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index e703cee9..2228fe87 100644 --- a/PVE/Qemu

[pve-devel] [PATCH container 2/2] migrate: allow renaming of volumes

the config is now updated anyway because of target-storage support, so volume renaming is both 'free' and improves the chances of migration with and without changing storages actually works successfully. Signed-off-by: Fabian Grünbichler --- src/PVE/LXC/Migrate.pm | 1 + 1 file changed, 1 insert

[pve-devel] [PATCH container 1/2] migrate: improve target storage checks

Signed-off-by: Fabian Grünbichler --- src/PVE/API2/LXC.pm| 2 +- src/PVE/LXC/Migrate.pm | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 37db841..84712f7 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -11

[pve-devel] [PATCH container 0/2] 'target-storage' follow-ups

the 'pve-targetstorage' standard option will be moved in a follow-up to the remote migration series (with patches in qemu-server/pve-common only, as pve-container picks up the option via pve-ha-manager anyway). thanks Fabian Ebner for the quick but thorough review! :) Fabian Grünbichler (2): mi

[pve-devel] [PATCH pve-manager 5/6] ui: sdn: zones: evpn : add rt-import

Signed-off-by: Alexandre Derumier --- www/manager6/sdn/zones/EvpnEdit.js | 6 ++ 1 file changed, 6 insertions(+) diff --git a/www/manager6/sdn/zones/EvpnEdit.js b/www/manager6/sdn/zones/EvpnEdit.js index c994d674..0ac40fc5 100644 --- a/www/manager6/sdn/zones/EvpnEdit.js +++ b/www/manager6/s

[pve-devel] [PATCH pve-manager 3/6] ui: sdn: zones: evpn : add exitnodes-primary

Signed-off-by: Alexandre Derumier --- www/manager6/sdn/zones/EvpnEdit.js | 7 +++ 1 file changed, 7 insertions(+) diff --git a/www/manager6/sdn/zones/EvpnEdit.js b/www/manager6/sdn/zones/EvpnEdit.js index d5a09ecf..fcebbca7 100644 --- a/www/manager6/sdn/zones/EvpnEdit.js +++ b/www/manager6/

[pve-devel] [PATCH pve-docs 1/1] sdn: update bgp/evpn documentation

Signed-off-by: Alexandre Derumier --- pvesdn.adoc | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/pvesdn.adoc b/pvesdn.adoc index 223ba6d..1f32a8e 100644 --- a/pvesdn.adoc +++ b/pvesdn.adoc @@ -229,18 +229,30 @@ plugins section) VNet MAC address:: A un

[pve-devel] [PATCH pve-network 06/10] controllers: evpn: add missing bgp router-id in vrf

evpn route distinguisher is compute from bgp router-id. if not defined, it take random ip or 0.0.0.0 and could result collisions between hosts Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Controllers/EvpnPlugin.pm | 4 test/zones/evpn/advertise_subnets/expected

[pve-devel] [PATCH pve-docs 0/1] bgp/evpn improvements

add documentation on new bgp/evpn options Alexandre Derumier (1): sdn: update bgp/evpn documentation pvesdn.adoc | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) -- 2.30.2 ___ pve-devel mailing list pve-devel@lists.pr

[pve-devel] [PATCH pve-network 03/10] controllers: bgp: add bgp-multipath-as-path-relax option

Some users need it to do ecmp when peering with 2 differents asn Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Controllers/BgpPlugin.pm | 9 .../expected_controller_config| 43 .../multipath_relax/expected_sdn_interfaces | 41

[pve-devel] [PATCH pve-network 08/10] controllers: evpn : remove "no bgp ebgp-requires-policy"

It's already disabled in the default datacenter profile since frr 7.4 Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Controllers/BgpPlugin.pm | 1 - PVE/Network/SDN/Controllers/EvpnPlugin.pm| 1 - test/zones/evpn/ebgp/expected_controller_config | 2

[pve-devel] [PATCH pve-network 02/10] controllers: bgp: use loopback ip src for loopback network

can be usefull if we want to join other loopback ips, like a ceph cluster in the underlay network Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Controllers/BgpPlugin.pm | 7 +++ PVE/Network/SDN/Controllers/EvpnPlugin.pm| 2 ++ test/zones/evpn/ebgp_loop

[pve-devel] [PATCH pve-network 00/10] bgp/evpn improvements

This patch series include a lot of new evpn features requested by user forum and add some fixes/cleanup with new frr version Alexandre Derumier (10): zones: status : skip node if node don't have the zone controllers: bgp: use loopback ip src for loopback network controllers: bgp: add bgp-mul

[pve-devel] [PATCH pve-network 04/10] controllers: evpn : add min/max value to asn

Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Controllers/EvpnPlugin.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/Network/SDN/Controllers/EvpnPlugin.pm b/PVE/Network/SDN/Controllers/EvpnPlugin.pm index 61a6314..d02bdf7 100644 --- a/PVE/Network/SDN/Controllers/EvpnPlugin.p

[pve-devel] [PATCH pve-network 05/10] controllers: evpn/bgp : add exitnodes-primary && rework route-map

exitnodes-primary option force traffic to a primary node A route-map is used to increase metric on backup nodes. This can be usefull for snat or avoid asymetric routing. Route-map is rework to handle multiple sequences of route map. Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Controll

[pve-devel] [PATCH pve-network 10/10] controllers: evpn : remove ip forwarding, ipv6 forwarding and add frr version

Forwarding is enabled by default since frr 7.4 also add frr version && reorder some options to avoid warning message on frr reload Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Controllers/EvpnPlugin.pm | 7 +++ .../evpn/advertise_subnets/expected_controller_config

[pve-devel] [PATCH pve-manager 1/6] ui: sdn: zones: evpn : add exitnodes-local-routing && advertise-subnets

Signed-off-by: Alexandre Derumier --- www/manager6/sdn/zones/Base.js | 2 ++ www/manager6/sdn/zones/EvpnEdit.js | 22 ++ 2 files changed, 24 insertions(+) diff --git a/www/manager6/sdn/zones/Base.js b/www/manager6/sdn/zones/Base.js index e4dc7ccf..347889c0 100644 --- a/w

[pve-devel] [PATCH pve-manager 4/6] ui: sdn: zones: evpn : move controller option on top of the form

Signed-off-by: Alexandre Derumier --- www/manager6/sdn/zones/EvpnEdit.js | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/www/manager6/sdn/zones/EvpnEdit.js b/www/manager6/sdn/zones/EvpnEdit.js index fcebbca7..c994d674 100644 --- a/www/manager6/sdn/zones/EvpnEdi

[pve-devel] [PATCH pve-manager 2/6] ui: sdn: zones: evpn : add disable-arp-nd-suppression

Signed-off-by: Alexandre Derumier --- www/manager6/sdn/zones/EvpnEdit.js | 11 +++ 1 file changed, 11 insertions(+) diff --git a/www/manager6/sdn/zones/EvpnEdit.js b/www/manager6/sdn/zones/EvpnEdit.js index 04a6f4d6..d5a09ecf 100644 --- a/www/manager6/sdn/zones/EvpnEdit.js +++ b/www/man

[pve-devel] [PATCH pve-manager 6/6] ui: sdn : controllers: bgp : add bgp-multipath-as-path-relax

Signed-off-by: Alexandre Derumier --- www/manager6/sdn/controllers/BgpEdit.js | 7 +++ 1 file changed, 7 insertions(+) diff --git a/www/manager6/sdn/controllers/BgpEdit.js b/www/manager6/sdn/controllers/BgpEdit.js index b698d1be..ce5ef93d 100644 --- a/www/manager6/sdn/controllers/BgpEdit.js

[pve-devel] [PATCH pve-network 07/10] zones: evpn : add rt-import

Allow to import external route target list from external evpn network (main usecase is DC inter-connect) Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Controllers/EvpnPlugin.pm | 9 PVE/Network/SDN/Zones/EvpnPlugin.pm | 28 - .../evpn/rt_import/expected_co

[pve-devel] [PATCH pve-manager 0/6] bgp/evpn improvements

add new bgp/evpn options Alexandre Derumier (6): ui: sdn: zones: evpn : add exitnodes-local-routing && advertise-subnets ui: sdn: zones: evpn : add disable-arp-nd-suppression ui: sdn: zones: evpn : add exitnodes-primary ui: sdn: zones: evpn : move controller option on top of the form

[pve-devel] [PATCH pve-network 09/10] controllers: bgp : remove bgp network import-check

already enabled since frr 7.4 Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Controllers/BgpPlugin.pm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/PVE/Network/SDN/Controllers/BgpPlugin.pm b/PVE/Network/SDN/Controllers/BgpPlugin.pm index bfeda0c..73ed171 100644 --

[pve-devel] [PATCH pve-network 01/10] zones: status : skip node if node don't have the zone

reported by forum user: https://forum.proxmox.com/threads/proxmox-sdn-incorrect-node-deployment.99834/ Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/Network/SDN/Zones.pm b/PVE/Network/SDN/Zones.pm index a4d81e3..62dadb1 100

[pve-devel] [PATCH v2 qemu 3/3] add patch for loading a snapshot with qemu-img dd

Will be used when cloning from a qcow2 efidisk. Signed-off-by: Fabian Ebner --- New in v2. ...-add-l-option-for-loading-a-snapshot.patch | 129 ++ debian/patches/series | 1 + 2 files changed, 130 insertions(+) create mode 100644 debian/patches/pve/0

[pve-devel] [PATCH v2 qemu 2/3] fix getopt-string when introducing -n option for qemu-img dd

The colon after U is wrong, because it doesn't take an argument. Signed-off-by: Fabian Ebner --- New in v2. ...PVE-Up-qemu-img-dd-add-n-skip_create.patch | 64 +-- 1 file changed, 60 insertions(+), 4 deletions(-) diff --git a/debian/patches/pve/0012-PVE-Up-qemu-img-dd-add-n-sk

Re: [pve-devel] [PATCH v5 container 1/3] fix #1532: add target-storage support to migration

On February 10, 2022 12:52 pm, Fabian Ebner wrote: > Am 09.02.22 um 14:07 schrieb Fabian Grünbichler: >> re-using helpers that already exist for qemu-server. this is a >> pre-requisite for extending remote migration support to containers. >> >> Signed-off-by: Fabian Grünbichler >> --- >> >> Note