[pve-devel] [PATCH pve-kernel-meta/proxmox-ve v2] proxmox-boot: add kernel pinning functionality (#3761)

2022-02-04 Thread Stoiko Ivanov
changes v1->v2: * incorporated the feedback on the v1 (by Aaron and Fabian - huge thx!): ** a next-boot pin is now handled independently from a pin - i.e. if you both pin a kernel and set one for the next-boot - the system afterwards keeps the pinned version (instead of the latest) ** change

[pve-devel] [PATCH proxmox-ve v2 2/2] apt-hook: add check preventing the removal of pinned kernels

2022-02-04 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- debian/apthook/pve-apt-hook | 28 1 file changed, 28 insertions(+) diff --git a/debian/apthook/pve-apt-hook b/debian/apthook/pve-apt-hook index 50e50d1..6de56c4 100755 --- a/debian/apthook/pve-apt-hook +++ b/debian/apthook/pve-apt-hoo

[pve-devel] [PATCH pve-kernel-meta v2 1/4] proxmox-boot: return empty if file does not exist in get_first_line

2022-02-04 Thread Stoiko Ivanov
makes using this helper shorter in most cases Signed-off-by: Stoiko Ivanov --- proxmox-boot/functions | 5 + 1 file changed, 5 insertions(+) diff --git a/proxmox-boot/functions b/proxmox-boot/functions index 4515a2d..27da363 100755 --- a/proxmox-boot/functions +++ b/proxmox-boot/functions @

[pve-devel] [PATCH pve-kernel-meta v2 2/4] proxmox-boot: fix #3671 add pin/unpin for kernel-version

2022-02-04 Thread Stoiko Ivanov
The 2 commands follow the mechanics of p-b-t kernel add/remove in writing the desired abi-version to a config-file in /etc/kernel and actually modifying the boot-loader configuration upon p-b-t refresh. A dedicated new file is used instead of writing the version (with some kind of annotation) to t

[pve-devel] [PATCH pve-kernel-meta v2 3/4] proxmox-boot: add kernel next-boot command

2022-02-04 Thread Stoiko Ivanov
by setting the desired version in a dedicated file, which is used by the systemd service as condition for removing it and refreshing upon reboot Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool | 34 +-- debian/pve-kernel-helper.install |

[pve-devel] [PATCH pve-kernel-meta v2 4/4] proxmox-boot: add pin/unpin functionality for non-p-b-t systems

2022-02-04 Thread Stoiko Ivanov
While running `update-grub` directly in this case is a divergence from the semantics of the command when p-b-t handles booting it makes the cleanup in the `next-boot` case a bit tidier. Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool | 22 +++--- 1 file changed, 19 inserti

[pve-devel] [PATCH proxmox-ve v2 1/2] apt-hook: fix perlcritic warnings

2022-02-04 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- debian/apthook/pve-apt-hook | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/debian/apthook/pve-apt-hook b/debian/apthook/pve-apt-hook index 1f77a1a..50e50d1 100755 --- a/debian/apthook/pve-apt-hook +++ b/debian/apthook/pve-apt-hook @@ -20

[pve-devel] applied: [PATCH v2 storage] fix #1816: rbd: add support for erasure coded ec pools

2022-02-04 Thread Thomas Lamprecht
On 28.01.22 12:22, Aaron Lauterer wrote: > The first step is to allocate rbd images correctly. > > The metadata objects still need to be stored in a replicated pool, but > by providing the --data-pool parameter on image creation, we can place > the data objects on the erasure coded (EC) pool. > >

[pve-devel] applied: [PATCH manager] query-url-metadata: change default user-agent to "Proxmox VE"

2022-02-04 Thread Thomas Lamprecht
On 01.02.22 15:02, Oguz Bektas wrote: > to avoid being blacklisted because of the default libwww-perl user-agent > > issue was reported in community forum [0] > > [0]: https://forum.proxmox.com/threads/104081/ > > Signed-off-by: Oguz Bektas > --- > PVE/API2/Nodes.pm | 1 + > 1 file changed, 1

[pve-devel] applied: [PATCH pve-kernel-meta 2/5] proxmox-boot: add get_first_line_from_file helper and use it

2022-02-04 Thread Thomas Lamprecht
On 31.01.22 18:59, Stoiko Ivanov wrote: > Signed-off-by: Stoiko Ivanov > --- > proxmox-boot/functions | 8 > proxmox-boot/zz-proxmox-boot | 4 +--- > 2 files changed, 9 insertions(+), 3 deletions(-) > > applied, thanks! ___ pve-devel

[pve-devel] applied: [PATCH pve-kernel-meta 1/5] proxmox-boot: drop unused potential_esps function

2022-02-04 Thread Thomas Lamprecht
On 31.01.22 18:59, Stoiko Ivanov wrote: > Signed-off-by: Stoiko Ivanov > --- > proxmox-boot/zz-proxmox-boot | 5 - > 1 file changed, 5 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox

[pve-devel] applied: [PATCH manager] api: apt: list_updates: fix dependency detection for virtual package

2022-02-04 Thread Thomas Lamprecht
On 03.02.22 12:32, Fabian Ebner wrote: > A virtual package does not have SelectedState Install, but the > dependency will still be satisfied if a package providing it has. > > Fixes a bug, wrongly showing that postfix will be installed, when a > different mail-transport-agent is installed and a pv

Re: [pve-devel] [PATCH manager] ui: osd: warn if removal could be problematic

2022-02-04 Thread Thomas Lamprecht
On 04.02.22 10:50, Aaron Lauterer wrote: > If an OSD is removed during the wrong conditions, it could lead to > blocked IO or worst case data loss. > > Check against global flags that limit the capabilities of Ceph to heal > itself (norebalance, norecover, noout) and if there are degraded > object

[pve-devel] applied: [PATCH v2 guest-common 2/2] config: activate affected storages for snapshot operations

2022-02-04 Thread Thomas Lamprecht
On 13.01.22 12:04, Fabian Ebner wrote: > For snapshot creation, the storage for the vmstate file is activated > via vdisk_alloc when the state file is created. > > Do not activate the volumes themselves, as that has unnecessary side > effects (e.g. waiting for zvol device link for ZFS, mapping the

[pve-devel] applied: [PATCH v2 guest-common 1/2] config: remove unused variable

2022-02-04 Thread Thomas Lamprecht
On 13.01.22 12:04, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > src/PVE/AbstractConfig.pm | 2 -- > 1 file changed, 2 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi

[pve-devel] applied: [PATCH v4 guest-common 1/3] migrate: handle migration_network with remote migration

2022-02-04 Thread Thomas Lamprecht
On 03.02.22 13:41, Fabian Grünbichler wrote: > remote migration always has an explicit endpoint from the start which > gets used for everything. > > Signed-off-by: Fabian Grünbichler > --- > src/PVE/AbstractMigrate.pm | 37 + > 1 file changed, 21 insertions(+)

[pve-devel] applied: [PATCH v4 storage 2/4] storage_migrate: pull out snapshot decision

2022-02-04 Thread Thomas Lamprecht
On 03.02.22 13:41, Fabian Grünbichler wrote: > into new top-level helper for re-use with remote migration. > > Signed-off-by: Fabian Grünbichler > --- > > Notes: > v4: > - correctly use source storage for decision > - fold fixup into correct patch > > PVE/Storage.pm | 14 ++

[pve-devel] applied: [PATCH v4 storage 1/4] volname_for_storage: parse volname before calling

2022-02-04 Thread Thomas Lamprecht
On 03.02.22 13:41, Fabian Grünbichler wrote: > to allow reusing this with remote migration, where parsing of the source > volid has to happen on the source node, but this call has to happen on > the target node. > > Signed-off-by: Fabian Grünbichler > --- > PVE/Storage.pm | 16 +--- >

[pve-devel] [PATCH access-control/manager v2] fix #3668: improving realm sync

2022-02-04 Thread Dominik Csapak
this deprecates the 'full' sync option and replaces it with a 'mode' option, where we add a third one that updates the current users (while retaining their custom set attributes not exisiting in the source) and removing users that don't exist anymore in the source sorry for the long time between v

[pve-devel] [PATCH access-control v2 2/2] fix #3668: realm-sync: add mode 'sync'

2022-02-04 Thread Dominik Csapak
this mode behaves like the 'update' mode (so it updates users with new data from the server, and adds new users), but also deletes users and groups that do not exist anymore on the sync source. this way, an admin can add custom data (e.g. keys) to the users in pve while keeping only the users avai

[pve-devel] [PATCH manager v2 1/1] ui: realm sync: replace 'full' with 'mode'

2022-02-04 Thread Dominik Csapak
in default sync options and the sync window. since we get the mapped mode from the backend on read, a 'full=1' there will map to 'mode=full' and we can simply use that using this on a node with an old version will not work though Signed-off-by: Dominik Csapak --- www/manager6/dc/AuthEditLDAP.js

[pve-devel] [PATCH access-control v2 1/2] realm-sync: replace 'full' option with 'mode'

2022-02-04 Thread Dominik Csapak
to be able to add more modes in the future. full=0 maps to mode=update and full=1 to mode=full but keep 'full' for backwards-compatibiltiy. On create/update, replace full=1 with mode=full, on read, return both. add a deprecation notice to the description of full, and a todo to remove 'full' with

Re: [pve-devel] [PATCH v4 guest-common 0/22] remote migration

2022-02-04 Thread Fabian Ebner
Am 03.02.22 um 13:41 schrieb Fabian Grünbichler: > this series adds remote migration for VMs. > > both live and offline migration including NBD and storage-migrated disks > should work. groundwork for extending to pve-container and pvesr already > laid. > Everything besides storage 4/4 and guest

Re: [pve-devel] [PATCH v4 qemu-server 11/11] qm: add remote_migrate command

2022-02-04 Thread Fabian Ebner
Am 03.02.22 um 13:41 schrieb Fabian Grünbichler: > @@ -900,6 +1017,7 @@ our $cmddef = { > clone => [ "PVE::API2::Qemu", 'clone_vm', ['vmid', 'newid'], { node => > $nodename }, $upid_exit ], > > migrate => [ "PVE::API2::Qemu", 'migrate_vm', ['vmid', 'target'], { node > => $nodename },

Re: [pve-devel] [PATCH v4 qemu-server 09/11] migrate: add remote migration handling

2022-02-04 Thread Fabian Ebner
Am 03.02.22 um 13:41 schrieb Fabian Grünbichler: > @@ -251,22 +311,30 @@ sub scan_local_volumes { > next if @{$dl->{$storeid}} == 0; > > my $targetsid = > PVE::QemuServer::map_id($self->{opts}->{storagemap}, $storeid); > - # check if storage is available on target nod

Re: [pve-devel] [PATCH v4 guest-common 3/3] add storage tunnel module

2022-02-04 Thread Fabian Ebner
Am 03.02.22 um 13:41 schrieb Fabian Grünbichler: > +sub storage_migrate { > +my ($tunnel, $storecfg, $volid, $local_vmid, $remote_vmid, $opts, $log) > = @_; > + > +my $targetsid = $opts->{targetsid}; > +my $bwlimit = $opts->{bwlimit}; > + > +# JSONSchema and get_bandwidth_limit use

Re: [pve-devel] [PATCH v4 guest-common 2/3] add tunnel helper module

2022-02-04 Thread Fabian Ebner
Am 03.02.22 um 13:41 schrieb Fabian Grünbichler: > +if ($cpid) { > + $writer->writer(); > + $reader->reader(); > + my $tunnel = { > + writer => $writer, > + reader => $reader, > + pid => $cpid, > + log => $log, > + }; > + > + eval { > +

Re: [pve-devel] [PATCH v4 storage 4/4] add volume_import/export_start helpers

2022-02-04 Thread Fabian Ebner
Am 03.02.22 um 13:41 schrieb Fabian Grünbichler: > diff --git a/PVE/Storage.pm b/PVE/Storage.pm > index 837df1b..682dd38 100755 > --- a/PVE/Storage.pm > +++ b/PVE/Storage.pm > @@ -1833,6 +1833,72 @@ sub volume_imported_message { > } > } > > +# $format and $volname are requests and might be

Re: [pve-devel] [PATCH manager] ui: osd: warn if removal could be problematic

2022-02-04 Thread Alwin Antreich via pve-devel
--- Begin Message --- February 4, 2022 10:50 AM, "Aaron Lauterer" wrote: > If an OSD is removed during the wrong conditions, it could lead to > blocked IO or worst case data loss. > > Check against global flags that limit the capabilities of Ceph to heal > itself (norebalance, norecover, noout)

[pve-devel] [PATCH manager] ui: osd: warn if removal could be problematic

2022-02-04 Thread Aaron Lauterer
If an OSD is removed during the wrong conditions, it could lead to blocked IO or worst case data loss. Check against global flags that limit the capabilities of Ceph to heal itself (norebalance, norecover, noout) and if there are degraded objects. Signed-off-by: Aaron Lauterer --- Those are the

[pve-devel] partially-applied-series: [PATCH v4 proxmox-websocket-tunnel 1/4] initial commit

2022-02-04 Thread Thomas Lamprecht
On 03.02.22 13:41, Fabian Grünbichler wrote: > Signed-off-by: Fabian Grünbichler > --- > .gitignore| 1 + > .cargo/config | 5 + > Cargo.toml| 11 +++ > 3 files changed, 17 insertions(+) > create mode 100644 .gitignore > create mode 100644 .cargo/config > create mode 1006