[pve-devel] [PATCH v4 container 8/9 (follow up)] api: move-volume: add move to another container

2021-11-05 Thread Aaron Lauterer
The goal of this is to expand the move-volume API endpoint to make it possible to move a container volume / mountpoint to another container. For unused volumes, the API parameters have been changed to allow them as well. This means, additional checks had to be introduced to avoid migration of an u

Re: [pve-devel] [PATCH qemu-server] cfg2cmd: turn smm off when SeaBIOS and serial display are used

2021-11-05 Thread Fabian Ebner
Am 05.11.21 um 14:12 schrieb Thomas Lamprecht: On 05.11.21 14:06, Fabian Ebner wrote: Since commit 277d33454f77ec1d1e0bc04e37621e4dd2424b67 in pve-qemu, smm=off is no longer the default, but with SeaBIOS and serial display, this can lead to a boot loop. Reported in the community forum [0] and r

[pve-devel] [PATCH manager] ceph: fix version check shortcut

2021-11-05 Thread Dominik Csapak
with 'get_node_kv', we get a hash which contains the value for all nodes in the cluster (with the nodename as key), so we have to use the value from the hash corresponding to our nodename. also the 'str' property is inside the 'version' hash Signed-off-by: Dominik Csapak --- i noticed on my ceph

Re: [pve-devel] [PATCH pve-cluster] sysctl: disable net.ipv4.igmp_link_local_mcast_reports

2021-11-05 Thread Thomas Lamprecht
On 06.10.21 10:32, Alexandre Derumier wrote: > currently, when veth or tap interfaces are plugged to bridge, > an igmp v3 report is broadcasted to the network, with the > bridge mac adddress. but this disables it for all, couldn't there be repercussions for people relying on multicast? Should it

[pve-devel] applied-series: [PATCH manager v3 0/7] multi disk/mp in wizard

2021-11-05 Thread Thomas Lamprecht
On 05.10.21 13:28, Dominik Csapak wrote: > Dominik Csapak (7): > ui: lxc/MPEdit: add updateVMConfig > ui: lxc/MPEdit: fire diskidchange event > ui: lxc/MPEdit: add selectFree toggle > ui: add MultiDiskPanel > ui: add lxc/MultiMPEdit and use in lxc/CreateWizard > ui: add qemu/MultiHDEdit

Re: [pve-devel] [PATCH qemu-server] cfg2cmd: turn smm off when SeaBIOS and serial display are used

2021-11-05 Thread Thomas Lamprecht
On 05.11.21 14:06, Fabian Ebner wrote: > Since commit 277d33454f77ec1d1e0bc04e37621e4dd2424b67 in pve-qemu, > smm=off is no longer the default, but with SeaBIOS and serial display, > this can lead to a boot loop. > > Reported in the community forum [0] and reproduced with a Debian 10 > VM. > > [0

[pve-devel] [PATCH qemu-server] cfg2cmd: turn smm off when SeaBIOS and serial display are used

2021-11-05 Thread Fabian Ebner
Since commit 277d33454f77ec1d1e0bc04e37621e4dd2424b67 in pve-qemu, smm=off is no longer the default, but with SeaBIOS and serial display, this can lead to a boot loop. Reported in the community forum [0] and reproduced with a Debian 10 VM. [0]: https://forum.proxmox.com/threads/pve-7-0-all-vms-w

[pve-devel] [PATCH qemu-server 09/10] migrate: add remote migration handling

2021-11-05 Thread Fabian Grünbichler
remote migration uses a websocket connection to a task worker running on the target node instead of commands via SSH to control the migration. this websocket tunnel is started earlier than the SSH tunnel, and allows adding UNIX-socket forwarding over additional websocket connections on-demand. the

[pve-devel] [PATCH qemu-server 07/10] mtunnel: add API endpoints

2021-11-05 Thread Fabian Grünbichler
the following two endpoints are used for migration on the remote side POST /nodes/NODE/qemu/VMID/mtunnel which creates and locks an empty VM config, and spawns the main qmtunnel worker which binds to a VM-specific UNIX socket. this worker handles JSON-encoded migration commands coming in via thi

[pve-devel] [PATCH qemu-server 08/10] migrate: refactor remote VM/tunnel start

2021-11-05 Thread Fabian Grünbichler
no semantic changes intended, except for: - no longer passing the main migration UNIX socket to SSH twice for forwarding - dropping the 'unix:' prefix in start_remote_tunnel's timeout error message Signed-off-by: Fabian Grünbichler --- PVE/QemuMigrate.pm | 158 ---

[pve-devel] [PATCH qemu-server 03/10] migrate: factor out storage checks

2021-11-05 Thread Fabian Grünbichler
to re-use them for incoming remote migrations. Signed-off-by: Fabian Grünbichler --- PVE/API2/Qemu.pm | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index b479811..c290a42 100644 --- a/PVE/API2/Qemu.pm +++ b/PV

[pve-devel] [PATCH qemu-server 10/10] api: add remote migrate endpoint

2021-11-05 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- Notes: the checks currently done before the actual migration worker is forked could be either moved to the client calling this (that then makes the required API calls) or extracted into a precond API call like for regular migration. f

[pve-devel] [PATCH proxmox-websocket-tunnel 4/4] add packaging

2021-11-05 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- Makefile | 44 ++ debian/changelog | 5 debian/control | 57 debian/copyright | 16 + debian/debcargo.toml | 13 ++ 5 files change

[pve-devel] [PATCH common 1/3] schema: rename storagepair to storage-pair

2021-11-05 Thread Fabian Grünbichler
more consistent with the other options/formats like pve-storage-id Signed-off-by: Fabian Grünbichler --- Notes: v2: new this breaks older qemu-server without the patch adapting to the new name src/PVE/JSONSchema.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[pve-devel] [PATCH access-control 2/2] ticket: normalize path for verification

2021-11-05 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- src/PVE/AccessControl.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm index dfd3af5..a80ed74 100644 --- a/src/PVE/AccessControl.pm +++ b/src/PVE/AccessControl.pm @@ -457,6 +457,8 @@ my $assemble_sho

[pve-devel] [PATCH proxmox-websocket-tunnel 3/4] add fingerprint validation

2021-11-05 Thread Fabian Grünbichler
in case we have no explicit fingerprint, we use openssl's regular "PEER" verification. if we have a fingerprint, we ignore openssl altogether and just verify the fingerprint of the presented leaf certificate. Signed-off-by: Fabian Grünbichler --- Cargo.toml | 1 + src/main.rs | 47

[pve-devel] [PATCH proxmox-websocket-tunnel 1/4] initial commit

2021-11-05 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- .gitignore| 1 + .cargo/config | 5 + Cargo.toml| 11 +++ 3 files changed, 17 insertions(+) create mode 100644 .gitignore create mode 100644 .cargo/config create mode 100644 Cargo.toml diff --git a/.gitignore b/.gitignore new file mo

[pve-devel] [PATCH proxmox 1/1] websocket: adapt for client connection

2021-11-05 Thread Fabian Grünbichler
previously, this was only used for the server side handling of web sockets. by making the mask part of the WebSocket struct and making some of the fns associated, we can re-use this for client-side connections such as in proxmox-websocket-tunnel. Signed-off-by: Fabian Grünbichler --- Notes:

[pve-devel] [PATCH qemu-server 06/10] update_vm: allow simultaneous setting of boot-order and dev

2021-11-05 Thread Fabian Grünbichler
else this fails if we check 'boot' before the device was put into the config or pending section. Signed-off-by: Fabian Grünbichler --- Notes: as happens when doing a remote migration and the full config is passed through update_vm_api PVE/API2/Qemu.pm | 2 +- 1 file changed, 1 inserti

[pve-devel] [PATCH qemu-server 05/10] schema: use pve-bridge-id

2021-11-05 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- Notes: requires pve-common with pve-bridge-id PVE/QemuServer.pm | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 23e7b08..de8c1bb 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.p

[pve-devel] [PATCH qemu-server 04/10] refactor map_storage to map_id

2021-11-05 Thread Fabian Grünbichler
since we are going to reuse the same mechanism/code for network bridge mapping. Signed-off-by: Fabian Grünbichler --- PVE/QemuMigrate.pm | 6 +++--- PVE/QemuServer.pm | 6 -- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index ae3eaf1

[pve-devel] [PATCH proxmox-websocket-tunnel 2/4] add tunnel implementation

2021-11-05 Thread Fabian Grünbichler
the websocket tunnel helper accepts control commands (encoded as single-line JSON) on stdin, and prints responses on stdout. the following commands are available: - "connect" a 'control' tunnel via a websocket - "forward" a local unix socket to a remote socket via a websocket -- if requested, this

[pve-devel] [PATCH guest-common 1/1] migrate: handle migration_network with remote migration

2021-11-05 Thread Fabian Grünbichler
we only want to use an explicitly provided migration network, not one for the local cluster. Signed-off-by: Fabian Grünbichler --- src/PVE/AbstractMigrate.pm | 51 +++--- 1 file changed, 31 insertions(+), 20 deletions(-) diff --git a/src/PVE/AbstractMigrate.pm b/

[pve-devel] [PATCH qemu-server 02/10] adapt to renamed storage-pair format

2021-11-05 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- Notes: v2: new requires bumped dependency on pve-common with renaming patch PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 763c412..a0e1809 100644 --- a/PVE/Qemu

[pve-devel] [PATCH http-server 1/1] webproxy: handle unflushed write buffer

2021-11-05 Thread Fabian Grünbichler
for proxied requests, we usually tear down the proxy connection immediately when closing the source connection. this is not the correct course of action for bulk one-way data streams that are proxied, where the source connection might be closed, but the proxy connection might still have data in the

[pve-devel] [PATCH qemu-server 01/10] d/control: add pve-ha-manager to B-D

2021-11-05 Thread Fabian Grünbichler
it's needed for tests to succeed. Signed-off-by: Fabian Grünbichler --- debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index 8349738..8032ae5 100644 --- a/debian/control +++ b/debian/control @@ -20,6 +20,7 @@ Build-Depends: debhelper (>= 12~),

[pve-devel] [PATCH common 3/3] schema: add proxmox-remote format/option

2021-11-05 Thread Fabian Grünbichler
for usage in remote migration/replication. Signed-off-by: Fabian Grünbichler --- src/PVE/JSONSchema.pm | 27 +++ 1 file changed, 27 insertions(+) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index 09c8fc0..38be3f8 100644 --- a/src/PVE/JSONSchema.pm +++ b/sr

[pve-devel] [PATCH common 2/3] schema: add pve-bridge-id option/format/pair

2021-11-05 Thread Fabian Grünbichler
for re-use in qemu-server/pve-container, which already have this option duplicated. the '-pair' is needed for remote migration, but can also be a nice addition to regular intra-cluster migration to lift the restriction of having identically named bridges. Signed-off-by: Fabian Grünbichler --- No

[pve-devel] [PATCH access-control 1/2] tickets: add tunnel ticket

2021-11-05 Thread Fabian Grünbichler
just like VNC ticket, but different prefix to prevent confusion. Signed-off-by: Fabian Grünbichler --- src/PVE/AccessControl.pm | 50 ++-- 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm index

[pve-devel] [PATCH-series qemu-server++ 0/22] remote migration

2021-11-05 Thread Fabian Grünbichler
this series adds remote migration for VMs. there's still some of TODOs/FIXMEs/stuff that requires discussion left, but this should hopefully be possible to apply with minor modifications and lots of future extensions. both live and offline migration including NBD and storage-migrated disks should

[pve-devel] applied: [PATCH manager] ui: guest backup grid: monitor store errors

2021-11-05 Thread Thomas Lamprecht
On 22.10.21 11:07, Fabian Ebner wrote: > so that users see when something went wrong. > > Don't mask the grid directly, but rather only its view so that the > title bar can be used for selecting another storage during load. > > Reported in the community forum: > https://forum.proxmox.com/threads/

[pve-devel] applied: [PATCH storage v2 1/1] cephfs: add support for multiple ceph filesystems

2021-11-05 Thread Thomas Lamprecht
On 25.10.21 16:01, Dominik Csapak wrote: > by optionally saving the name of the cephfs > > Signed-off-by: Dominik Csapak > --- > PVE/Storage/CephFSPlugin.pm | 8 > 1 file changed, 8 insertions(+) > > applied, thanks! ___ pve-devel mailing

[pve-devel] [proxmox-backup-qemu] update dependencies to latest proxmox-backup git version

2021-11-05 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- Cargo.toml | 15 +++ src/backup.rs | 11 +++ src/commands.rs | 15 +-- src/lib.rs | 11 ++- src/restore.rs | 13 ++--- src/shared_cache.rs | 2 +- src/upload_queue.rs | 6 -- 7

[pve-devel] [PATCH storage 1/2] lvm thin: status: code cleanup

2021-11-05 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- PVE/Storage/LvmThinPlugin.pm | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/PVE/Storage/LvmThinPlugin.pm b/PVE/Storage/LvmThinPlugin.pm index 4ba6f90..34e57b2 100644 --- a/PVE/Storage/LvmThinPlugin.pm +++ b/PVE/Storage/LvmThin

[pve-devel] [PATCH storage 2/2] lvm thin: don't assume that a thin pool and its volumes are active

2021-11-05 Thread Fabian Ebner
There are cases where autoactivation can fail, as reported in the community forum [0]. And it could also be that a volume was deactivated by something outside of our control. It doesn't seem strictly necessary to activate the thin pool itself (creating/removing/activating LVs within the pool still

[pve-devel] [PATCH frr 2/2] bump to 8.0.1

2021-11-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- Makefile | 4 ++-- debian/changelog | 6 ++ debian/control | 56 3 files changed, 36 insertions(+), 30 deletions(-) diff --git a/Makefile b/Makefile index dcd7d74..7123516 100644 --- a/Makefile

[pve-devel] [PATCH frr 1/2] update patches

2021-11-05 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- ...e-ax_python.m4-to-hardcode-python3.9.patch | 25 .../patches/pve/0001-enable-bgp-daemon.patch | 8 +-- ...on-for-RT-auto-derivation-to-force-A.patch | 59 ++- debian/patches/series | 1 - 4 files changed,

[pve-devel] [PATCH frr 0/2] update frr to 8.0.1

2021-11-05 Thread Alexandre Derumier
This patch series update frr to 8.0.1. I'm running it in production since 1month, no bug detected, evpn works fine (with some fixes for ip mobility). This need to bump the proxmox frr mirror to 8.0.1 tag. Also, this need the libyang2, not available in debian repo. Deb are available in frr repos:

Re: [pve-devel] [PATCH v4 manager 2/5] ui: refactor UploadToStorage.js

2021-11-05 Thread Dominik Csapak
comments inline On 8/31/21 12:16, Lorenz Stechauner wrote: this also removes the "content" selector from the window. as far as it seems, this selector was never able to select more than one entry, so it was useless. the check for FormData() is also removed, because this is supported by all majo

Re: [pve-devel] [PATCH v4 manager 1/5] ui: move upload window into UploadToStorage.js

2021-11-05 Thread Dominik Csapak
Looks mostly ok, some small nits (replied to the separate patches) those could also be sent as follow ups Aside from those things Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak On 8/31/21 12:16, Lorenz Stechauner wrote: Signed-off-by: Lorenz Stechauner --- www/manager6/Makefile

Re: [pve-devel] [PATCH v4 manager 5/5] ui/UplaodToStorage: check file extension

2021-11-05 Thread Dominik Csapak
one nit inline On 8/31/21 12:16, Lorenz Stechauner wrote: Signed-off-by: Lorenz Stechauner --- www/manager6/window/UploadToStorage.js | 5 + 1 file changed, 5 insertions(+) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js index f0c6186f..ec83

[pve-devel] [PATCH pve-network 5/5] vnets: alias: fix regex

2021-11-05 Thread Alexandre Derumier
--- PVE/Network/SDN/VnetPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Network/SDN/VnetPlugin.pm b/PVE/Network/SDN/VnetPlugin.pm index 121fb7f..062904c 100644 --- a/PVE/Network/SDN/VnetPlugin.pm +++ b/PVE/Network/SDN/VnetPlugin.pm @@ -68,7 +68,7 @@ sub properties

[pve-devel] [PATCH pve-network 2/5] get_local_vnets: add permissions on /sdn/vnets/*

2021-11-05 Thread Alexandre Derumier
--- PVE/Network/SDN.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Network/SDN.pm b/PVE/Network/SDN.pm index d3399ce..b95dd5b 100644 --- a/PVE/Network/SDN.pm +++ b/PVE/Network/SDN.pm @@ -193,7 +193,7 @@ sub get_local_vnets { my $privs = [ 'SDN.Audit', 'SDN.Alloc

[pve-devel] [PATCH pve-network 4/5] zones: evpn: add disable-arp-nd-suppression option

2021-11-05 Thread Alexandre Derumier
arp-nd-suppression can break ip mobility, when an ip from a vm is moved to another vm, with different mac. For example, with a keepalived vip, the garp is filtered. --- PVE/Network/SDN/Zones/EvpnPlugin.pm | 10 - .../expected_controller_config| 31 ++ .../

[pve-devel] [PATCH pve-network 3/5] api2: zones: fix update

2021-11-05 Thread Alexandre Derumier
--- PVE/API2/Network/SDN/Zones.pm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/PVE/API2/Network/SDN/Zones.pm b/PVE/API2/Network/SDN/Zones.pm index 9485590..6e53240 100644 --- a/PVE/API2/Network/SDN/Zones.pm +++ b/PVE/API2/Network/SDN/Zones.pm @@ -284,9 +284,7 @@ __PACKAGE

[pve-devel] [PATCH pve-network 0/5] sdn fixes and improvements

2021-11-05 Thread Alexandre Derumier
This is a resubmit of last months patches + some new fix && features for evpn. Alexandre Derumier (5): vnet/subnet : add skipdns option get_local_vnets: add permissions on /sdn/vnets/* api2: zones: fix update zones: evpn: add disable-arp-nd-suppression option vnets: alias: fix regex

[pve-devel] [PATCH pve-network 1/5] vnet/subnet : add skipdns option

2021-11-05 Thread Alexandre Derumier
allow to register ip to ipam without dns registration. can be used for temp/pending ip for example --- PVE/Network/SDN/Subnets.pm | 70 ++ PVE/Network/SDN/Vnets.pm | 16 - 2 files changed, 49 insertions(+), 37 deletions(-) diff --git a/PVE/Network/SDN