On 27/10/2021 14:46, Fabian Ebner wrote:
> For linked clones, the base name was included, which is confusing.
>
> Signed-off-by: Fabian Ebner
> ---
> PVE/Storage/RBDPlugin.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
On 27/10/2021 13:35, Dominik Csapak wrote:
> this allows a user to set a drive to 'read-only'. This can be useful
> if a disk should not be written to, or if the backing file/source is
> not writable (like a mapped pbs backup to /dev/loopX).
>
> the option is named 'ro', to achieve consistency wit
On 27/10/2021 12:30, Thomas Lamprecht wrote:
On 18/10/2021 22:21, Mark Yardley wrote:
Signed-off-by: Mark Yardley
---
src/PVE/Firewall.pm | 4
1 file changed, 4 insertions(+)
diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm
index edc5336..6b9b787 100644
--- a/src/PVE/Firewall.
this way, users can use the 'non-full' mode to provide local
information (like tfa keys), but still remove the users not present in
the ldap anymore.
Signed-off-by: Dominik Csapak
---
src/PVE/API2/Domains.pm | 5 +++--
src/PVE/Auth/Plugin.pm | 7 +++
2 files changed, 10 insertions(+), 2 del
in default sync options and the sync window. There we disable it if
'full' sync is enabled to make it clear the combination does not make
sense.
Signed-off-by: Dominik Csapak
---
www/manager6/dc/AuthEditLDAP.js | 14 +-
www/manager6/dc/SyncWindow.js | 19 +++
2 file
by improving wording in the api description and adding a
'remove-vanished' option
pve-access-control:
Dominik Csapak (2):
fix #3668: realm sync: add 'remove-vanished' parameter to delete
non-existing users
realm sync: improve wording in log and description
src/PVE/API2/Domains.pm | 14 +
by
* differentiating 'updated' users in full sync ('overwrote')
* adding '(full)' in the log for full syncs
* making it more clear what full sync does and what happens otherwise
Signed-off-by: Dominik Csapak
---
src/PVE/API2/Domains.pm | 9 +++--
src/PVE/Auth/Plugin.pm | 7 ---
2 files
For linked clones, the base name was included, which is confusing.
Signed-off-by: Fabian Ebner
---
PVE/Storage/RBDPlugin.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm
index 4bd43d5..613d32b 100644
--- a/PVE/Storage/
Nice work! For all patches except #8 it's only nits from my side, so
those are:
Reviewed-by: Fabian Ebner
Tested-by: Fabian Ebner
I did run into one strange issue with RBD upon destroying a VM, but it
didn't pop up consistently and maybe it's just my cluster (all VMs were
powered off):
r
On 27/10/2021 13:34, Stefan Reiter wrote:
> Since 'backup' can now work asynchronously, QEMU may not be ready to
> receive the next QMP command ('cont') immediately. Thus, increase the
> timeout, to avoid aborted backups in slow environments.
>
> There may be a deeper QEMU bug hidden under the cov
Am 21.10.21 um 13:30 schrieb Aaron Lauterer:
The goal of this is to expand the move-volume API endpoint to make it
possible to move a container volume / mountpoint to another container.
Currently it works for regular mountpoints though it would be nice to be
able to do it for unused mounpoints a
Since 'backup' can now work asynchronously, QEMU may not be ready to
receive the next QMP command ('cont') immediately. Thus, increase the
timeout, to avoid aborted backups in slow environments.
There may be a deeper QEMU bug hidden under the covers here too, but at
least one user reported success
this allows a user to set a drive to 'read-only'. This can be useful
if a disk should not be written to, or if the backing file/source is
not writable (like a mapped pbs backup to /dev/loopX).
the option is named 'ro', to achieve consistency with containers
while this could also be achieved by se
On 18/10/2021 22:21, Mark Yardley wrote:
> Signed-off-by: Mark Yardley
> ---
> src/PVE/Firewall.pm | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm
> index edc5336..6b9b787 100644
> --- a/src/PVE/Firewall.pm
> +++ b/src/PVE/Firewall.pm
> @@ -
On 27/10/2021 08:49, Fabian Ebner wrote:
> Otherwise, this can produce an undef warning and be misleading.
>
> Signed-off-by: Fabian Ebner
> ---
> PVE/QemuServer.pm | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>
applied, thanks!
On 27/10/2021 09:27, Dominik Csapak wrote:
> note that one must enable IOMMU support in the BIOS/UEFI.
>
> Signed-off-by: Dominik Csapak
> ---
> qm-pci-passthrough.adoc | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>
applied, thanks!
_
On 27/10/2021 09:27, Dominik Csapak wrote:
> this is wrong and does nothing. see
> https://www.kernel.org/doc/html/v5.11/admin-guide/kernel-parameters.html?highlight=amd_iommu
>
> Signed-off-by: Dominik Csapak
> ---
> qm-pci-passthrough.adoc | 7 +--
> 1 file changed, 1 insertion(+), 6 delet
General style nit: some line bloat could be reduced by making use of the
100 character limit when it doesn't impact readability and using $@
directly with a post-if rather than 'if(my $err = $@)' if the body of
the if only prints/dies with the error.
One more nit inline.
Am 21.10.21 um 13:30
Works like expected.
The one big problem I had previously with MDS not being ready is gone as one
can see now in the task log, that it is waiting for the MDS to become active
before continuing.
Tested the removal procedure outlined in the docs patch and as long as the
storage is still active,
Am 21.10.21 um 13:30 schrieb Aaron Lauterer:
Functionality has been added for the following storage types:
* directory ones, based on the default implementation:
* directory
* NFS
* CIFS
* gluster
* ZFS
* (thin) LVM
* Ceph
A new feature `rename` has been introduced to mark w
Am 21.10.21 um 13:30 schrieb Aaron Lauterer:
This new method exposes the functionality to request a new, not yet
used, volname for a storage.
The default implementation will return the result from
'find_free_diskname' prefixed with "/" if $scfg->{path} exists.
Otherwise it will only return the r
a few small things inline
On 10/25/21 16:01, Dominik Csapak wrote:
Signed-off-by: Dominik Csapak
---
pveceph.adoc | 49 +
1 file changed, 37 insertions(+), 12 deletions(-)
diff --git a/pveceph.adoc b/pveceph.adoc
index aa7a20f..cceb1ca 100644
On 25/10/2021 16:24, Dominik Csapak wrote:
> 'wbytes' is for writes, but we accidentally added the value to 'diskread'
> which left 'diskwrite' always zero
>
> Signed-off-by: Dominik Csapak
> ---
> src/PVE/CGroup.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
On 25/10/2021 16:17, Dominik Csapak wrote:
> both patches LGTM, commit message could have used some more info
> (like which fields were added, etc.) but no big problem
yeah, mentioning that instead of three or so selected columns all are now
dumped and some reasoning for doing that (after all #363
On 25/10/2021 11:31, Dominik Csapak wrote:
> Explain the use-case, the difference to normal binds, and give an
> example that contains all features that can be used with explanations.
>
> Signed-off-by: Dominik Csapak
> ---
> changes from v1:
> * rewrite of textual introduction to include more de
this is wrong and does nothing. see
https://www.kernel.org/doc/html/v5.11/admin-guide/kernel-parameters.html?highlight=amd_iommu
Signed-off-by: Dominik Csapak
---
qm-pci-passthrough.adoc | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/qm-pci-passthrough.adoc b/qm-pci-pa
note that one must enable IOMMU support in the BIOS/UEFI.
Signed-off-by: Dominik Csapak
---
qm-pci-passthrough.adoc | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/qm-pci-passthrough.adoc b/qm-pci-passthrough.adoc
index dfc3d6e..edaa01f 100644
--- a/qm-pci-passthrough.ad
27 matches
Mail list logo
