Re: [pve-devel] applied: [PATCH manager 1/2] ui: storage: change CIFS to SMB/CIFS

2021-10-04 Thread Aaron Lauterer
On 10/5/21 07:41, Thomas Lamprecht wrote: On 04.10.21 12:25, Aaron Lauterer wrote: This will hopefully help people to find the needed storage as not everyone will be aware of the fact that CIFS is also a name used for it (technically it was only SMB v1). Signed-off-by: Aaron Lauterer ---

[pve-devel] applied: [PATCH v3 manager] ceph install: improve ceph install checks during installation

2021-10-04 Thread Thomas Lamprecht
On 04.10.21 10:02, Aaron Lauterer wrote: > Adding a flag file during the Ceph installation helps to cover the time > span in which the binary is already present but the installation not yet > done. > > The most noticeable effect is that the 'Next' button in the GUI will > only become active once t

[pve-devel] applied: [PATCH manager 1/2] ui: storage: change CIFS to SMB/CIFS

2021-10-04 Thread Thomas Lamprecht
On 04.10.21 12:25, Aaron Lauterer wrote: > This will hopefully help people to find the needed storage as not > everyone will be aware of the fact that CIFS is also a name used for it > (technically it was only SMB v1). > > Signed-off-by: Aaron Lauterer > --- > www/manager6/Utils.js | 2 +- > 1

[pve-devel] applied: [PATCH v3 manager 3/3] ui: add support for adding TPM devices

2021-10-04 Thread Thomas Lamprecht
On 04.10.21 17:29, Stefan Reiter wrote: > Inspired by HDEfi for efidisks. Extends the DiskStorageSelector to allow > hiding the format, since tpmstate can only be stored in 'raw' format > (even on directory storages). > > Signed-off-by: Stefan Reiter > --- > www/manager6/Makefile

[pve-devel] applied: [PATCH v3 qemu-server 2/3] fix #3075: add TPM v1.2 and v2.0 support via swtpm

2021-10-04 Thread Thomas Lamprecht
On 04.10.21 17:29, Stefan Reiter wrote: > Starts an instance of swtpm per VM in it's systemd scope, it will > terminate by itself if the VM exits, or be terminated manually if > startup fails. > > Before first use, a TPM state is created via swtpm_setup. State is > stored in a 'tpmstate0' volume,

Re: [pve-devel] [PATCH qemu-server] qemu-agent: allow hotplug of fstrim_cloned_disk option.

2021-10-04 Thread Thomas Lamprecht
On 03.09.21 08:36, Alexandre Derumier wrote: > This option don't have any impact on device itself. > > Signed-off-by: Alexandre Derumier > --- > PVE/QemuServer.pm | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index cc73af8.

[pve-devel] applied: [PATCH v3 storage 1/3] import: don't check for 1K aligned size

2021-10-04 Thread Thomas Lamprecht
On 04.10.21 17:29, Stefan Reiter wrote: > TPM state disks on directory storages may have completely unaligned > sizes, this check doesn't make sense for them. > > This appears to just be a (weak) safeguard and not serve an actual > functional purpose, so simply get rid of it to allow migration of

Re: [pve-devel] [PATCH container] fix creating unmanaged containers

2021-10-04 Thread Thomas Lamprecht
On 04.10.21 16:55, Oguz Bektas wrote: > $keynames was not a hash reference since nothing was returned by > ssh_host_key_types_to_generate for unmanaged containers, this causes the > post_create_hook to fail and no container is created. While $keynames is not a hash ref it isn't supposed to always

[pve-devel] [PATCH v3 0/3] Initial TPM support for VMs

2021-10-04 Thread Stefan Reiter
Makes Windows 11 (test build) happy: https://i.imgur.com/kZ0Mpnr.jpeg Tested under Linux as well, works with (updated) OVMF and SeaBIOS, though SeaBIOS requires clearing via the BIOS setup screen and may not support all features it seems (e.g. Windows shows the TPM, but doesn't allow BitLocker, pr

[pve-devel] [PATCH v3 qemu-server 2/3] fix #3075: add TPM v1.2 and v2.0 support via swtpm

2021-10-04 Thread Stefan Reiter
Starts an instance of swtpm per VM in it's systemd scope, it will terminate by itself if the VM exits, or be terminated manually if startup fails. Before first use, a TPM state is created via swtpm_setup. State is stored in a 'tpmstate0' volume, treated much the same way as an efidisk. It is migr

[pve-devel] [PATCH v3 storage 1/3] import: don't check for 1K aligned size

2021-10-04 Thread Stefan Reiter
TPM state disks on directory storages may have completely unaligned sizes, this check doesn't make sense for them. This appears to just be a (weak) safeguard and not serve an actual functional purpose, so simply get rid of it to allow migration of TPM state. Signed-off-by: Stefan Reiter --- PVE

[pve-devel] [PATCH v3 manager 3/3] ui: add support for adding TPM devices

2021-10-04 Thread Stefan Reiter
Inspired by HDEfi for efidisks. Extends the DiskStorageSelector to allow hiding the format, since tpmstate can only be stored in 'raw' format (even on directory storages). Signed-off-by: Stefan Reiter --- www/manager6/Makefile| 1 + www/manager6/Utils.js|

[pve-devel] [PATCH container] fix creating unmanaged containers

2021-10-04 Thread Oguz Bektas
$keynames was not a hash reference since nothing was returned by ssh_host_key_types_to_generate for unmanaged containers, this causes the post_create_hook to fail and no container is created. fix by returning an empty hash so that $keynames can be a hashref and processed accordingly. also dropped

[pve-devel] [PATCH manager 2/2] ui: lxc options: change CIFS to SMB/CIFS

2021-10-04 Thread Aaron Lauterer
For consistency with the Storage panel and it might also help people to make the connection if they are not aware that CIFS is a name used for SMB. Signed-off-by: Aaron Lauterer --- www/manager6/lxc/FeaturesEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/

[pve-devel] [PATCH manager 1/2] ui: storage: change CIFS to SMB/CIFS

2021-10-04 Thread Aaron Lauterer
This will hopefully help people to find the needed storage as not everyone will be aware of the fact that CIFS is also a name used for it (technically it was only SMB v1). Signed-off-by: Aaron Lauterer --- www/manager6/Utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[pve-devel] applied: [PATCH v4 http-server 1/1] anyevent: move unlink from http-server to endpoint

2021-10-04 Thread Thomas Lamprecht
On 31.08.21 12:16, Lorenz Stechauner wrote: > any uploaded file has to be deleted by the corrosponding > endpoint. the file upload was only used by the 'upload to > storage' feature in pve. > > this change allows the endpoint to delete the file itself, > making the old and racey`sleep 1` (waiting

[pve-devel] [PATCH v3 manager] ceph install: improve ceph install checks during installation

2021-10-04 Thread Aaron Lauterer
Adding a flag file during the Ceph installation helps to cover the time span in which the binary is already present but the installation not yet done. The most noticeable effect is that the 'Next' button in the GUI will only become active once the installation is actually finished and not earlier.

[pve-devel] [PATCH manager v2] ui: resourcetree: move guest position on template creation

2021-10-04 Thread Dominik Csapak
we sort templates at the end normally, but if we convert a guest to a template, it was not moved in the tree add it to the list of attributes that are checked for a move Signed-off-by: Dominik Csapak --- changes from v1: * create an array where we append the additional attributes to check inst

[pve-devel] applied: [PATCH qemu-server 2/2] api: template: invert lock and fork

2021-10-04 Thread Thomas Lamprecht
On 10.09.21 09:48, Fabian Grünbichler wrote: > like for other API calls, repeat the cheap checks done for early abort > before forking and without locks after forking and obtaining the lock, > and only hold the flock in the forked worker instead of across the fork. > > Signed-off-by: Fabian Grünbi

[pve-devel] applied: [PATCH qemu-server 1/2] api: return UPID in template call

2021-10-04 Thread Thomas Lamprecht
On 10.09.21 09:48, Fabian Grünbichler wrote: > as reported on the forum, this is currently missing, making status > queries via the API impossible: > > https://forum.proxmox.com/threads/create-vm-via-api-interface.95942/#post-416084 > > Signed-off-by: Fabian Grünbichler > --- > PVE/API2/Qemu.pm

[pve-devel] applied: [PATCH pve-kernel-meta] proxmox-boot: fix #3632 copy kernel+initrd unconditionally

2021-10-04 Thread Thomas Lamprecht
On 23.09.21 10:43, Stoiko Ivanov wrote: > do not use the -u (update) flag when copying kernel images and inird > from /boot to the ESPs: > * the ESPs are formatted with vfat, which has a 2 second precision for > mtime (`linux/fs/fat/misc.c` - `fat_truncate_time`) > * cp -u compares the mtimes of

[pve-devel] applied: [PATCH cluster v2 1/1] dc.cfg: Add notes to datacenter config

2021-10-04 Thread Thomas Lamprecht
On 22.09.21 12:42, Dominik Csapak wrote: > From: Dominic Jäger > > Similar to notes for nodes. > datacenter.cfg normally uses key-value pairs defined in the schema. > We bypass this to allow potentially long comments at the top. > > Signed-off-by: Dominic Jäger > Signed-off-by: Dominik Csapak

[pve-devel] partially-applied: [PATCH manager v2 00/12] multi tab disk panel & multi disk wizard

2021-10-04 Thread Thomas Lamprecht
On 22.09.21 11:27, Dominik Csapak wrote: > this series is intended to replace dominics and my previous attempts > at this [0][1][2] > > splits the bandwidth options into their on tab on the disk panel and > introduces a 'MultiHDEdit' panel which creates/deletes the > HDEdit panels on demand. > >