Re: [pve-devel] building pve-docs - Can't locate PVE/RESTHandler.pm

2021-09-17 Thread Dietmar Maurer
> I don't know where to find the PVE::RESTHandler module. Any (working) PVE installation should have that installed... ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] building pve-docs - Can't locate PVE/RESTHandler.pm

2021-09-17 Thread Georges Martin
Have you run this command on a PVE server ? > Le 17 sept. 2021 à 16:58, Sylvain Faivre a écrit : > > Hello, > > I am planning to submit patches for the Proxmox docs, following my post at > https://forum.proxmox.com/threads/some-notes-and-questions-about-proxmox-cluster-networking.96001/ > > I

[pve-devel] building pve-docs - Can't locate PVE/RESTHandler.pm

2021-09-17 Thread Sylvain Faivre
Hello, I am planning to submit patches for the Proxmox docs, following my post at https://forum.proxmox.com/threads/some-notes-and-questions-about-proxmox-cluster-networking.96001/ I found the pve-docs git repo, and read through https://pve.proxmox.com/wiki/Developer_Documentation In order to se

[pve-devel] [RFC storage 2/6] add generalized functions to manage volume attributes

2021-09-17 Thread Fabian Ebner
replacing the ones for handling notes. The generic implementation in Plugin.pm will fall back to the methods for notes to ensure backwards compatibility with external plugins. This is mainly done to avoid the need to add new methods every time a new attribute is added. Not adding a timeout parame

[pve-devel] [RFC storage 4/6] fix #3307: make it possible to set protection for backups

2021-09-17 Thread Fabian Ebner
A protected backup is not removed by free_image and ignored when pruning. The protection_file_path function is introduced in Storage.pm, so that it can also be used by vzdump itself and in archive_remove. Signed-off-by: Fabian Ebner --- Needs an APIAGE+APIVER bump (can be covered by the one for

[pve-devel] [RFC storage 6/6] pbs: integrate support for protected

2021-09-17 Thread Fabian Ebner
free_image doesn't need to check for protection, because that will happen on the server. Getting/updating notes has also been refactored to re-use the code for the PBS api calls. Signed-off-by: Fabian Ebner --- Needs new external dependency for strptime (libposix-strptime-perl), because it's no

[pve-devel] [RFC storage 5/6] prune: mark renamed and protected backups differently

2021-09-17 Thread Fabian Ebner
While it makes no difference for pruning itself, protected backups are additionally protected against removal. Avoid the potential to confuse the two. Also update the description for the API return value and add an enum constraint. Signed-off-by: Fabian Ebner --- PVE/API2/Storage/PruneBackups.pm

[pve-devel] [PATCH storage 3/6] prune mark: preserve additional information for the keep-all case

2021-09-17 Thread Fabian Ebner
Currently, if an entry is already marked as 'protected'. Signed-off-by: Fabian Ebner --- This makes adding the test in the next patch much simpler, because the expected mark of a protected backup can be hardcoded as 'protected'. But even without that, it makes sense to preserve the more specific

[pve-devel] [RFC storage/manager] fix #3307: allow backups to be marked as protected

2021-09-17 Thread Fabian Ebner
Protected bacukps cannot be removed accidentally and will be ignored for pruning. A .protected file serves as a protection marker for file-based storages. Still missing: GUI integration The pve-manager patch depends on the pve-storage patches. To work, the PBS integration needs Dominik's patch

[pve-devel] [RFC manager 1/1] vzdump: skip protected backups for dumpdir pruning

2021-09-17 Thread Fabian Ebner
Keeps the behavior consistent with what happens for storages. It also is required to not get into conflict with the check in archive_remove, i.e. pruning here marks a backup as 'remove' and then archive_remove complains that it's protected. Signed-off-by: Fabian Ebner --- I'm noticing now that o

[pve-devel] [PATCH storage 1/6] dir plugin: update notes: don't attempt to remove non-existent notes

2021-09-17 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- PVE/Storage/DirPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Storage/DirPlugin.pm b/PVE/Storage/DirPlugin.pm index 2267f11..0423e5f 100644 --- a/PVE/Storage/DirPlugin.pm +++ b/PVE/Storage/DirPlugin.pm @@ -109,7 +109,7 @@ sub upda

Re: [pve-devel] [PATCH v2 proxmox-backup 06/10] sync: add group filtering

2021-09-17 Thread Dominik Csapak
On 9/15/21 3:41 PM, Fabian Grünbichler wrote: like for manual pulls, but persisted in the sync job config and visible in the relevant GUI parts. Signed-off-by: Fabian Grünbichler --- Notes: GUI is read-only for now (and defaults to no filtering on creation), as this is a rather adv