[pve-devel] applied series: [PATCH container/manager v2] default nesting for unpriv containers in ui

applied series On Wed, Aug 04, 2021 at 12:51:06PM +0200, Dominik Csapak wrote: > since many modern containers need the nesting feature to work properly > (thanks systemd...), we add a checkbox that is on by default > (and disables with unprivileged, since nested privileged containers > are not ver

[pve-devel] [PATCH container v2 1/3] add old config and unprivileged to check_ct_modify_config_perm

we'll need that for checking the features more granularly for it to work correctly, we have to move the permission checks into the 'lock_config' sub, since we now also need to check the current config and it could change between the permission check and the lock Signed-off-by: Dominik Csapak ---

[pve-devel] [PATCH manager v2 2/2] ui: lxc/CreateWizard: add a 'nesting' checkbox and enable it by default

but only enable the field for unprivileged containers. We do this, since newer containers need this feature for basic functions. Signed-off-by: Dominik Csapak --- www/manager6/lxc/CreateWizard.js | 10 ++ 1 file changed, 10 insertions(+) diff --git a/www/manager6/lxc/CreateWizard.js b/w

[pve-devel] [PATCH container/manager v2] default nesting for unpriv containers in ui

since many modern containers need the nesting feature to work properly (thanks systemd...), we add a checkbox that is on by default (and disables with unprivileged, since nested privileged containers are not very secure) to do that, we first have to loosen the nesting constraints in the api a bit.

[pve-devel] [PATCH container v2 3/3] skip features when restoring an unprivileged container as privileged

Signed-off-by: Dominik Csapak --- src/PVE/LXC/Create.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/src/PVE/LXC/Create.pm b/src/PVE/LXC/Create.pm index e8233b6..eea7c0d 100644 --- a/src/PVE/LXC/Create.pm +++ b/src/PVE/LXC/Create.pm @@ -320,6 +320,11 @@ sub sanitize_and_merge_config {

[pve-devel] [PATCH container v2 2/3] allow nesting to be changed for VM.Allocate on unprivileged containers

instead of it being root only Signed-off-by: Dominik Csapak --- src/PVE/LXC.pm | 45 +++-- 1 file changed, 43 insertions(+), 2 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 32a2127..dbdec23 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.p

[pve-devel] [PATCH manager v2 1/2] ui: lxc/Options: allow opening features window for VM.Allocate

since VM.Allocate can at least change the nesting value Signed-off-by: Dominik Csapak --- www/manager6/lxc/Options.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/lxc/Options.js b/www/manager6/lxc/Options.js index b64d03a9..f2661dfc 100644 --- a/www/manager6/l

Re: [pve-devel] [PATCH container 2/2] allow nesting to be changed for VM.Allocate on unprivileged containers

Am 03.08.21 um 14:29 schrieb Dominik Csapak: instead of it being root only Signed-off-by: Dominik Csapak --- src/PVE/LXC.pm | 43 +-- 1 file changed, 41 insertions(+), 2 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 32a2127..abe8ac3

Re: [pve-devel] [PATCH container 2/2] allow nesting to be changed for VM.Allocate on unprivileged containers

On Tue, Aug 03, 2021 at 02:29:52PM +0200, Dominik Csapak wrote: > instead of it being root only > > Signed-off-by: Dominik Csapak > --- > src/PVE/LXC.pm | 43 +-- > 1 file changed, 41 insertions(+), 2 deletions(-) > > diff --git a/src/PVE/LXC.pm b/src/PVE

Re: [pve-devel] [PATCH container 1/2] add old config and unprivileged to check_ct_modify_config_perm

Am 04.08.21 um 10:47 schrieb Fabian Ebner: Am 03.08.21 um 14:29 schrieb Dominik Csapak: we'll need that for checking the features more granularly Signed-off-by: Dominik Csapak ---   src/PVE/API2/LXC.pm    | 6 --   src/PVE/API2/LXC/Config.pm | 9 ++---   src/PVE/LXC.pm |

Re: [pve-devel] [PATCH container 1/2] add old config and unprivileged to check_ct_modify_config_perm

Am 03.08.21 um 14:29 schrieb Dominik Csapak: we'll need that for checking the features more granularly Signed-off-by: Dominik Csapak --- src/PVE/API2/LXC.pm| 6 -- src/PVE/API2/LXC/Config.pm | 9 ++--- src/PVE/LXC.pm | 2 +- 3 files changed, 11 insertions(+), 6

Re: [pve-devel] [PATCH container 1/2] add old config and unprivileged to check_ct_modify_config_perm

On Tue, Aug 03, 2021 at 02:29:51PM +0200, Dominik Csapak wrote: > we'll need that for checking the features more granularly > > Signed-off-by: Dominik Csapak > --- > src/PVE/API2/LXC.pm| 6 -- > src/PVE/API2/LXC/Config.pm | 9 ++--- > src/PVE/LXC.pm | 2 +- > 3 files

Re: [pve-devel] [PATCH v2 storage] storage/plugin: factoring out regex for backup extension rey

On Wed, Aug 04, 2021 at 09:56:14AM +0200, Lorenz Stechauner wrote: > > On 03.08.21 09:15, Wolfgang Bumiller wrote: > > On Mon, Aug 02, 2021 at 12:52:36PM +0200, Lorenz Stechauner wrote: > > > Signed-off-by: Lorenz Stechauner > > > --- > > > changes to v1: > > > * factored $compressor_extension_re

Re: [pve-devel] [PATCH v2 storage] storage/plugin: factoring out regex for backup extension rey

On 03.08.21 09:15, Wolfgang Bumiller wrote: On Mon, Aug 02, 2021 at 12:52:36PM +0200, Lorenz Stechauner wrote: Signed-off-by: Lorenz Stechauner --- changes to v1: * factored $compressor_extension_re out of $backup_extension_re should now be less confusing not sure about less confusing..

Re: [pve-devel] [PATCH v1 storage 1/9] storage: expose find_free_diskname

Am 03.08.21 um 16:20 schrieb Aaron Lauterer: On 8/2/21 2:56 PM, Fabian Ebner wrote: Am 19.07.21 um 16:52 schrieb Aaron Lauterer: We do not expose the parameter 'add_fmt_suffix' used by the internal implemantion of 'find_free_diskname'. This is something only the plugins themselves know but ca