[pve-devel] applied: [PATCH proxmox-acme] plugin-caller: add missing methods from acme.sh

2021-07-16 Thread Thomas Lamprecht
On 15.07.21 15:56, Stoiko Ivanov wrote: > As reported in our community forum [0] certain dns plugins use code > from `acme.sh`, which is currently not in our proxmox-acme. > > I initially only added _sign and it's callees, but then though about > trying to get all missing methods somehow (only res

[pve-devel] applied: [PATCH proxmox-acme] plugin-caller: make no-ops always successful

2021-07-16 Thread Thomas Lamprecht
On 16.07.21 15:43, Stoiko Ivanov wrote: > proxmox-acme is used to call the dns-plugins from acme.sh and has the > config editing (saving/clearing) turned int no-ops. > > bash's `return` statement w/o argument returns the value of the last > executed command (the one before our no-op method was cal

Re: [pve-devel] [RFC qemu-server 2/2] fix #3075: add TPM v1.2 and v2.0 support via swtpm

2021-07-16 Thread alexandre derumier
Hi, I have found old post where a nvram device (using a qcow2 or raw file as backend) was used with tpm https://libvir-list.redhat.narkive.com/eOrJPdYX/libvirt-how-libvirt-address-qemu-command-line-args also dev doc from 2011 mention it https://wiki.qemu.org/Features/TPM (I don't have tested to

[pve-devel] [PATCH manager v3 5/5] ui: remove PVE.dc.AuthEditBase window

2021-07-16 Thread Dominik Csapak
this is not needed anymore since we now use Proxmox.window.AuthEditBase Signed-off-by: Dominik Csapak --- www/manager6/dc/AuthEditBase.js | 91 - 1 file changed, 91 deletions(-) diff --git a/www/manager6/dc/AuthEditBase.js b/www/manager6/dc/AuthEditBase.js index

[pve-devel] [PATCH manager v3 4/5] ui: use AuthView and authSchema from widget-toolkit

2021-07-16 Thread Dominik Csapak
* moves the authSchema to the overrideAuthSchema call so that it can be found in Proxmox.Utils.authSchema instead. * changes the dc/AuthView to be a subclass of Proxmox.panel.AuthView with the necesary changes (onlinehelp, columns, etc.) * changes all calls from PVE.Utils.authSchema to Proxmox.

[pve-devel] [PATCH manager v3 3/5] ui: move sdn schemas to Schema

2021-07-16 Thread Dominik Csapak
but dropped the 'Schema' postfix Signed-off-by: Dominik Csapak --- www/manager6/Schema.js | 91 ++ www/manager6/Utils.js | 101 ++--- www/manager6/sdn/ControllerView.js | 4 +- www/manager6/sdn/DnsView.js| 4 +-

[pve-devel] [PATCH manager v3 2/5] ui: move Utils.storageSchema to Schema.storageTypes

2021-07-16 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/Schema.js | 99 www/manager6/Utils.js | 102 + www/manager6/dc/StorageView.js | 4 +- 3 files changed, 102 insertions(+), 103 deletions(-) diff --git a/www/manager6

[pve-devel] [PATCH manager v3 1/5] ui: add Schema.js

2021-07-16 Thread Dominik Csapak
this will be the place for all schemas for pve Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 1 + www/manager6/Schema.js | 4 2 files changed, 5 insertions(+) create mode 100644 www/manager6/Schema.js diff --git a/www/manager6/Makefile b/www/manager6/Makefile index 75d355a5..

[pve-devel] applied: [PATCH proxmox-apt 1/3] code cleanup: use contains()

2021-07-16 Thread Thomas Lamprecht
On 05.07.21 15:50, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > src/repositories/file.rs | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://li

[pve-devel] [PATCH pve-eslint] use worker_threads for linting

2021-07-16 Thread Dominik Csapak
instead linting all files in the main thread, use worker threads for that (4 by default) and add the '-t' switch to able to control that since nodejs always wants a module/script to load for a thread, give a small script that load the file itself a basic benchmark of eslint of pve-manager showed

[pve-devel] [PATCH proxmox-acme] plugin-caller: make no-ops always successful

2021-07-16 Thread Stoiko Ivanov
proxmox-acme is used to call the dns-plugins from acme.sh and has the config editing (saving/clearing) turned int no-ops. bash's `return` statement w/o argument returns the value of the last executed command (the one before our no-op method was called) (see `help return` in bash). This leads to un

[pve-devel] [PATCH v4 manager] api: apt: repos: fix interfacing with perlmod

2021-07-16 Thread Fabian Ebner
Using pvesh create /nodes/pve701/apt/repositories --path "/etc/apt/sources.list" --index 0 --enabled 1 reliably leads to error: invalid type: string "0", expected usize Coerce to int to avoid this. I was not able to trigger the issue with the "enabled" option being a string here (in PM

Re: [pve-devel] [PATCH v3 manager] api: apt: repos: fix interfacing with perlmod

2021-07-16 Thread Fabian Ebner
Just noticed a shorter/cleaner way to do it. I'll send a v4, sorry for the noise. Am 16.07.21 um 14:57 schrieb Fabian Ebner: Using pvesh create /nodes/pve701/apt/repositories --path "/etc/apt/sources.list" --index 0 --enabled 1 reliably leads to error: invalid type: string "0", e

[pve-devel] [PATCH v3 manager] api: apt: repos: fix interfacing with perlmod

2021-07-16 Thread Fabian Ebner
Using pvesh create /nodes/pve701/apt/repositories --path "/etc/apt/sources.list" --index 0 --enabled 1 reliably leads to error: invalid type: string "0", expected usize Coerce to int to avoid this. I was not able to trigger the issue with the "enabled" option being a string here (in PM

[pve-devel] [PATCH proxmox-apt 2/2] standard repo detection: handle alternative URI for PVE repos

2021-07-16 Thread Fabian Ebner
For PVE, URIs without the final "/pve" are also valid. Reported in the community forum: https://forum.proxmox.com/threads/pve-7-0-9-no-proxmox-ve-repository-enabled.92427/ Signed-off-by: Fabian Ebner --- src/repositories/repository.rs | 19 +- src/repositories/standard.rs

[pve-devel] [PATCH proxmox-apt 1/2] bump proxmox dependency

2021-07-16 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- Cargo.toml | 2 +- debian/control | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index d1ddccb..4bcf9c4 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -20,5 +20,5 @@ path = "src/lib.rs" anyhow = "1.0" once_ce

[pve-devel] [PATCH proxmox-apt 0/2] fix detection for PVE

2021-07-16 Thread Fabian Ebner
For PVE, the final "/pve" is in the URI is optional. Fabian Ebner (2): bump proxmox dependency standard repo detection: handle alternative URI for PVE repos Cargo.toml | 2 +- debian/control | 8 ++--- src/repositories/repository.

Re: [pve-devel] [PATCH common 2/2] interfaces: improve bridge_fd handling

2021-07-16 Thread Thomas Lamprecht
On 16.07.21 09:40, Fabian Grünbichler wrote: > and ignore values with a warning that are outside of the kernels > expected range. > > Signed-off-by: Fabian Grünbichler > --- > src/PVE/INotify.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > applied, but .. > diff --git a/src/PV

[pve-devel] applied: [PATCH common 1/2] fix #2831: never set bridge_fd to 0 with STP on

2021-07-16 Thread Thomas Lamprecht
On 16.07.21 09:40, Fabian Grünbichler wrote: > it's an invalid combination that causes the network reload/setup to > fail. unfortunately, this is not caught by ifupdown2 itself, but only > rejected by the kernel with ERANGE over netlink. > > Signed-off-by: Fabian Grünbichler > --- > > Notes: >

Re: [pve-devel] [RFC 0/2] Initial TPM support for VMs

2021-07-16 Thread Thomas Lamprecht
On 15.07.21 16:23, Stefan Reiter wrote: > Design decision: 'swtpm' requires a *directory* per VM to store data, the > files > themselves are rather small (8.5kB for an initialized TPM 2.0 w/ BitLocker > enabled). To allow for easier HA I went with a path in '/etc/pve/priv' for > now, > but that c

[pve-devel] [PATCH common 2/2] interfaces: improve bridge_fd handling

2021-07-16 Thread Fabian Grünbichler
and ignore values with a warning that are outside of the kernels expected range. Signed-off-by: Fabian Grünbichler --- src/PVE/INotify.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 4f682be..ad45cd2 100644 --- a/src/PVE/INo

[pve-devel] [PATCH common 1/2] fix #2831: never set bridge_fd to 0 with STP on

2021-07-16 Thread Fabian Grünbichler
it's an invalid combination that causes the network reload/setup to fail. unfortunately, this is not caught by ifupdown2 itself, but only rejected by the kernel with ERANGE over netlink. Signed-off-by: Fabian Grünbichler --- Notes: these range checks are there in the kernel since 2011.. sr

[pve-devel] [PATCH common 1/2] fix #2831: never set bridge_fd to 0 with STP on

2021-07-16 Thread Fabian Grünbichler
it's an invalid combination that causes the network reload/setup to fail. unfortunately, this is not caught by ifupdown2 itself, but only rejected by the kernel with ERANGE over netlink. Signed-off-by: Fabian Grünbichler --- Notes: these range checks are there in the kernel since 2011.. sr