[pve-devel] [PATCH v2 manager] api: apt: repos: fix interfacing with perlmod

2021-07-14 Thread Fabian Ebner
Using pvesh create /nodes/pve701/apt/repositories --path "/etc/apt/sources.list" --index 0 --enabled 1 reliably leads to error: invalid type: string "0", expected usize Coerce to int to avoid this. I was not able to trigger the issue with the "enabled" option here (in PMG I was), but b

[pve-devel] [PATCH manager] api: apt: repos: fix interfacing with perlmod

2021-07-14 Thread Fabian Ebner
Using pvesh create /nodes/pve701/apt/repositories --path "/etc/apt/sources.list" --index 0 --enabled 1 reliably leads to error: invalid type: string "0", expected usize Coerce to int to avoid this. I was not able to trigger the issue with the "enabled" option here (in PMG I was), but b

Re: [pve-devel] [PATCH manager] api: apt: repos: fix interfacing with perlmod

2021-07-14 Thread Fabian Ebner
Am 13.07.21 um 10:19 schrieb Fabian Ebner: Using pvesh create /nodes/pve701/apt/repositories --path "/etc/apt/sources.list" --index 0 --enabled 1 reliably leads to error: invalid type: string "0", expected usize Coerce to int to avoid this. I was not able to trigger the issue with

[pve-devel] [PATCH] fix compressor loop-order

2021-07-14 Thread Stoiko Ivanov
commit dbac106eb6e3cff405e57c0bb6a6dbe3cf307c52 introduced a flaw in the logic - once a file is downloaded the 'last;' statement exited the inner loop iterating over the compoentens instead of the outer one iterating over the compressors. since both do not inherently depend on each other simply sw

[pve-devel] applied: [PATCH] try all available compressors for Packages

2021-07-14 Thread Thomas Lamprecht
On 14.07.21 16:49, Stoiko Ivanov wrote: > Some repositories (e.g. debian-security) only offer .xz compressed > Packages, others (e.g. promox repositories) only .gz compressed ones. > > Make the compressors an array and try them in order until successful > > Signed-off-by: Stoiko Ivanov > --- > N

Re: [pve-devel] [PATCH] try all available compressors for Packages

2021-07-14 Thread Thomas Lamprecht
On 14.07.21 16:49, Stoiko Ivanov wrote: > Some repositories (e.g. debian-security) only offer .xz compressed > Packages, others (e.g. promox repositories) only .gz compressed ones. > > Make the compressors an array and try them in order until successful > > Signed-off-by: Stoiko Ivanov > --- > N

[pve-devel] applied: [PATCH ifupdown2 0/2] update to 3.1.0

2021-07-14 Thread Thomas Lamprecht
On 14.07.21 09:52, Alexandre Derumier wrote: > This patches serie update ifupdown2 to 3.1.0. > > > Alexandre Derumier (2): > update patches > bump version to 3.1.0-1+pve1 > > debian/changelog | 6 ++ > .../pve/0009-allow-vlan-tag-inside-vxlan-tunne

[pve-devel] [PATCH] try all available compressors for Packages

2021-07-14 Thread Stoiko Ivanov
Some repositories (e.g. debian-security) only offer .xz compressed Packages, others (e.g. promox repositories) only .gz compressed ones. Make the compressors an array and try them in order until successful Signed-off-by: Stoiko Ivanov --- Note: best viewed with `-w` Was not too sure about the co

[pve-devel] [PATCH pve-manager 1/1] ui: node: repos: add online help

2021-07-14 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- Depends on https://lists.proxmox.com/pipermail/pmg-devel/2021-July/001815.html to work correctly, but no hard dependency. www/manager6/node/Config.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js ind

[pve-devel] [PATCH manager v2 2/3] ui: use AuthView and authSchema from widget-toolkit

2021-07-14 Thread Dominik Csapak
* moves the authSchema to the overrideAuthSchema call so that it can be found in Proxmox.Utils.authSchema instead. * changes the dc/AuthView to be a subclass of Proxmox.panel.AuthView with the necesary changes (onlinehelp, columns, etc.) * changes all calls from PVE.Utils.authSchema to Proxmox.

[pve-devel] [PATCH manager v2 3/3] ui: remove PVE.dc.AuthEditBase window

2021-07-14 Thread Dominik Csapak
this is not needed anymore since we now use Proxmox.window.AuthEditBase Signed-off-by: Dominik Csapak --- www/manager6/dc/AuthEditBase.js | 91 - 1 file changed, 91 deletions(-) diff --git a/www/manager6/dc/AuthEditBase.js b/www/manager6/dc/AuthEditBase.js index

[pve-devel] [PATCH manager v2 1/3] ui: add Schema singleton

2021-07-14 Thread Dominik Csapak
and override the Proxmox.Schema.authDomains in its constructor Signed-off-by: Dominik Csapak --- new in v2 www/manager6/Makefile | 1 + www/manager6/Schema.js | 53 ++ 2 files changed, 54 insertions(+) create mode 100644 www/manager6/Schema.js diff --

[pve-devel] [PATCH docs v2] pveceph: update pgcalc url

2021-07-14 Thread Dominik Csapak
currently the pgcalc tool is only available via waybackmachine of archive.org Signed-off-by: Dominik Csapak --- changes from v1: * link changed from old.ceph.com to archive.org since old.ceph.com is not there anymore... pveceph.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [pve-devel] ifupdown2 "bridge_set_static_mac_from_port" policy

2021-07-14 Thread alexandre derumier
ok, I have done some tests. /etc/network/ifupdown2/policy.d/bridgemac.json { "bridge": { "module_globals": { "bridge_set_static_mac_from_port": "yes" } } test1 - auto vmbr4 iface vmbr4 inet manual bridge-ports eno4 eno3 bridge-stp off b

[pve-devel] applied: [PATCH common] fix #3527: cgroup: drop file buffers from memory usage

2021-07-14 Thread Thomas Lamprecht
On 14.07.21 09:42, Wolfgang Bumiller wrote: > matches the behavior of lxcfs > > Signed-off-by: Wolfgang Bumiller > --- > src/PVE/CGroup.pm | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > applied, thanks! ___ pve-devel mailing list

Re: [pve-devel] ifupdown2 "bridge_set_static_mac_from_port" policy

2021-07-14 Thread alexandre derumier
> But if one would add another bridge port or switch order of existing > ones, and then do a > `ifreload -a` it could change the bridge MAC address? I mean, it > happens in the `up_bridge` > function, not sure if that is called on reload or just when really > doing something like > `ifdown vmbr0; i

[pve-devel] [PATCH manager 2/5 v2] apt update: Inform users about missing subscriptions

2021-07-14 Thread Dominic Jäger
We assume that users want update notifications for production systems. Those systems should also have an active subscription. Signed-off-by: Dominic Jäger --- v2: new PVE/API2/APT.pm | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/PVE/API2/APT.pm b/PVE/API2/

[pve-devel] [PATCH manager 4/5 v2] dc options: Add apt notifications GUI checkbox

2021-07-14 Thread Dominic Jäger
Default value like pveupdate: Assume users with subscriptions want notifications Signed-off-by: Dominic Jäger --- v2: default depends on subscription status www/manager6/dc/OptionView.js | 37 +++ 1 file changed, 37 insertions(+) diff --git a/www/manager6/dc/Opt

[pve-devel] [PATCH manager 5/5 v2] dc options: Allow both package_update options

2021-07-14 Thread Dominic Jäger
When opened for the first time (undefined value in datacenter.cfg) we should allow setting both options yes and no for the package_update checkbox. Signed-off-by: Dominic Jäger --- v2: new www/manager6/dc/OptionView.js | 11 +++ 1 file changed, 11 insertions(+) diff --git a/www/manager

[pve-devel] [PATCH manager 3/5 v2] Close #1295: Make apt notifications configurable

2021-07-14 Thread Dominic Jäger
Users may want turn off update notifications. Depends on pve-cluster patch. Signed-off-by: Dominic Jäger --- v2: Keep defaults. I hope that I understood the idea correctly. bin/pveupdate | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/bin/pveupdate b/bin/pveupdat

[pve-devel] [PATCH cluster 1/5 v2] Close #1295: Add notifications to datacenter schema

2021-07-14 Thread Dominic Jäger
Permits controlling email notifications about package updates. Use property string for extensibility to more notification types. Signed-off-by: Dominic Jäger --- v2: Use property string data/PVE/DataCenterConfig.pm | 24 1 file changed, 24 insertions(+) diff --git a/da

[pve-devel] [PATCH container v3] fix #3516: fix unmanaged containers

2021-07-14 Thread Oguz Bektas
unmanaged containers should run the unified cgroupv2 code from our base plugin so that they can start correctly instead of erroring out Tested-by: Stoiko Ivanov Reviewed-by: Stoiko Ivanov Signed-off-by: Oguz Bektas --- v2-> v3: * added comment from stoiko's reply src/PVE/LXC/Setup.pm | 4 +++

[pve-devel] [PATCH ifupdown2 2/2] bump version to 3.1.0-1+pve1

2021-07-14 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- debian/changelog | 6 ++ 1 file changed, 6 insertions(+) diff --git a/debian/changelog b/debian/changelog index 80886f9..960cf5d 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +ifupdown2 (3.1.0-1+pve1) bullseye; urgency=medium + +

[pve-devel] [PATCH ifupdown2 0/2] update to 3.1.0

2021-07-14 Thread Alexandre Derumier
This patches serie update ifupdown2 to 3.1.0. Alexandre Derumier (2): update patches bump version to 3.1.0-1+pve1 debian/changelog | 6 ++ .../pve/0009-allow-vlan-tag-inside-vxlan-tunnel.patch | 10 +- 2 files changed, 11 insertions(+), 5

[pve-devel] [PATCH ifupdown2 1/2] update patches

2021-07-14 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- .../pve/0009-allow-vlan-tag-inside-vxlan-tunnel.patch | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/debian/patches/pve/0009-allow-vlan-tag-inside-vxlan-tunnel.patch b/debian/patches/pve/0009-allow-vlan-tag-inside-vxlan-tunne

[pve-devel] [PATCH common] fix #3527: cgroup: drop file buffers from memory usage

2021-07-14 Thread Wolfgang Bumiller
matches the behavior of lxcfs Signed-off-by: Wolfgang Bumiller --- src/PVE/CGroup.pm | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/PVE/CGroup.pm b/src/PVE/CGroup.pm index f82cbb9..21681b8 100644 --- a/src/PVE/CGroup.pm +++ b/src/PVE/CGroup.pm @@ -341,13 +341,11 @@