Re: [pve-devel] [PATCH storage] cifs: fix adding storage without username in the GUI

2021-07-05 Thread Thomas Lamprecht
On 05.07.21 20:51, Stoiko Ivanov wrote: > Currently when trying to add a CIFS storage, without providing a > username and passwort it fails while trying to mount the share, due to > the provided 'username=' parameter (w/o actual username). > > I think the issue was introduced in > 72385de9e23df9f8

[pve-devel] [PATCH qemu-server] api2: fix vmconfig_apply_pending errors handling

2021-07-05 Thread Alexandre Derumier
commit https://git.proxmox.com/?p=qemu-server.git;a=commit;h=eb5e482ded9ae6aeb6575de9441b79b90a5de531 have introduced error handling for offline pending apply, - PVE::QemuServer::vmconfig_apply_pending($vmid, $conf, $storecfg, $running); + PVE::QemuServer::vmconfig_ap

[pve-devel] [PATCH storage] cifs: fix adding storage without username in the GUI

2021-07-05 Thread Stoiko Ivanov
Currently when trying to add a CIFS storage, without providing a username and passwort it fails while trying to mount the share, due to the provided 'username=' parameter (w/o actual username). I think the issue was introduced in 72385de9e23df9f8e438d74ff783a8075f8d1560 with the extracting of sens

[pve-devel] applied series: [PATCH manger/container v2 0/2] detect containers not supporting pure cgroupv2

2021-07-05 Thread Thomas Lamprecht
On 05.07.21 12:57, Stoiko Ivanov wrote: > changes v1->v2: > incorporated Thomas' feedback (huge thx!) by: > * adding extra handling for Alpine and Devuan container (patch 2/2 for > pve-container) > * copying the helpers directly to pve6to7 to avoid versioned dependency > bumps > * refactoring t

[pve-devel] applied: [PATCH i18n] de: fix fuzzy translations

2021-07-05 Thread Thomas Lamprecht
On 05.07.21 15:25, Lorenz Stechauner wrote: > Signed-off-by: Lorenz Stechauner > --- > de.po | 57 ++--- > 1 file changed, 18 insertions(+), 39 deletions(-) > > applied, thanks! ___ pve-devel maili

[pve-devel] applied: [PATCH widget-toolkit 1/4] node/Task: remove leftover 'datastore' reference

2021-07-05 Thread Thomas Lamprecht
On 05.07.21 16:33, Dominik Csapak wrote: > this does nothing here, since the 'datastore' would be an > 'extraFilter' defined in pbs itself > > Signed-off-by: Dominik Csapak > --- > src/node/Tasks.js | 4 > 1 file changed, 4 deletions(-) > > applied series, thanks! __

[pve-devel] applied: [PATCH widget-toolkit] node/APTRepositories: make 'no pve repositories' an error

2021-07-05 Thread Thomas Lamprecht
On 05.07.21 16:06, Dominik Csapak wrote: > since we also show it as error in the node summary > > Signed-off-by: Dominik Csapak > --- > src/node/APTRepositories.js | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > applied, thanks! _

[pve-devel] [PATCH widget-toolkit 2/4] node/Tasks: deselect entries when filter changes

2021-07-05 Thread Dominik Csapak
since we use a remotefilter on a bufferedstore, the only event where we can check if the selected element is still there is the 'refresh' event. Simply deselect if the seleceted element is not in the store Signed-off-by: Dominik Csapak --- src/node/Tasks.js | 15 +++ 1 file changed,

[pve-devel] [PATCH widget-toolkit 1/4] node/Task: remove leftover 'datastore' reference

2021-07-05 Thread Dominik Csapak
this does nothing here, since the 'datastore' would be an 'extraFilter' defined in pbs itself Signed-off-by: Dominik Csapak --- src/node/Tasks.js | 4 1 file changed, 4 deletions(-) diff --git a/src/node/Tasks.js b/src/node/Tasks.js index 1fa6a83..0c5b79a 100644 --- a/src/node/Tasks.js +++

[pve-devel] [PATCH widget-toolkit 3/4] node/Task: show errors on store load

2021-07-05 Thread Dominik Csapak
since we use a buffered store on a grid, we cannot use our normal monStoreErrors from Utils (The store on the grid is a memorystore without our 'proxmox' proxy, and the store in the viewmodel is not initialized yet in the init) simply set the mask in the already existing 'updateLayout' function wh

[pve-devel] [PATCH widget-toolkit 4/4] node/Tasks: add 'clear filter' button

2021-07-05 Thread Dominik Csapak
that does two things, show the user that some filters are active (even if filters are collapsed), and let the user to reset the filters all at once Signed-off-by: Dominik Csapak --- src/node/Tasks.js | 55 +++ 1 file changed, 55 insertions(+) diff --

[pve-devel] [PATCH widget-toolkit] node/APTRepositories: make 'no pve repositories' an error

2021-07-05 Thread Dominik Csapak
since we also show it as error in the node summary Signed-off-by: Dominik Csapak --- src/node/APTRepositories.js | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js index e8f807d..e30396b 100644 --- a/src/node/APTRep

[pve-devel] [RFC proxmox-widget-toolkit 2/2] node: repos: show components warnings from the backend

2021-07-05 Thread Fabian Ebner
There's no need to show anything new in the top status, as the test and no-subscription repository already trigger a message. Signed-off-by: Fabian Ebner --- Depends on the new backend behavior. I felt like this was a good fit for using the existing info/warnings mechanism again, so I didn't go

[pve-devel] [PATCH-SERIES apt/widget-toolkit/manager] small refinements for APT repositories

2021-07-05 Thread Fabian Ebner
Limit some checks to Proxmox (and Debian) repositories where appropriate, and some other tiny improvements thrown in. The RFCs (apt patch #3 and widget-toolkit patch #2) form a logcial unit. The RFCs are also the only things requiring dependency bumps: 1. widget-toolkit patch #2 expects the new w

[pve-devel] [PATCH proxmox-apt 2/3] repository check: limit 'stable' to Proxmox and Debian origin

2021-07-05 Thread Fabian Ebner
For foreign repositories, it's a better heuristic to assume it's used in a non-dangerous (i.e. no sudden major upgrade on release day) way. Reported-by: Dominik Csapak Signed-off-by: Fabian Ebner --- src/repositories/file.rs | 57 ++-- src/repositories/mod.rs

[pve-devel] [PATCH proxmox-widget-toolkit 1/2] node: repos: properly ignore warnings for other properties

2021-07-05 Thread Fabian Ebner
Previously, if there were some warnings, but no warnings for the 'Suites' property, it would still display as a warning (without additional text). Signed-off-by: Fabian Ebner --- src/node/APTRepositories.js | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/s

[pve-devel] [PATCH manager 1/1] api: apt: repositories: add description to return schema

2021-07-05 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- for completeness' sake. PVE/API2/APT.pm | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm index bd60db33..daa297b9 100644 --- a/PVE/API2/APT.pm +++ b/PVE/API2/APT.pm @@ -655,7 +655,11 @@ __PACKAGE__->regist

[pve-devel] [RFC proxmox-apt 3/3] repository check: check components for Proxmox repositories

2021-07-05 Thread Fabian Ebner
for no-subscription and test, which is currently done directly in the front-end. Signed-off-by: Fabian Ebner --- src/repositories/file.rs | 34 +++--- src/repositories/mod.rs| 4 +-- tests/repositories.rs | 23 ++---

[pve-devel] [PATCH proxmox-apt 1/3] code cleanup: use contains()

2021-07-05 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- src/repositories/file.rs | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/repositories/file.rs b/src/repositories/file.rs index 447fd0a..49cc358 100644 --- a/src/repositories/file.rs +++ b/src/repositories/file.rs @@ -304,11 +304,7 @@ im

[pve-devel] [PATCH i18n] de: fix fuzzy translations

2021-07-05 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- de.po | 57 ++--- 1 file changed, 18 insertions(+), 39 deletions(-) diff --git a/de.po b/de.po index 4936925..c9494d3 100644 --- a/de.po +++ b/de.po @@ -585,9 +585,8 @@ msgid "Auto-generate a client encrypti

[pve-devel] applied: [PATCH i18n] update turkish translations

2021-07-05 Thread Thomas Lamprecht
On 05.07.21 14:32, Oguz Bektas wrote: > Signed-off-by: Oguz Bektas > --- > tr.po | 414 +- > 1 file changed, 147 insertions(+), 267 deletions(-) > > applied, thanks! ___ pve-devel mailing list

[pve-devel] [PATCH i18n] update turkish translations

2021-07-05 Thread Oguz Bektas
Signed-off-by: Oguz Bektas --- tr.po | 414 +- 1 file changed, 147 insertions(+), 267 deletions(-) diff --git a/tr.po b/tr.po index cd20ae8..2ac299f 100644 --- a/tr.po +++ b/tr.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-Version: proxmox tran

[pve-devel] applied: [PATCH 2/2] ui: dc/guests: set line-height again and increase font-size

2021-07-05 Thread Thomas Lamprecht
the 14px over 13px is not much, but as that is the font-size intended for font-awesome it makes it all look nicer together Signed-off-by: Thomas Lamprecht --- www/manager6/dc/Guests.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/www/manager6/dc/Guests.js b/www/manager6/dc/Guests.js ind

[pve-devel] applied: [PATCH 1/2] ui: dc/guests: avoid using for layouting

2021-07-05 Thread Thomas Lamprecht
use a flex box with centered columns instead, that needs adding a div per row, but that's IMO actually making it more clear what a row is anyway. Signed-off-by: Thomas Lamprecht --- best viewed with -w www/manager6/dc/Guests.js | 82 --- 1 file changed, 50 i

[pve-devel] [PATCH manager v2 1/2] pve6to7: check for containers not supporting pure cgroupv2

2021-07-05 Thread Stoiko Ivanov
Helpers copied from pve-container to avoid versioned bumps. Early returns when no containers are running, or the containers don't use systemd, as well as returning after finding the first affected container to minimize impact and resource usage. Checking running containers first since following /

[pve-devel] [PATCH container v2 1/2] prestart-hook: detect cgroupv2 incompatible systemd version

2021-07-05 Thread Stoiko Ivanov
Some container OS (e.g. CentOS 7, Ubuntu 16.04) are booted with systemd, in a version which is not able to run with a pure cgroupv2 (a.k.a unified hierarchy) environment. Detect those in the lxc-pve-prestart-hook, because there we already have all mount-points set up. This approach only leaves sy

[pve-devel] [PATCH manger/container v2 0/2] detect containers not supporting pure cgroupv2

2021-07-05 Thread Stoiko Ivanov
changes v1->v2: incorporated Thomas' feedback (huge thx!) by: * adding extra handling for Alpine and Devuan container (patch 2/2 for pve-container) * copying the helpers directly to pve6to7 to avoid versioned dependency bumps * refactoring the code in pve6to7 a bit (also returning early for A

[pve-devel] [PATCH manager v2 2/2] pve6to7: add 'full' parameter for expensive checks

2021-07-05 Thread Stoiko Ivanov
and place the container cgroupv2 support checks behind it. Signed-off-by: Stoiko Ivanov --- PVE/CLI/pve6to7.pm | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/PVE/CLI/pve6to7.pm b/PVE/CLI/pve6to7.pm index b9aeb89c..5e97a3c5 100644 --- a/PVE/CLI/pve6to7.pm +++

[pve-devel] [PATCH container v2 2/2] setup: shortcut cgroupv2 support for non-systemd distros

2021-07-05 Thread Stoiko Ivanov
Alpine and Devuan do not use systemd as init, thus run without problems in a pure cgroupv2 environment Signed-off-by: Stoiko Ivanov --- src/PVE/LXC/Setup/Alpine.pm | 7 +++ src/PVE/LXC/Setup/Devuan.pm | 7 +++ 2 files changed, 14 insertions(+) diff --git a/src/PVE/LXC/Setup/Alpine.pm b/

[pve-devel] applied: [PATCH manager] ui: remove 'line-height' from datacenter/summary to fix FF

2021-07-05 Thread Thomas Lamprecht
On 05.07.21 12:15, Stefan Reiter wrote: > Firefox doesn't correctly break to the next line if the line-height is > set as is (with certain fonts, including the default on debian it > seems). Simply remove it, as it isn't necessary. > > Suggested-by: Dominik Csapak > Signed-off-by: Stefan Reiter

[pve-devel] applied: [PATCH] ui: dc/Guests: make update lazy

2021-07-05 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- www/manager6/dc/Guests.js | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/www/manager6/dc/Guests.js b/www/manager6/dc/Guests.js index 0707dd9f..df233b6d 100644 --- a/www/manager6/dc/Guests.js +++ b/www/manager6/dc/Guests

[pve-devel] [PATCH docs] pvecm: add small note for 'updatecerts' workaround in qdevice setup

2021-07-05 Thread Oguz Bektas
sometimes the qdevice setup can fail when copying CA certificates if the node SSH keys are not matching for some reason. reported here: https://forum.proxmox.com/threads/pvecm-qdevice-setup-fails.88681 Signed-off-by: Oguz Bektas --- pvecm.adoc | 4 1 file changed, 4 insertions(+) diff --g

[pve-devel] [PATCH manager] ui: remove 'line-height' from datacenter/summary to fix FF

2021-07-05 Thread Stefan Reiter
Firefox doesn't correctly break to the next line if the line-height is set as is (with certain fonts, including the default on debian it seems). Simply remove it, as it isn't necessary. Suggested-by: Dominik Csapak Signed-off-by: Stefan Reiter --- www/manager6/dc/Guests.js | 1 - 1 file changed

[pve-devel] applied: [PATCH/RFC manager] pveceph: also install nvme-cli

2021-07-05 Thread Thomas Lamprecht
On 05.07.21 11:50, Fabian Ebner wrote: > The nvme-cli package is recommended by (our) Ceph packages, but here > --no-install-recommends is used to avoid pulling in too much. > > The issue with not installing nvme-cli is that a "security > information" mail notification is triggered by sudo each ti

[pve-devel] [PATCH/RFC manager] pveceph: also install nvme-cli

2021-07-05 Thread Fabian Ebner
The nvme-cli package is recommended by (our) Ceph packages, but here --no-install-recommends is used to avoid pulling in too much. The issue with not installing nvme-cli is that a "security information" mail notification is triggered by sudo each time Ceph tries to get the device health metrics. W

[pve-devel] [PATCH qemu-server] api: always add new CD drives to bootorder

2021-07-05 Thread Stefan Reiter
Attaching an ISO image to a VM is usually/often done for two reasons: * booting an installer image * supplying additional drivers to an installer (e.g. virtio) Both of these cases (the latter at least with SeaBIOS and the Windows installer) require the disk to be marked as bootable. For this reas

Re: [pve-devel] [RFC storage 1/7] storage: expose find_free_diskname

2021-07-05 Thread Fabian Ebner
Am 02.07.21 um 15:38 schrieb Aaron Lauterer: On 6/2/21 10:29 AM, Fabian Ebner wrote: Am 01.06.21 um 18:10 schrieb Aaron Lauterer: Signed-off-by: Aaron Lauterer ---   PVE/Storage.pm | 8   1 file changed, 8 insertions(+) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index aa36bad..93d