[pve-devel] applied-series: [PATCH widget-toolkit 0/5] some APTRepositories improvements

2021-06-30 Thread Thomas Lamprecht
On 30.06.21 17:14, Dominik Csapak wrote: > some small and basic improvements > > NOTE: patch 4/5 changes how we display warnings, which currently (AFAICS) > only can happen on the 'Suites' property if we add more warnings for > different properties, we have to add them in the relevant columns as w

[pve-devel] applied: [RFC proxmox-widget-toolkit 1/1] node: apt: spawn a window for adding repository

2021-06-30 Thread Thomas Lamprecht
On 30.06.21 17:07, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > > I couldn't get the validation to work properly and adding a repo > gives an "Unknown Error" (but does add the repo). > > src/node/APTRepositories.js | 161 ++-- > 1 file changed, 117 i

[pve-devel] applied: [PATCH v7 pve-rs 1/1] add bindings for proxmox-apt

2021-06-30 Thread Thomas Lamprecht
On 23.06.21 15:39, Fabian Ebner wrote: > which contains includes logic for repository handling. > > Signed-off-by: Fabian Ebner > --- > > Changes from v6: > * have repositories() return everything at once > * base on now existing pve-rs > * don't use raw_return > * add bindings f

[pve-devel] applied: [PATCH proxmox-apt 1/1] standard repos: allow conversion from handle and improve information

2021-06-30 Thread Thomas Lamprecht
On 30.06.21 17:07, Fabian Ebner wrote: > Add a description for the handle, which can be useful to display > alongside the name. The descriptions are essentially the first > sentence from PVE's "Package Repositories" docs, but without the > product name. > > Also drop the " Repository" suffix from

[pve-devel] [PATCH qemu-server] cfg2cmd/drive: don't use io_uring for krbd with wb/wt cache

2021-06-30 Thread Stefan Reiter
As reported here and locally reproduced: https://forum.proxmox.com/threads/efi-vms-wont-start-under-7-beta-with-writeback-cache.91629/ This configuration is currently broken. Until we figure out how to fix it properly, we can just have this (luckily very narrow) config pattern fall back to aio=thr

[pve-devel] [PATCH widget-toolkit 4/5] APTRepositories: make the Suites warnings inline errors

2021-06-30 Thread Dominik Csapak
by iterating only once over the info array and adding them directly to the records this way we can avoid iterating over the records again Signed-off-by: Dominik Csapak --- src/node/APTRepositories.js | 100 +--- 1 file changed, 46 insertions(+), 54 deletions(-) d

[pve-devel] [PATCH widget-toolkit 2/5] APTRepositories: make panel scrollable

2021-06-30 Thread Dominik Csapak
so that it is still usable with many errors and/or repositories Signed-off-by: Dominik Csapak --- src/node/APTRepositories.js | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js index 7544a23..1985e50 100644 --- a/src/node/APTReposi

[pve-devel] [PATCH widget-toolkit 0/5] some APTRepositories improvements

2021-06-30 Thread Dominik Csapak
some small and basic improvements NOTE: patch 4/5 changes how we display warnings, which currently (AFAICS) only can happen on the 'Suites' property if we add more warnings for different properties, we have to add them in the relevant columns as well Dominik Csapak (5): APTRepositories: change

[pve-devel] [PATCH widget-toolkit 3/5] APTRepositories: change updating button text/state to viewcontroller

2021-06-30 Thread Dominik Csapak
we already have a viewmodel we can use, and so the handler does not have to navigate the component tree up/down Signed-off-by: Dominik Csapak --- src/node/APTRepositories.js | 41 - 1 file changed, 22 insertions(+), 19 deletions(-) diff --git a/src/node/APTRe

[pve-devel] [PATCH widget-toolkit 1/5] APTRepositories: change separation style between panels

2021-06-30 Thread Dominik Csapak
having double borders does not look so nice, separate them with a bit of padding also change the warning panel to a simple header Signed-off-by: Dominik Csapak --- src/node/APTRepositories.js | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/src/node/APTRepo

[pve-devel] [PATCH widget-toolkit 5/5] APTRepositories: remove unecessary selection model

2021-06-30 Thread Dominik Csapak
this is the default anyway, no reason to explicitely create it Signed-off-by: Dominik Csapak --- src/node/APTRepositories.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js index de0197b..04e6f97 100644 --- a/src/node/APTRepositorie

[pve-devel] [PATCH proxmox-apt 1/1] standard repos: allow conversion from handle and improve information

2021-06-30 Thread Fabian Ebner
Add a description for the handle, which can be useful to display alongside the name. The descriptions are essentially the first sentence from PVE's "Package Repositories" docs, but without the product name. Also drop the " Repository" suffix from the names, as it's not useful, but can be ugly: e.g

[pve-devel] [PATCH-SERIES proxmox-apt/proxmox-widget-toolkit] Spawn a window when adding a repository

2021-06-30 Thread Fabian Ebner
and add a description. I couldn't get the validation to work properly and adding a repo gives an "Unknown Error" (but does add the repo). Same as last time: Requires the not-yet-applied patches for pve-rs and pve-manager from here: https://lists.proxmox.com/pipermail/pve-devel/2021-June/048963.

[pve-devel] [RFC proxmox-widget-toolkit 1/1] node: apt: spawn a window for adding repository

2021-06-30 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- I couldn't get the validation to work properly and adding a repo gives an "Unknown Error" (but does add the repo). src/node/APTRepositories.js | 161 ++-- 1 file changed, 117 insertions(+), 44 deletions(-) diff --git a/src/node/AP

[pve-devel] applied: [PATCH manager stable-6] pve6to7: skip user.cfg if it does not exist

2021-06-30 Thread Thomas Lamprecht
On 30.06.21 15:32, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > PVE/CLI/pve6to7.pm | 5 + > 1 file changed, 5 insertions(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cg

[pve-devel] [PATCH manager stable-6] pve6to7: skip user.cfg if it does not exist

2021-06-30 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- PVE/CLI/pve6to7.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/PVE/CLI/pve6to7.pm b/PVE/CLI/pve6to7.pm index 6dd7760c..1c89242d 100644 --- a/PVE/CLI/pve6to7.pm +++ b/PVE/CLI/pve6to7.pm @@ -608,6 +608,11 @@ sub check_cifs_credential_location { sub ch

[pve-devel] applied: [PATCH v2 manager 1/2] pve6to7: content check: fix detecting pass

2021-06-30 Thread Fabian Grünbichler
On June 30, 2021 11:16 am, Fabian Ebner wrote: > If there is a log_fail, because of misconfigured 'none' content type, the > final > log_pass should not be printed. > > Signed-off-by: Fabian Ebner > --- > > No changes from v1. > > PVE/CLI/pve6to7.pm | 7 ++- > 1 file changed, 6 insertions

[pve-devel] applied: [PATCH v2 manager 2/2] pve6to7: more fine-grained detection of misconfigured guest volumes

2021-06-30 Thread Fabian Grünbichler
On June 30, 2021 11:16 am, Fabian Ebner wrote: > If neither 'rootdir' nor 'images' are configured on a storage, but > there are guest images, just log the number of volumes found. If they > are relevant for migration, the check for unreferenced volumes will > catch them later. > > Also detect cont

[pve-devel] applied-series: [PATCH-SERIES proxmox-apt/proxmox-widget-toolkit] APT repos: Use Origin property instead of "official host"

2021-06-30 Thread Thomas Lamprecht
On 30.06.21 12:20, Fabian Ebner wrote: > which also works for mirrors, host aliases and direct IP addressses. > > The third proxmox-apt patch is not directly related, but another small > improvement. > > Requires the not-yet-applied patches for pve-rs and pve-manager from > here: > > https://lis

[pve-devel] [PATCH-SERIES proxmox-apt/proxmox-widget-toolkit] APT repos: Use Origin property instead of "official host"

2021-06-30 Thread Fabian Ebner
which also works for mirrors, host aliases and direct IP addressses. The third proxmox-apt patch is not directly related, but another small improvement. Requires the not-yet-applied patches for pve-rs and pve-manager from here: https://lists.proxmox.com/pipermail/pve-devel/2021-June/048963.html

[pve-devel] [PATCH proxmox-widget-toolkit 1/1] apt repositories: replace OfficialHost with Origin

2021-06-30 Thread Fabian Ebner
to adapt to the new backend behavior. Signed-off-by: Fabian Ebner --- src/node/APTRepositories.js | 28 1 file changed, 8 insertions(+), 20 deletions(-) diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js index fb6edaf..6812d46 100644 --- a/src/no

[pve-devel] [PATCH proxmox-apt 3/3] standard repos: drop product acronym from repo name

2021-06-30 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- src/repositories/mod.rs | 14 +++--- src/repositories/standard.rs | 21 + tests/repositories.rs| 21 +++-- 3 files changed, 23 insertions(+), 33 deletions(-) diff --git a/src/repositories/mod.rs b/src/reposi

[pve-devel] [PATCH proxmox-apt 2/3] check: return 'origin' property instead of 'badge' for official host

2021-06-30 Thread Fabian Ebner
which is obtained from the cached InRelease file and also works for mirrors, host aliases, direct IPs. The has_official_uri function was replaced by origin_from_uris. Signed-off-by: Fabian Ebner --- src/repositories/file.rs | 17 + src/repositories/repository.rs | 20 +

[pve-devel] [PATCH v2 manager 2/2] pve6to7: more fine-grained detection of misconfigured guest volumes

2021-06-30 Thread Fabian Ebner
If neither 'rootdir' nor 'images' are configured on a storage, but there are guest images, just log the number of volumes found. If they are relevant for migration, the check for unreferenced volumes will catch them later. Also detect content type mismatch for all volumes of existing guests, which

[pve-devel] [PATCH v2 manager 1/2] pve6to7: content check: fix detecting pass

2021-06-30 Thread Fabian Ebner
If there is a log_fail, because of misconfigured 'none' content type, the final log_pass should not be printed. Signed-off-by: Fabian Ebner --- No changes from v1. PVE/CLI/pve6to7.pm | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/PVE/CLI/pve6to7.pm b/PVE/CLI/pve6to7.

Re: [pve-devel] Proxmox 7.0 Beta - Ceph "a password is required" error messages?

2021-06-30 Thread Fabian Ebner
Am 29.06.21 um 01:19 schrieb Victor Hooi: Hi, Yes, I can confirm that file exists on my system: root@angusmtv-vm01:/etc/sudoers.d# cat ceph-osd-smartctl ## allow ceph-osd (which runs as user ceph) to collect device health metrics ceph ALL=NOPASSWD: /usr/sbin/smartctl -x --json=o /dev/* cep

Re: [pve-devel] [PATCH pve-access-control v2 1/5] check_user_enabled: also check if user is expired

2021-06-30 Thread Fabian Grünbichler
the check is cheap, so it does not matter much that it happens in more places now (like for every request with a ticket in addition to the old every request with a token). would have been nice to mention whether this is intentional though ;) On June 30, 2021 8:10 am, Dietmar Maurer wrote: > ---