Re: [pve-devel] [PATCH container] fix #3478: abort container creation on arch detection timeout

2021-06-29 Thread Fabian Grünbichler
On June 29, 2021 3:53 pm, Lorenz Stechauner wrote: > increased the timeout for detect_arch from 5 to 10 seconds. > > until now, on any error detect_architecture would fall back to amd64. > to avoid falling back due to an timeout error this function now dies > on timeout errors. > > additionally m

[pve-devel] [PATCH pve-access-control v2 4/5] api: implement openid API

2021-06-29 Thread Dietmar Maurer
This moves compute_api_permission() into RPCEnvironment.pm. --- src/PVE/API2/AccessControl.pm | 60 ++ src/PVE/API2/Makefile | 3 +- src/PVE/API2/OpenId.pm| 211 ++ src/PVE/RPCEnvironment.pm | 49 4 files changed, 270 inserti

[pve-devel] [PATCH pve-access-control v2 5/5] implement OpenID autocreate user feature

2021-06-29 Thread Dietmar Maurer
--- src/PVE/API2/OpenId.pm | 35 +++ 1 file changed, 31 insertions(+), 4 deletions(-) diff --git a/src/PVE/API2/OpenId.pm b/src/PVE/API2/OpenId.pm index d0b29fc..8384729 100644 --- a/src/PVE/API2/OpenId.pm +++ b/src/PVE/API2/OpenId.pm @@ -9,9 +9,10 @@ use PVE::RS::

[pve-devel] [PATCH pve-access-control v2 2/5] add OpenId configuration

2021-06-29 Thread Dietmar Maurer
--- src/PVE/AccessControl.pm | 2 ++ src/PVE/Auth/Makefile| 3 +- src/PVE/Auth/OpenId.pm | 68 3 files changed, 72 insertions(+), 1 deletion(-) create mode 100755 src/PVE/Auth/OpenId.pm diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl

[pve-devel] [PATCH pve-access-control v2 0/5] add OpenId realms

2021-06-29 Thread Dietmar Maurer
Changes in v2: - also check if user is expired (in check_user_enabled) - always die with newline - rename "user-attr" to "username-claim" Dietmar Maurer (5): check_user_enabled: also check if user is expired add OpenId configuration depend on libpve-rs-perl api: implement openid API imp

[pve-devel] [PATCH pve-access-control v2 3/5] depend on libpve-rs-perl

2021-06-29 Thread Dietmar Maurer
--- debian/control | 2 ++ 1 file changed, 2 insertions(+) diff --git a/debian/control b/debian/control index 81a32bd..3ef748b 100644 --- a/debian/control +++ b/debian/control @@ -10,6 +10,7 @@ Build-Depends: debhelper (>= 12~), lintian, perl, libpv

[pve-devel] [PATCH pve-access-control v2 1/5] check_user_enabled: also check if user is expired

2021-06-29 Thread Dietmar Maurer
--- src/PVE/AccessControl.pm | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm index 2569a35..8628678 100644 --- a/src/PVE/AccessControl.pm +++ b/src/PVE/AccessControl.pm @@ -428,12 +428,10 @@ sub verify_token {

[pve-devel] [PATCH container] fix #3478: abort container creation on arch detection timeout

2021-06-29 Thread Lorenz Stechauner
increased the timeout for detect_arch from 5 to 10 seconds. until now, on any error detect_architecture would fall back to amd64. to avoid falling back due to an timeout error this function now dies on timeout errors. additionally minor changes to the error messages have been made. Signed-off-by

Re: [pve-devel] [PATCH pve-manager] ui: implement OpenId login

2021-06-29 Thread Thomas Lamprecht
On 29.06.21 10:13, Fabian Grünbichler wrote: > not directly related to this patch - we should probably disable TFA for > openid realms (and their users), since TFA would need to be handled at > the openid provider in that case.. e.g., if I login via openid and then > hit TFA in the top right cor

Re: [pve-devel] [PATCH pve-access-control 1/4] add OpenId configuration

2021-06-29 Thread Fabian Grünbichler
On June 24, 2021 10:17 am, Dietmar Maurer wrote: > --- > src/PVE/AccessControl.pm | 2 ++ > src/PVE/Auth/Makefile| 3 +- > src/PVE/Auth/OpenId.pm | 67 > 3 files changed, 71 insertions(+), 1 deletion(-) > create mode 100755 src/PVE/Auth/OpenId.pm >

Re: [pve-devel] [PATCH pve-manager] ui: implement OpenId login

2021-06-29 Thread Fabian Grünbichler
also missing in pve-manager - code to add/edit openid realms via the GUI.. On June 24, 2021 10:17 am, Dietmar Maurer wrote: > --- > PVE/HTTPServer.pm | 4 +- > www/manager6/Utils.js | 8 +++ > www/manager6/window/LoginWindow.js | 105

Re: [pve-devel] [PATCH pve-access-control 3/4] api: implement openid API

2021-06-29 Thread Fabian Grünbichler
On June 24, 2021 10:18 am, Dietmar Maurer wrote: > This moves compute_api_permission() into RPCEnvironment.pm. > --- > src/PVE/API2/AccessControl.pm | 60 ++ > src/PVE/API2/Makefile | 3 +- > src/PVE/API2/OpenId.pm| 214 ++ > src/PVE/RPCEn

Re: [pve-devel] [PATCH pve-manager] ui: implement OpenId login

2021-06-29 Thread Fabian Grünbichler
not directly related to this patch - we should probably disable TFA for openid realms (and their users), since TFA would need to be handled at the openid provider in that case.. e.g., if I login via openid and then hit TFA in the top right corner user menu, I get prompted for a password to setu