On 21.06.21 18:35, Stefan Reiter wrote:
> KillMode 'none' is deprecated, and systemd loudly complains about that
> in the journal. To avoid the warning, but keep the behaviour the same,
> use KillMode 'process'.
>
> This mode does two things differently, which we have to stop it from
> doing:
> *
On 21.06.21 18:35, Stefan Reiter wrote:
> Used in qemu-server for avoiding KillMode 'none'. SendSIGKILL is a
> boolean, so we need to use dbus_boolean to serialize it.
>
> Signed-off-by: Stefan Reiter
> ---
> src/PVE/Systemd.pm | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>
systemd deprecated KillMode 'none', but we still need it, since we manage our VM
scopes/slices manually via another service, 'pve-guests.service'. To this
extent, replicate the previous behaviour without using the deprecated mode.
Example log message:
/run/systemd/transient/101.scope:3: Unit confi
KillMode 'none' is deprecated, and systemd loudly complains about that
in the journal. To avoid the warning, but keep the behaviour the same,
use KillMode 'process'.
This mode does two things differently, which we have to stop it from
doing:
* it sends SIGTERM right when the scope is cancelled (e.
Used in qemu-server for avoiding KillMode 'none'. SendSIGKILL is a
boolean, so we need to use dbus_boolean to serialize it.
Signed-off-by: Stefan Reiter
---
src/PVE/Systemd.pm | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/PVE/Systemd.pm b/src/PVE/Systemd.pm
index
Note: This does not work when you have the 6.0 QEMU from the staging repo
installed, as it is built without io_uring - this patch is banking on us
only releasing a QEMU 6.0 to public with io_uring already baked in, i.e.
equating QEMU 6.0 with io_uring support enabled. Adding a +pve version or
simi
The 'aio' setting is not visible to the guest, and so can be changed
during migrations or snapshots without issue. It is thus only
dependendent on the actual QEMU version being >= 6.0, not machine
version.
Signed-off-by: Stefan Reiter
---
new in v2
tested migration from and to old, both worked
Note that the value in this enum directly represents the value passed to
QEMU, so we need to use the underscore.
Signed-off-by: Stefan Reiter
---
same as v1, par the commit message
PVE/QemuServer/Drive.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer/Drive.
On 21.06.21 15:55, Dominik Csapak wrote:
> so it is more consistend with the source (it comes from the file
> 'device') as well as the subsytem_device field
>
> the only place we use that field is in the same file in pci_dev_bind_to_vfio,
> which we also change here, so that should not be a breaki
On 21.06.21 15:55, Dominik Csapak wrote:
> to also get the subsystem_vendor and device, as well as the
> iommu group and mediated device support
>
> Signed-off-by: Dominik Csapak
> ---
> src/PVE/SysFSTools.pm | 29 +
> 1 file changed, 25 insertions(+), 4 deletions(-)
On 21.06.21 16:31, Fabian Ebner wrote:
> Changes from v1:
> * dropped already applied patches
> * rebased
> * adapted/improved messages
>
> Fabian Ebner (2):
> pve6to7: add check for guest images on misconfigured storages
> pve6to7: check for misconfigured content type 'none'
>
>
migration and (container) startup will no longer work when the storage's content
type is not correct, and unreferenced volumes on such storages will not be
scanned for anymore.
Signed-off-by: Fabian Ebner
---
Changes from v1:
* generalized warning and commit message, since (container) startu
which will be a hard error (i.e. section will be skipped when parsing) in PVE
7.0
Signed-off-by: Fabian Ebner
---
Changes from v1:
* Also change message for passing the check to match with changed initial
log line
PVE/CLI/pve6to7.pm | 12 ++--
1 file changed, 10 insertions(+)
Changes from v1:
* dropped already applied patches
* rebased
* adapted/improved messages
Fabian Ebner (2):
pve6to7: add check for guest images on misconfigured storages
pve6to7: check for misconfigured content type 'none'
PVE/CLI/pve6to7.pm | 50 ++
reworks the panel to use a controller, so that we can easily
add the selector for mapped pci devices
shows now a selection between 'raw' and 'mapped' devices, where
'raw' ones work like before, and 'mapped' ones take the values
form the hardware map config
Signed-off-by: Dominik Csapak
---
www/
adds the basic api calls to list/get/create/update/delete device
mappings
for now these api calls are only per node, so it only affects
the node specific mapping (thought consistency checks are
done for the whole config, e.g if an id exists already on another
node with a different type)
Signed-of
this series aims to add a cluster-wide device mapping for (atm) pci and
usb devices. so that an admin can configure a device to be availble
for migration and configuring for uses that are non-root
built-in are some additional safety checks in contrast to current
passthrough, e.g. if pci addresses
adds the Top level package PVE::HardwareMap that
registers the Plugins for the config, as well
as provides some convenience methods
(find_device_on_current_node, lock/write/get config)
The Plugins themselves are usual SectionConfigs plugins
with (for now) two types: usb, pci
each type gets an 'as
if the migration is an offline migration and when the mapping on
the target node exists, otherwise not
this does not change the behaviour for 'raw' devices in the config
those can still be forced to be migrated, like before
Signed-off-by: Dominik Csapak
---
www/manager6/window/Migrate.js | 37 +
akin to the PCISelector, but uses the api for mapped devices
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile | 1 +
www/manager6/form/PCIMapSelector.js | 95 +
2 files changed, 96 insertions(+)
create mode 100644 www/manager6/form/PCIMapSelecto
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 39 ---
1 file changed, 36 insertions(+), 3 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index eeb07d1..98d11bc 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -24,6 +24,7 @@ use PVE
similar to PCIMapSelector
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile | 1 +
www/manager6/form/USBMapSelector.js | 73 +
2 files changed, 74 insertions(+)
create mode 100644 www/manager6/form/USBMapSelector.js
diff --git a/www/manager6/Mak
restrict the nodes also for mapped devices, and return them in their
own property
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 36b8c31..837185f 100644
--- a/PVE/AP
and get the correct pci device during parsing
Signed-off-by: Dominik Csapak
---
PVE/QemuServer/PCI.pm | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuServer/PCI.pm b/PVE/QemuServer/PCI.pm
index 2ee142f..26bad63 100644
--- a/PVE/QemuServer/PCI.p
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm | 2 ++
PVE/QemuServer/USB.pm | 22 +-
2 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index fe31741..5589bc7 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@
they can only be migrated to nodes where there exists a mapping,
and if offline
Signed-off-by: Dominik Csapak
---
PVE/QemuMigrate.pm | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
index 5f37890..6ae365d 100644
--- a/PVE/Q
adds a node specific listing of hardware maps, where the user
can see if a mapping is wrong (wrong vendor/device etc)
and add/edit/delete them
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile | 1 +
www/manager6/node/Config.js | 8 +
www/manager6/node/HardwareView.js
to be able to select 'mapped' usb devices
Signed-off-by: Dominik Csapak
---
www/manager6/qemu/USBEdit.js | 34 +-
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/www/manager6/qemu/USBEdit.js b/www/manager6/qemu/USBEdit.js
index a2204584..82af78f9 100
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 54 ++--
1 file changed, 52 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 98d11bc..36b8c31 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -24,6 +24,7 @
similar to the pciselector, make it accept a plain nodename,
or no node at all and provide a setNodename function
to keep backwards compatibility, also check pveSelNode for the nodename
Signed-off-by: Dominik Csapak
---
www/manager6/form/USBSelector.js | 32
1 f
by adding them to their own list, saving the nodes where
they are not allowed, and return those on 'wantarray'
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm | 36 ++--
1 file changed, 34 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/Qem
to also get the subsystem_vendor and device, as well as the
iommu group and mediated device support
Signed-off-by: Dominik Csapak
---
src/PVE/SysFSTools.pm | 29 +
1 file changed, 25 insertions(+), 4 deletions(-)
diff --git a/src/PVE/SysFSTools.pm b/src/PVE/SysFSTool
so that we can assign privileges on hardware level
this will generate a new role (PVEHardwareAdmin)
Signed-off-by: Dominik Csapak
---
src/PVE/API2/AccessControl.pm | 3 ++-
src/PVE/AccessControl.pm | 13 +
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/src/PVE/
like check_vm_perm, etc.
Signed-off-by: Dominik Csapak
---
src/PVE/RPCEnvironment.pm | 8
1 file changed, 8 insertions(+)
diff --git a/src/PVE/RPCEnvironment.pm b/src/PVE/RPCEnvironment.pm
index 2e5a33b..1fac627 100644
--- a/src/PVE/RPCEnvironment.pm
+++ b/src/PVE/RPCEnvironment.pm
@@
so it is more consistend with the source (it comes from the file
'device') as well as the subsytem_device field
the only place we use that field is in the same file in pci_dev_bind_to_vfio,
which we also change here, so that should not be a breaking change
(in qemu-server we only really use the ex
to PVE/Cluster.pm
and status.c
Signed-off-by: Dominik Csapak
---
data/PVE/Cluster.pm | 1 +
data/src/status.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm
index 4d09c60..863b90f 100644
--- a/data/PVE/Cluster.pm
+++ b/data/PVE/Cluster.pm
@@ -75
On 6/18/21 5:17 PM, Thomas Lamprecht wrote:
On 10.06.21 13:28, Dominik Csapak wrote:
On 6/10/21 11:29, Stefan Reiter wrote:
On 6/10/21 10:40 AM, Dominik Csapak wrote:
On 6/10/21 10:23, Stefan Reiter wrote:
On 6/10/21 9:37 AM, Dominik Csapak wrote:
and not the node where the browser connects.
On 16.06.21 11:36, Lorenz Stechauner wrote:
> Signed-off-by: Lorenz Stechauner
> ---
> www/manager6/Makefile | 1 +
> www/manager6/form/HashAlgorithmSelector.js | 16
> 2 files changed, 17 insertions(+)
> create mode 100644 www/manager6/form/HashAlgorithmSe
On 18.06.21 12:59, Fabian Ebner wrote:
> migration will no longer work when the storage's content type is not correct,
> and unreferenced volumes on such storages will not be scanned for anymore.
>
> Signed-off-by: Fabian Ebner
> ---
>
> If Lorenz's patches that enforce the correct content type
On 18.06.21 12:59, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner
> ---
> PVE/Storage/Plugin.pm | 4
> 1 file changed, 4 insertions(+)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-
On 18.06.21 12:59, Fabian Ebner wrote:
> The enabled check in the lower loop is now redundant and can be removed.
>
> If storeid is provided, initialize the result hash accordingly, mainly for
> backwards compatibility (needed by a caller in pve-manager's Ceph/Pools.pm and
> the migration code in
On 18.06.21 12:59, Fabian Ebner wrote:
> storage_check_enabled simply checks for the 'disable' option and then calls
> storage_check_node.
>
> While not strictly necessary for a second call where only the storage differs,
> e.g. in case of clone, it is more future-proof: if support for a target
>
On 18.06.21 12:59, Fabian Ebner wrote:
> and use it for the vdisk_list call too. This avoids scanning (and picking up
> volumes from!) storages that are not even configured to hold images.
>
> Previously, the content type was only enforced when a storage map was present.
>
> Also serves a bit as
On 27.05.21 14:23, Lorenz Stechauner wrote:
> it is now necessary for storages to support the 'images' content in
> order to start vms on them. all native storage plugins already
> report the images content correctly.
>
> Signed-off-by: Lorenz Stechauner
> ---
> PVE/QemuServer.pm | 7 +++
>
On 27.05.21 14:23, Lorenz Stechauner wrote:
> it is now necessary for storages to support the 'rootdir' content in
> order to start containers on them. all native storage plugins
> already report the rootdir content correctly.
>
> Signed-off-by: Lorenz Stechauner
> ---
> src/PVE/LXC.pm | 30
On 18.06.21 12:59, Fabian Ebner wrote:
> and use it for the vdisk_list call too. This avoids scanning (and picking up
> volumes from!) storages that are not even configured to hold container images.
>
> Also serves a bit as a preparation to enforce content type on guest startup,
> because now migr
On 18.06.21 12:59, Fabian Ebner wrote:
> storage_check_enabled simply checks for the 'disable' option and then calls
> storage_check_node.
>
> While not strictly necessary for a second call where only the storage differs,
> it is more future-proof: if support for a target storage is added at some
On 18.06.21 12:59, Fabian Ebner wrote:
> otherwise an unused volume on a disabled storage is silently left on the old
> node, even if referenced.
>
> Signed-off-by: Fabian Ebner
> ---
>
> needs the previous patch to work correctly (otherwise disable is still
> ignored)
>
> src/PVE/LXC/Migrate
On Tue, Apr 06, 2021 at 08:26:50AM +0200, Fabian Ebner wrote:
> It turns out that we do not yet allow cloning from container templates with
> bind mounts. So in a sense container templates with bind mounts are
> currently misconfigured, and this patch would make it easier to get there...
>
> Shoul
On 07.06.21 13:48, Stefan Reiter wrote:
> Note that the value in this enum directly represents the value passed to
> QEMU, so we need to use the underscore.
>
> Off by default, updated QEMU required, but no compatibility issues, as
> this is a new value that wasn't valid before, and setting it is
On 07.06.21 13:48, Stefan Reiter wrote:
> Signed-off-by: Stefan Reiter
> ---
>
> Oh if only all QEMU changes were this simple...
>
> debian/control | 1 +
> debian/rules | 1 +
> 2 files changed, 2 insertions(+)
>
>
applied, thanks!
___
pve-deve
On 23.05.21 09:39, Daniel Koć wrote:
> Signed-off-by: Daniel Koć
> ---
> pl.po | 2806 +++--
> 1 file changed, 1303 insertions(+), 1503 deletions(-)
>
>
applied, much thanks!
___
pve-devel mailing
On 20.05.21 15:53, Lorenz Stechauner wrote:
> see #3101
>
> Signed-off-by: Lorenz Stechauner
> ---
> pveum.adoc | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/pveum.adoc b/pveum.adoc
> index 7120db7..0bece8a 100644
> --- a/pveum.adoc
> +++ b/pveum.adoc
> @@ -56,6 +56,11 @@ Each u
On 18.06.21 18:58, Thomas Lamprecht wrote:
On 16.06.21 11:36, Lorenz Stechauner wrote:
a common function to download arbitrary files from urls has been
defined as PVE::Tools::download_file_from_url and is now used.
Signed-off-by: Lorenz Stechauner
---
PVE/API2/Nodes.pm | 93 +
On 03.05.21 12:00, Aaron Lauterer wrote:
> The ceph.service file has been removed in pve-manager commit be244f1.
> Therefore, there is no need to reference it anymore. This also avoids
> showing the `ceph.service` as a `not found` unit.
>
> Signed-off-by: Aaron Lauterer
> ---
> debian/pve-cluste
On 04.05.21 11:52, Fabian Ebner wrote:
> Storage.pm's vdisk_free interprets truthy return values as worker subs, so be
> explicit about returning undef here. Not an issue at the moment, because
> run_client_command already returns undef, but better be safe than sorry.
>
> Signed-off-by: Fabian Ebn
On 04.05.21 11:52, Fabian Ebner wrote:
> only affects LVM storages with 'saferemove 1' where the import fails at a
> rather
> advanced stage. Previously in such cases, the renamed (by free_image) volume
> del-vm-XYZ-disk-N would be left over.
>
> Signed-off-by: Fabian Ebner
> ---
> PVE/Storage/
On 12.05.21 21:04, Stoiko Ivanov wrote:
> This patch follows 2f8be3bfda203065b22e60862e5f98d831a46921 from
> pve-common:
> Instead of not specifying a listen address, we first try to bind on
> '::', which usually accepts connections for both ipv4 and ipv6,
> and fall back to '0.0.0.0' if this fails
On 16.06.21 11:35, Lorenz Stechauner wrote:
> uses common function PVE::Tools::download_file_from_url to download
> iso files.
>
> Only users with permissions `Sys.Audit` and `Sys.Modify` on `/` are
> permitted to perform this action. This restriction is due to the
> fact, that the download functi
On Fri, Jun 18, 2021 at 06:31:51PM +0200, Thomas Lamprecht wrote:
> On 21.05.21 12:44, Dominic Jäger wrote:
> > Users are repeatedly left with entries in Disks->Directory, most recently
> > https://forum.proxmox.com/threads/how-to-remove-local-directory-storage-properly.89504/
> >
> > Signed-off-b
60 matches
Mail list logo
