Signed-off-by: Fabian Ebner
---
pve-faq.adoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pve-faq.adoc b/pve-faq.adoc
index 343a6e9..b9e73b0 100644
--- a/pve-faq.adoc
+++ b/pve-faq.adoc
@@ -121,7 +121,7 @@ Although the specific upgrade steps depend on your
respective setup
while the command itself is 'suspend', the task description
is 'qmpause', so simply add a parameter and overwrite it for the pause
menu item
Signed-off-by: Dominik Csapak
---
www/manager6/qemu/CmdMenu.js | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/www/manager6/qemu
On 12.04.21 15:14, Aaron Lauterer wrote:
> Setting the vlan-id and vlan-raw-device value for vlan devices that
> follow the dot notaton (interface.vlan) aligns how dot notation vlan
> devices and vlan devices that use the explicit vlan-id and
> vlan-raw-device options, available with ifupdown2, are
On 12.04.21 15:14, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer
> ---
>
> There are probably a few opinions if these columns should be hidden by
> default and where they should be placed.
>
> src/node/NetworkView.js | 14 ++
> 1 file changed, 14 insertions(+)
>
>
applied,
On 15.06.21 16:08, Lorenz Stechauner wrote:
> ---
> src/PVE/Tools.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinf
On 15.06.21 16:08, Lorenz Stechauner wrote:
> the front end expects the error message to be the first part of the
> last line.
> ---
> src/PVE/Tools.pm | 10 ++
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
> index c90810c..c02c259
metadata is gained using a HEAD request.
Due to the ability of this api endpoint to request files on internal
networks (which would not be visible/accessible from outside) it is
restricted to users with permissions `Sys.Audit` and `Sys.Modify` on
`/`. Users with these permissions are able to alter
Signed-off-by: Lorenz Stechauner
---
www/manager6/Makefile | 1 +
www/manager6/form/HashAlgorithmSelector.js | 16
2 files changed, 17 insertions(+)
create mode 100644 www/manager6/form/HashAlgorithmSelector.js
diff --git a/www/manager6/Makefile b/www/mana
changes to v7:
* adapted to thomas' fix (using download_file_from_url inside a worker)
* updated error message in thomas' fix
pve-manager:
Lorenz Stechauner (5):
api: nodes: add query_url_metadata method
api: nodes: refactor aplinfo to use common download function
ui: add HashAlgorithmSelec
uses the common function PVE::Tools::download_file_from_url to
download a iso image or container template.
note: Only users with permissions `Sys.Audit` and `Sys.Modify` on
`/` are permitted to use the api endpoints due to security reasons.
(it is possible to download files from internal networks
uses common function PVE::Tools::download_file_from_url to download
iso files.
Only users with permissions `Sys.Audit` and `Sys.Modify` on `/` are
permitted to perform this action. This restriction is due to the
fact, that the download function is able to download files from
internal networks (whi
a common function to download arbitrary files from urls has been
defined as PVE::Tools::download_file_from_url and is now used.
Signed-off-by: Lorenz Stechauner
---
PVE/API2/Nodes.pm | 93 +--
1 file changed, 17 insertions(+), 76 deletions(-)
diff --g
Signed-off-by: Lorenz Stechauner
---
www/manager6/Utils.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index d9567979..9fef29bf 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -1776,7 +1776,7 @@ Ext.define('PV
the front end expects the error message to be the first part of the
last line.
---
src/PVE/Tools.pm | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index c90810c..c02c259 100644
--- a/src/PVE/Tools.pm
+++ b/src/PVE/Tools.pm
@@ -186
---
src/PVE/Tools.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index 8d6734d..c90810c 100644
--- a/src/PVE/Tools.pm
+++ b/src/PVE/Tools.pm
@@ -1908,7 +1908,7 @@ sub download_file_from_url {
if (lc($checksum_got) eq lc($check
On 10.06.21 13:15, Wolfgang Bumiller wrote:
> While the hotplug code utilized PVE::CGroup and already
> supported cgroupv2 with this, we did not write out the
> configuration before.
>
> Signed-off-by: Wolfgang Bumiller
> ---
> These values should correspond to how the PVE::CGroup live-apply code
On 09.06.21 15:18, Wolfgang Bumiller wrote:
> The interface takes the storeid now, not the image dir.
>
> Signed-off-by: Wolfgang Bumiller
> ---
> PVE/Storage/GlusterfsPlugin.pm | 4 ++--
> PVE/Storage/Plugin.pm | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>
applied,
On 09.06.21 15:18, Wolfgang Bumiller wrote:
> Mostly for the ability to atomically swap files.
>
> Signed-off-by: Wolfgang Bumiller
> ---
> src/PVE/Syscall.pm | 1 +
> src/PVE/Tools.pm | 10 ++
> 2 files changed, 11 insertions(+)
>
>
applied, thanks!
__
On 15.06.21 13:27, Fabian Grünbichler wrote:
> patches 3,4,6 can easily be backported to buster as well.
>
> patch 5 is just an invocation of 'wrap-and-sort -f debian/control.in',
> so trivially backportable or adaptable in case only some of this series
> gets applied/context has changed.
>
> pat
On 14.06.21 11:05, Lorenz Stechauner wrote:
> code is based on
> manager:PVE/API2/Nodes.pm:aplinfo
>
applied, with a slightly adapted commit message you send afterwards and some
followups.
I'm a bit sorry to not check on this more closely again earlier as I found
quite some
issues when finally
Signed-off-by: Fabian Grünbichler
---
debian/control.in | 27 ---
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/debian/control.in b/debian/control.in
index 81be6ac..4bae66f 100644
--- a/debian/control.in
+++ b/debian/control.in
@@ -32,8 +32,8 @@ Build-Dep
python2 is gone with bullseye
Signed-off-by: Fabian Grünbichler
---
debian/rules | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/rules b/debian/rules
index ec22136..0bd8eb5 100755
--- a/debian/rules
+++ b/debian/rules
@@ -157,7 +157,7 @@ binary: install
touch $
patches 3,4,6 can easily be backported to buster as well.
patch 5 is just an invocation of 'wrap-and-sort -f debian/control.in',
so trivially backportable or adaptable in case only some of this series
gets applied/context has changed.
patch 2 is needed for building on a clean bullseye system whic
sometimes the build would fail with
cp: cannot stat 'ubuntu-hirsute/.tmp_1987275': No such file or directory
make[1]: *** [debian/rules:181: .headers_prepare_mark] Error 1
make[1]: Leaving directory '/home/fgruenbichler/pve-kernel/build'
dpkg-buildpackage: error: fakeroot debian/rules binary subpr
needed for it to be a proper replacement for linux-libc-dev when
resolving dependencies, such as for liburing-dev
Signed-off-by: Fabian Grünbichler
---
debian/control.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/control.in b/debian/control.in
index a9c8dd8..6cdc9
those days are long gone by now ;)
Signed-off-by: Fabian Grünbichler
---
debian/control.in | 2 --
1 file changed, 2 deletions(-)
diff --git a/debian/control.in b/debian/control.in
index 6cdc9df..81be6ac 100644
--- a/debian/control.in
+++ b/debian/control.in
@@ -53,7 +53,6 @@ Section: devel
Pr
and put them into a new -dbgsym package for usage with
crash/kdump-tools/...
fixes #3465, and now allows to do the following (after installing
and configuring kdump-tools to collect kernel crash dumps) when the
system crashes:
$ apt install pve-kernel-5.11.21-1-dbgsym
$ crash /usr/lib/debug/b
On 6/15/21 10:04 AM, Fabian Ebner wrote:
Am 14.06.21 um 11:15 schrieb Stefan Reiter:
On 6/14/21 8:29 AM, Fabian Ebner wrote:
Any feedback for this?
Looks good to me and works as advertised:
Reviewed-by: Stefan Reiter
Tested-by: Stefan Reiter
Thanks for the review!
The `$unit = $drive
On 11.06.21 17:55, Stoiko Ivanov wrote:
> This reverts commit a3777dce67cf17cafa82ddd9e6067eeb2e2e.
>
> With the upcoming release of pmg-api 7.0 we included the changes for
> configuring a LISTEN_IP, thus this compatibility code is not needed
> anymore.
>
> Quickly tested with current pmg-api
On 16.04.21 10:51, Fabian Ebner wrote:
> which also checks whether the storage is even enabled. VZDump jobs already
> activate the storage, but more direct calls via API/CLI didn't do so yet.
>
> Signed-off-by: Fabian Ebner
> ---
>
> Or should the call rather be made in the API endpoints?
>
> F
On 14.06.21 13:40, Fabian Ebner wrote:
> $#* is the last index, not the length.
>
> Signed-off-by: Fabian Ebner
> ---
> PVE/Diskmanage.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
___
pve-devel mailing list
pve-de
Am 14.06.21 um 11:15 schrieb Stefan Reiter:
On 6/14/21 8:29 AM, Fabian Ebner wrote:
Any feedback for this?
Looks good to me and works as advertised:
Reviewed-by: Stefan Reiter
Tested-by: Stefan Reiter
Thanks for the review!
The `$unit = $drive->{index} % maxdev` logic doesn't seem usef
metadata is gained using a HEAD request.
Due to the ability of this api endpoint to request files on internal
networks (which would not be visible/accessible from outside) it is
restricted to users with permissions `Sys.Audit` and `Sys.Modify` on
`/`. Users with these permissions are able to a
uses common function PVE::Tools::download_file_from_url to download iso
files.
Only users with permissions `Sys.Audit` and `Sys.Modify` on `/` are
permitted to perform this action. This restriction is due to the fact,
that the download function is able to download files from internal
networks
uses the common function PVE::Tools::download_file_from_url to download
a iso image or container template.
note: Only users with permissions `Sys.Audit` and `Sys.Modify` on `/`
are permitted to use the api endpoints due to security reasons. (it is
possible to download files from internal netwo
adds a common function to download arbitrary files from urls.
security notice: this function does not perform any permission checking.
the calling function and/or api endpoint has to make sure, that only
authorized users may use this function.
caution: This function is able to download files f
a common function to download arbitrary files from urls has been defined
as PVE::Tools::download_file_from_url and is now used.
On 14.06.21 11:05, Lorenz Stechauner wrote:
Signed-off-by: Lorenz Stechauner
---
PVE/API2/Nodes.pm | 89 ++-
1 file cha
37 matches
Mail list logo
