[pve-devel] applied: [pbs-devel] [PATCH] (re)enable V4 xfs support for restore image

2021-06-10 Thread Thomas Lamprecht
On 10.06.21 12:17, Dominik Csapak wrote: > since kernel 5.10, xfs v4 format is deprecated, reenable it for our > restore image kernel > > Signed-off-by: Dominik Csapak > --- > it is already enabled in our regular 5.11 kernel config, > so there should be no problems there > > src/config-base | 1

Re: [pve-devel] [PATCH storage 2/4] add BTRFS storage plugin

2021-06-10 Thread Wolfgang Bumiller
On Thu, Jun 10, 2021 at 02:40:22PM +0200, Fabian Grünbichler wrote: > On June 9, 2021 3:18 pm, Wolfgang Bumiller wrote: > > This is mostly the same as a directory storage, with 2 major > > differences: > > > > * 'subvol' volumes are actual btrfs subvolumes and therefore > > allow snapshots > > *

Re: [pve-devel] [PATCH storage 2/4] add BTRFS storage plugin

2021-06-10 Thread Fabian Grünbichler
On June 9, 2021 3:18 pm, Wolfgang Bumiller wrote: > This is mostly the same as a directory storage, with 2 major > differences: > > * 'subvol' volumes are actual btrfs subvolumes and therefore > allow snapshots > * 'raw' files are placed *into* a subvolume and therefore > also allow snapshots,

Re: [pve-devel] [PATCH container 2/2] enable btrfs support via subvolumes

2021-06-10 Thread Fabian Grünbichler
On June 9, 2021 3:18 pm, Wolfgang Bumiller wrote: > Signed-off-by: Wolfgang Bumiller > --- > src/PVE/LXC.pm | 4 +++- > src/PVE/LXC/Migrate.pm | 7 --- > 2 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm > index bb1cbdb..9407d24 100644

Re: [pve-devel] [PATCH qemu-server] allow migrating raw btrfs volumes

2021-06-10 Thread Fabian Grünbichler
On June 9, 2021 3:18 pm, Wolfgang Bumiller wrote: > Signed-off-by: Wolfgang Bumiller > --- > PVE/QemuMigrate.pm | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm > index 6375a15..5b07c20 100644 > --- a/PVE/QemuMigrate.pm > +++

Re: [pve-devel] [PATCH storage] Revert "workaround zfs create -V error for unaligned sizes"

2021-06-10 Thread Fabian Ebner
Works for me. A tiny issue is that the disk size in the VM config does not show the actual value afterwards, but that is nothing new. Tested-by: Fabian Ebner Am 09.06.21 um 15:54 schrieb Aaron Lauterer: https://github.com/zfsonlinux/zfs/issues/8541 is solved and part of openzfs 2.0 with [0].

Re: [pve-devel] [PATCH storage 3/4] update import/export storage API

2021-06-10 Thread Fabian Grünbichler
On June 9, 2021 3:18 pm, Wolfgang Bumiller wrote: > This bumps APIVER, but also APIAGE, see below. > > The import methods (volume_import, volume_import_formats): > This additionally gets the '$snapshot' parameter which is > already present on the export side as an informational > piece to kn

Re: [pve-devel] [PATCH v3 container 1/2] setup: clear /etc/machine-id for newly created containers

2021-06-10 Thread Oguz Bektas
hi, > +sub clear_machine_id { > > +my ($self, $conf, $clone) = @_; > > + > > +my $code = sub { > > + $self->{plugin}->clear_machine_id($self->{conf}, $clone); > > +}; > > +$self->protected_call($code); > > + > > +} > > maybe it would make more sense to call this "post_clone_hook

Re: [pve-devel] [PATCH v3 container 2/2] clear machine-id also after container clone

2021-06-10 Thread Fabian Grünbichler
On May 27, 2021 11:26 am, Oguz Bektas wrote: > pass $clone=1 to avoid removing the file. instead we truncate it to an > empty file > > Signed-off-by: Oguz Bektas > --- > v2->v3: > * clear machine-id at the end of clone task worker > > src/PVE/API2/LXC.pm | 6 ++ > 1 file changed, 6 insertio

Re: [pve-devel] [PATCH v3 container 1/2] setup: clear /etc/machine-id for newly created containers

2021-06-10 Thread Fabian Grünbichler
On May 27, 2021 11:26 am, Oguz Bektas wrote: > this way when new containers are created they will have a unique > /etc/machine-id > > Signed-off-by: Oguz Bektas > --- > v3: > no changes > > > src/PVE/LXC/Setup.pm | 10 ++ > src/PVE/LXC/Setup/Base.pm | 25 +

Re: [pve-devel] [PATCH manager] ui: file-restore: start the file-restore on the selected node

2021-06-10 Thread Dominik Csapak
On 6/10/21 11:29, Stefan Reiter wrote: On 6/10/21 10:40 AM, Dominik Csapak wrote: On 6/10/21 10:23, Stefan Reiter wrote: On 6/10/21 9:37 AM, Dominik Csapak wrote: and not the node where the browser connects. there are at least two good reasons for this: * it is confusing, since the user would

[pve-devel] [PATCH container] configure cpu/cpuset/memory cgroupv2 values

2021-06-10 Thread Wolfgang Bumiller
While the hotplug code utilized PVE::CGroup and already supported cgroupv2 with this, we did not write out the configuration before. Signed-off-by: Wolfgang Bumiller --- These values should correspond to how the PVE::CGroup live-apply code works. After this there's 1 more missing piece for pure-

[pve-devel] [PATCH v9 qemu-server] Add API for VM import

2021-06-10 Thread Dominic Jäger
Extend qm importdisk/importovf functionality to the API. Co-authored-by: Fabian Grünbichler Signed-off-by: Dominic Jäger --- v9: unchanged PVE/API2/Qemu.pm | 175 +++-- PVE/API2/Qemu/Makefile | 2 +- PVE/API2/Qemu/OVF.pm | 68 PV

[pve-devel] [PATCH v9 manager] Add GUI to import disk & VM

2021-06-10 Thread Dominic Jäger
Add GUI wizard to import whole VMs and a window to import single disks in Hardware View. Signed-off-by: Dominic Jäger --- v9: Use Tabpanel instead of Advanced Checkbox for disk options PVE/API2/Nodes.pm| 7 + www/manager6/Makefile| 4 + www/manag

[pve-devel] [PATCH] (re)enable V4 xfs support for restore image

2021-06-10 Thread Dominik Csapak
since kernel 5.10, xfs v4 format is deprecated, reenable it for our restore image kernel Signed-off-by: Dominik Csapak --- it is already enabled in our regular 5.11 kernel config, so there should be no problems there src/config-base | 1 + 1 file changed, 1 insertion(+) diff --git a/src/config

Re: [pve-devel] applied-partially: [PATCH-SERIES] Some breaking API changes/cleanups

2021-06-10 Thread Fabian Grünbichler
On June 9, 2021 1:15 pm, Fabian Ebner wrote: > Am 09.06.21 um 11:44 schrieb Fabian Grünbichler: >> applied (with some added version bumps/versioned dependency bumps), >> except for the two storage patches where I replied with nits. >> >> please add stuff to breaking changes and send patches for pv

Re: [pve-devel] [PATCH manager] ui: file-restore: start the file-restore on the selected node

2021-06-10 Thread Stefan Reiter
On 6/10/21 10:40 AM, Dominik Csapak wrote: On 6/10/21 10:23, Stefan Reiter wrote: On 6/10/21 9:37 AM, Dominik Csapak wrote: and not the node where the browser connects. there are at least two good reasons for this: * it is confusing, since the user would expect it to start where    the ui is po

Re: [pve-devel] [PATCH manager] ui: file-restore: start the file-restore on the selected node

2021-06-10 Thread Dominik Csapak
On 6/10/21 10:23, Stefan Reiter wrote: On 6/10/21 9:37 AM, Dominik Csapak wrote: and not the node where the browser connects. there are at least two good reasons for this: * it is confusing, since the user would expect it to start where    the ui is pointint to * the storage may not be available

Re: [pve-devel] [PATCH manager] ui: file-restore: start the file-restore on the selected node

2021-06-10 Thread Stefan Reiter
On 6/10/21 9:37 AM, Dominik Csapak wrote: and not the node where the browser connects. there are at least two good reasons for this: * it is confusing, since the user would expect it to start where the ui is pointint to * the storage may not be available on the node the browser connects to,

[pve-devel] [PATCH manager] ui: file-restore: start the file-restore on the selected node

2021-06-10 Thread Dominik Csapak
and not the node where the browser connects. there are at least two good reasons for this: * it is confusing, since the user would expect it to start where the ui is pointint to * the storage may not be available on the node the browser connects to, but it must be available on the node selected