Re: [pve-devel] RE : RE : pve-devel Digest, Vol 132, Issue 53

2021-05-25 Thread Thomas Lamprecht
Hi, On 25.05.21 22:50, wb wrote: > Sorry, the first mail went a little too fast > >> running does not mean working... > Ok, but starting from an installation, I doubt :). > But you already started to patch around, so we just cannot know for sure - was just mentioning that to cover more possibi

[pve-devel] RE : RE : pve-devel Digest, Vol 132, Issue 53

2021-05-25 Thread wb
> running does not mean working... Ok, but starting from an installation, I doubt :). De : Thomas Lamprecht Envoyé le :mardi 25 mai 2021 08:11 À : Proxmox VE development discussion; wb Objet :Re: [pve-devel] RE : pve-devel Digest, Vol 132, Issue 53 On 24.05.21 23:45, wb wrote: > However, since

Re: [pve-devel] [PATCH container] fix #3443: setup: clear /etc/machine-id in post-create hook

2021-05-25 Thread Thomas Lamprecht
On 25.05.21 15:17, Oguz Bektas wrote: > this way when new containers are created the will have a unique > /etc/machine-id > why the dbus then? systemd talks explicitly only about /etc/machine-id in the docs and also in their CT interface [0], the thematic is only touched there though. The dbus o

[pve-devel] [PATCH widget-toolkit] panel/JournalView: use correct component for masking

2021-05-25 Thread Dominik Csapak
'me' is the controller here, not the view. Signed-off-by: Dominik Csapak --- src/panel/JournalView.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/panel/JournalView.js b/src/panel/JournalView.js index 692f241..11610f5 100644 --- a/src/panel/JournalView.js +++ b/src

[pve-devel] [PATCH manager] fix #3440: influxdb: remove duplicate vmid tag

2021-05-25 Thread Lorenz Stechauner
remove vmid from data part, it is already contained in object part. Signed-off-by: Lorenz Stechauner --- Tested with local udp listener. works as expected. PVE/Status/InfluxDB.pm | 4 1 file changed, 4 insertions(+) diff --git a/PVE/Status/InfluxDB.pm b/PVE/Status/InfluxDB.pm index 9e4b0d

Re: [pve-devel] [PATCH container] setup: make randomize_crontab a state subroutine

2021-05-25 Thread Thomas Lamprecht
On 25.05.21 15:15, Oguz Bektas wrote: > for consistency in post_create_hook. still works as expected > what's the reason/benefit again? > Signed-off-by: Oguz Bektas > --- > src/PVE/LXC/Setup/Base.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/PVE/LXC/Set

[pve-devel] [PATCH container] fix #3443: setup: clear /etc/machine-id in post-create hook

2021-05-25 Thread Oguz Bektas
this way when new containers are created the will have a unique /etc/machine-id note that post_create_hook doesn't run for cloned containers so that will need to be handled separately Signed-off-by: Oguz Bektas --- src/PVE/LXC/Setup/Base.pm | 13 + 1 file changed, 13 insertions(+)

[pve-devel] [PATCH container] setup: make randomize_crontab a state subroutine

2021-05-25 Thread Oguz Bektas
for consistency in post_create_hook. still works as expected Signed-off-by: Oguz Bektas --- src/PVE/LXC/Setup/Base.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/LXC/Setup/Base.pm b/src/PVE/LXC/Setup/Base.pm index d73335b..be41874 100644 --- a/src/PVE/LXC/Se

[pve-devel] applied-series: [PATCH-SERIES zsync] fix #3351: allow keeping a different number of snapshots on source and destination

2021-05-25 Thread Thomas Lamprecht
On 11.05.21 14:59, Fabian Ebner wrote: > by introducing a new dest-maxsnap parameter which can be used to override > maxsnap for the destination side. > > This is useful for backups, as one can potentially save a lot of space on the > source side by keeping fewer snapshots around. > > > Fabian E

Re: [pve-devel] [PATCH v2 container] fix #3421: allow custom storage plugins to support rootfs

2021-05-25 Thread Fabian Ebner
Am 17.05.21 um 11:03 schrieb Lorenz Stechauner: it is now necessary for storages to support the 'rootdir' content in order to create/start containers on them. all native storage plugins already report the rootdir content correctly. For creation, this was already required in the past. For start