[pve-devel] [PATCH proxmox-acme] fix #3390: standalone: explicitly bind to '::'

2021-05-12 Thread Stoiko Ivanov
This patch follows 2f8be3bfda203065b22e60862e5f98d831a46921 from pve-common: Instead of not specifying a listen address, we first try to bind on '::', which usually accepts connections for both ipv4 and ipv6, and fall back to '0.0.0.0' if this fails (if ipv6 is disabled via kernel commandline). Th

[pve-devel] [PATCH qemu-server 9/9] api: update vm: correctly handle warnings status for delayed task

2021-05-12 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- PVE/API2/Qemu.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index c56b609..336aa73 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -1438,7 +1438,7 @@ my $update_vm_api = sub { i

[pve-devel] [PATCH qemu-server 8/9] cli tools: correctly handle warnings task status

2021-05-12 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- Dependency bump for pve-common is needed. PVE/CLI/qm.pm| 2 +- PVE/CLI/qmrestore.pm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index f8972bd..a8ad571 100755 --- a/PVE/CLI/qm.pm +++ b/PVE/CLI/qm.pm

[pve-devel] [PATCH container 7/9] pct: correctly handle warnings task status

2021-05-12 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- Dependency bump for pve-common is needed. src/PVE/CLI/pct.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm index 6b63915..b606c62 100755 --- a/src/PVE/CLI/pct.pm +++ b/src/PVE/CLI/pct.pm @@ -29,7 +29,7

[pve-devel] [PATCH manager 5/9] cli tools: correctly handle warnings status

2021-05-12 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- PVE/CLI/pveceph.pm | 2 +- PVE/CLI/pvenode.pm | 2 +- PVE/CLI/vzdump.pm | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/CLI/pveceph.pm b/PVE/CLI/pveceph.pm index 2745cc62..c02dc3fe 100755 --- a/PVE/CLI/pveceph.pm +++ b/PVE/CLI/pveceph.pm

[pve-devel] [PATCH storage 6/9] api: content: correctly handle warnings status for delayed task

2021-05-12 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- Dependency bump for pve-common is needed. PVE/API2/Storage/Content.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Storage/Content.pm b/PVE/API2/Storage/Content.pm index 8b0e3de..a510e3b 100644 --- a/PVE/API2/Storage/Content.pm +++

[pve-devel] [PATCH manager 3/9] nodes: startall: correctly handle warning status for delayed task

2021-05-12 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- PVE/API2/Nodes.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index e58d9c10..1efba772 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -1810,7 +1810,7 @@ __PACKAGE__->register_method ({

[pve-devel] [PATCH manager 2/9] api/cli: tasks: don't treat warnings status as an error status

2021-05-12 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- Dependency bump for pve-common is needed. PVE/API2/Tasks.pm | 5 - PVE/CLI/pvenode.pm | 5 - 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Tasks.pm b/PVE/API2/Tasks.pm index 8f6ab603..abae8ba3 100644 --- a/PVE/API2/Tasks.pm +++

[pve-devel] [PATCH-SERIES] correctly handle warnings status

2021-05-12 Thread Fabian Ebner
There's a few places where we use the logic "OK" if and only if no error for a task status, but this is no longer true now that we also support ending in a warnings status (not yet used by anything, but the feature is there). Everything depends on the first patch and depedency bumps for pve-common

[pve-devel] [PATCH manager 4/9] cli: pveam: remove unused private sub

2021-05-12 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- PVE/CLI/pveam.pm | 6 -- 1 file changed, 6 deletions(-) diff --git a/PVE/CLI/pveam.pm b/PVE/CLI/pveam.pm index a506aa9b..6c26f209 100644 --- a/PVE/CLI/pveam.pm +++ b/PVE/CLI/pveam.pm @@ -20,12 +20,6 @@ use base qw(PVE::CLIHandler); my $nodename = PVE::INoti

[pve-devel] [PATCH common 1/9] tools: add upid_status_is_error function

2021-05-12 Thread Fabian Ebner
There's also support for ending a task with warnings now, so the logic "status not 'OK' means error" does not work anymore. Signed-off-by: Fabian Ebner --- src/PVE/Tools.pm | 8 1 file changed, 8 insertions(+) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index 16ae3d2..6f205df 1006

Re: [pve-devel] [PATCH pve-container 1/1] add ipam support

2021-05-12 Thread Wolfgang Bumiller
On Mon, May 10, 2021 at 05:37:07PM +0200, Alexandre Derumier wrote: > This add ipam support for nic using sdn vnets. > > - if ips are specified manally, we verify that subnet exist on vnet, and we > register ip in ipam > - if nic is on a vnet, but no ip is specified, we auto find the next > avai

Re: [pve-devel] [PATCH container] fix #3421: allow custom storage plugins to support rootfs

2021-05-12 Thread Fabian Ebner
Had a look at this patch. The idea is fine, but there are a few minor problems that could be avoided. Am 11.05.21 um 13:02 schrieb Lorenz Stechauner: Signed-off-by: Lorenz Stechauner --- src/PVE/LXC.pm | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff

Re: [pve-devel] [PATCH-SERIES 0/4] PBS master key integration

2021-05-12 Thread Fabian Ebner
Am 08.02.21 um 14:08 schrieb Fabian Grünbichler: this series enables master key integration for PVE->PBS, by allowing the configuration of a per-storage master key which is used for (encrypted) VM and CT backups. while the diffs are small, the following bumps/dependencies/.. are required: proxm

[pve-devel] [PATCH v5 manager 7/7] fix #1710: ui: storage: add download from url button

2021-05-12 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/storage/Browser.js | 8 + www/manager6/storage/ContentView.js | 282 +--- 2 files changed, 265 insertions(+), 25 deletions(-) diff --git a/www/manager6/storage/Browser.js b/www/manager6/storage/Browser.js index 5fee9

[pve-devel] [PATCH v5 storage 4/7] status: add download_url method

2021-05-12 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 118 +++-- PVE/Storage.pm | 10 2 files changed, 123 insertions(+), 5 deletions(-) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index 897b4a7..4c1d1fc 10064

[pve-devel] [PATCH-SERIES v5 manager/common/storage] fix #1710: add download from url button

2021-05-12 Thread Lorenz Stechauner
changes to v4: reworked check_file_hash small fixes: typos, default values, etc. patches: 1 - manager: add query_url_metadata method 2 - common: add download_file_from_url 3 - manager: refactor aplinfo to use common download function 4 - storage: add download_url method 5 - manager: add HashAlgori

[pve-devel] [PATCH v5 common 2/7] tools: add download_file_from_url

2021-05-12 Thread Lorenz Stechauner
code is based on manager:PVE/API2/Nodes.pm:aplinfo Signed-off-by: Lorenz Stechauner --- src/PVE/Tools.pm | 124 +++ 1 file changed, 124 insertions(+) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index 16ae3d2..7b82e00 100644 --- a/src/PVE/Tools.pm

[pve-devel] [PATCH v5 manager 5/7] ui: add HashAlgorithmSelector

2021-05-12 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/Makefile | 1 + www/manager6/form/HashAlgorithmSelector.js | 16 2 files changed, 17 insertions(+) create mode 100644 www/manager6/form/HashAlgorithmSelector.js diff --git a/www/manager6/Makefile b/www/mana

[pve-devel] [PATCH v5 manager 6/7] ui: Utils: change download task format

2021-05-12 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/Utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 581d2040..38306c11 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -1819,7 +1819,7 @@ Ext.define('PV

[pve-devel] [PATCH v5 manager 3/7] api: nodes: refactor aplinfo to use common download function

2021-05-12 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/API2/Nodes.pm | 89 ++- 1 file changed, 10 insertions(+), 79 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index a289ef8b..16b10925 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -15

[pve-devel] [PATCH v5 manager 1/7] api: nodes: add query_url_metadata method

2021-05-12 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/API2/Nodes.pm | 96 +++ 1 file changed, 96 insertions(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index e58d9c10..a289ef8b 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -11,6 +11,7 @@ use J