Re: [pve-devel] [pve-manager] Adding real disk usage information (discussion)

2021-04-18 Thread Dominik Csapak
On 4/16/21 22:18, Bruce Wainer wrote: Hello, Hi, I am interested in seeing real disk usage information for VM Disks and CT Volumes, on storage types that have thin provisioning and/or snapshots. Specifically I would like to see "Current Disk Usage (Thin)" and either "Snapshot Usage" or "Tota

Re: [pve-devel] [PATCH-SERIES v2 qemu-server] Cleanup migration code and improve migration disk cleanup

2021-04-18 Thread Fabian Ebner
Ping for this series. Patch #13 conflicts with Mira's proposed change for copying the conntrack information[0]. Patch #1 and Patch #5 are the only ones *not* conflicting with Fabian's remote migration RFC[1]. [0]: https://lists.proxmox.com/pipermail/pve-devel/2021-February/046873.html [1]:

Re: [pve-devel] [PATCH cluster 2/4] add get_remote_info

2021-04-18 Thread Thomas Lamprecht
On 13.04.21 14:16, Fabian Grünbichler wrote: > as a unified helper for talking to a remote node. if the requested node > has an entry in the remote config, the information from that entry is > used. else, the first locally defined node of the requested cluster is > used as proxy. > > Signed-off-b

Re: [pve-devel] sdn: looking to unify .cfg files, need opinions about config format

2021-04-18 Thread Thomas Lamprecht
On 12.01.21 10:19, aderum...@odiso.com wrote: > Hi, > > I'm looking to unify sdn .cfg files with only 1 file, > with something different than section config format. > > We have relationship like zones->vnets->subnets, > so I was thinking about something like this: > > > > [zone myzone] >t

[pve-devel] applied: [PATCH v2 pve-docs]: update link qemu documentation non web.archive

2021-04-18 Thread Thomas Lamprecht
On 11.02.21 08:45, Moayad Almalat wrote: > Signed-off-by: Moayad Almalat > --- > qm.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cg

[pve-devel] applied: [PATCH container 2/2] schema: mention special syntax for allocating a new volume

2021-04-18 Thread Thomas Lamprecht
On 02.03.21 13:02, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > src/PVE/LXC/Config.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.pr

Re: [pve-devel] [PATCH v2 qemu-server 3/4] restore: sanitize config for non-root users

2021-04-18 Thread Thomas Lamprecht
On 18.03.21 10:44, Fabian Ebner wrote: > by dropping privileged options for unprivileged users. For backwards > compatibility for in-place restores, keep the option as long as the value > didn't > change. > > Note that this softly "breaks" restoring a backup with such a privileged > option > und

[pve-devel] applied: [PATCH v2 qemu-server 1/4] test: add tests for restoring config

2021-04-18 Thread Thomas Lamprecht
On 18.03.21 10:44, Fabian Ebner wrote: > Suggested-by: Thomas Lamprecht > Signed-off-by: Fabian Ebner > --- > > New in v2 > > PVE/QemuServer.pm | 10 ++-- > test/Makefile | 5 +- > test/restore-config-expected/139.conf | 16 ++ > test/restore

[pve-devel] applied: [PATCH v2 qemu-server 2/4] restore: update config: remove unused parameter

2021-04-18 Thread Thomas Lamprecht
On 18.03.21 10:44, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > > New in v2 > > PVE/QemuServer.pm | 5 + > test/run_qemu_restore_config_tests.pl | 1 - > 2 files changed, 1 insertion(+), 5 deletions(-) > > applied, thanks! ___

[pve-devel] applied: [PATCH docs] certs: improve wording and styling

2021-04-18 Thread Thomas Lamprecht
On 18.03.21 14:27, Stoiko Ivanov wrote: > porting over the changes done in pmg-docs > > Signed-off-by: Stoiko Ivanov > --- > certificate-management.adoc | 31 +++ > 1 file changed, 15 insertions(+), 16 deletions(-) > > applied, thanks!

[pve-devel] applied: [PATCH qemu-server 4/4] filter by content type when using vdisk_list

2021-04-18 Thread Thomas Lamprecht
On 22.03.21 15:32, Fabian Ebner wrote: > except for migration, where it would be subtly backwards-incompatible. Since > there is a scan_volids call for migration, we can't default to filtering in > scan_volids just yet. > > Also allows to get rid of the existing filtering hack in rescan(). > > Si

[pve-devel] applied: [PATCH container 3/4] filter by content type when using vdisk_list

2021-04-18 Thread Thomas Lamprecht
On 22.03.21 15:32, Fabian Ebner wrote: > except for migration, where it would be subtly backwards-incompatible. > > Also allows to get rid of the existing filtering hack in rescan(). > > Signed-off-by: Fabian Ebner > --- > > Dependency bump for pve-storage is needed. > > src/PVE/LXC.pm | 10 +

[pve-devel] applied: [PATCH qemu-server] drive: volume in-use check: fix fallback path comparison

2021-04-18 Thread Thomas Lamprecht
On 15.04.21 12:10, Fabian Ebner wrote: > When checking whether a volume is still referenced by a snapshot, the void > itself is first checked. When the volid is different, we fall back to > comparing > the path. > > As the first value to be compared is a volume's path, the second value better >

[pve-devel] applied: [PATCH qemu-server] cfg2cmd: fix +pveN machine types with pxe

2021-04-18 Thread Thomas Lamprecht
On 31.03.21 16:39, Stefan Reiter wrote: > Pinned machine versions like "pc-i440fx-4.2+pve2.pxe" would otherwise > get a second "+pve0" suffix, which is incorrect. > > Also deal with non-pve pinned versions correctly, i.e. > "pc-i440fx-5.2.pxe" becomes "pc-i440fx-5.2+pve0.pxe". > > Handle .pxe suf

Re: [pve-devel] [PATCH v5 manager 3/3] ui: qemu: Add disk reassign dialog

2021-04-18 Thread Thomas Lamprecht
On 15.02.21 16:26, Aaron Lauterer wrote: > Adds a new button to the hardware panel labeled 'Reassign disk' and > enables a user to reassign a disk to another VM. > > Signed-off-by: Aaron Lauterer > --- > > v4 -> v5: rebased > > v3 -> v4: > * added check to not show template VMs in dropdown > *

Re: [pve-devel] [PATCH v5 manager 2/3] ui: utils: add method to get VM data from resource store

2021-04-18 Thread Thomas Lamprecht
On 15.02.21 16:26, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > v3 -> v4i -> v5: rebased > v2 -> v3: nothing changed > v1 -> v2: fixed linter errors > > > www/manager6/Utils.js | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/www/manager6/Utils.js b/www/

Re: [pve-devel] [PATCH qemu-server] drive: volume in-use check: fix fallback path comparison

2021-04-18 Thread Thomas Lamprecht
On 15.04.21 12:10, Fabian Ebner wrote: > When checking whether a volume is still referenced by a snapshot, the volid > itself is first checked. When the volid is different, we fall back to > comparing > the path. > > As the first value to be compared is a volume's path, the second value better >

Re: [pve-devel] [PATCH v6 qemu-server 2/5] disk reassign: add API endpoint

2021-04-18 Thread Thomas Lamprecht
On 02.04.21 12:19, Aaron Lauterer wrote: > The goal of this new API endpoint is to provide an easy way to move a > disk between VMs as this was only possible with manual intervention > until now. Either by renaming the VM disk or by manually adding the > disks volid to the config of the other VM. >

Re: [pve-devel] [PATCH v6 qemu-server 3/5] cli: disk reassign: add reassign_disk to qm command

2021-04-18 Thread Thomas Lamprecht
On 02.04.21 12:19, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > v5 -> v6: nothing > v4 -> v5: renamed `drive_key` to `drive_name` > v3 ->v4: nothing > v2 -> v3: renamed parameter `disk` to `drive_key` > rfc -> v1 -> v2: nothing changed > PVE/CLI/qm.pm | 2 ++ > 1 file changed, 2

Re: [pve-devel] Ceph Pacific testing?

2021-04-18 Thread Thomas Lamprecht
Hi, On 18.04.21 00:48, Victor Hooi wrote: > Awesome! Really excited by this! > > Do we have any indication of when this year the PVE 7.0 testing will begin? No, nothing definitive yet, if I had to guess, I'd say that the test repo would get available in Q2 rather than Q3, though. > Also - will