[pve-devel] [PATCH proxmox-backup 3/3] use FileBrowser from proxmox-widget-toolkit

2021-04-01 Thread Stefan Reiter
Signed-off-by: Stefan Reiter --- Requires bumped proxmox-widget-toolkit of course. www/Makefile | 1 - www/datastore/Content.js | 13 +- www/window/FileBrowser.js | 252 -- 3 files changed, 8 insertions(+), 258 deletions(-) delete mode 10064

[pve-devel] [PATCH proxmox-widget-toolkit 2/3] FileBrowser: remove PBS dependencies

2021-04-01 Thread Stefan Reiter
Don't construct any URLs locally, instead have them (and their static parameters) be passed in. This removes the need to have the datastore. Signed-off-by: Stefan Reiter --- src/window/FileBrowser.js | 52 ++- 1 file changed, 19 insertions(+), 33 deletions(-)

[pve-devel] [PATCH proxmox-widget-toolkit 1/3] window: add FileBrowser

2021-04-01 Thread Stefan Reiter
from proxmox-backup, only names changed Signed-off-by: Stefan Reiter --- src/Makefile | 1 + src/window/FileBrowser.js | 248 ++ 2 files changed, 249 insertions(+) create mode 100644 src/window/FileBrowser.js diff --git a/src/Makefile b/src/Ma

[pve-devel] [PATCH 0/3] Move FileBrowser to widget-toolkit

2021-04-01 Thread Stefan Reiter
In preparation for single file restore GUI in PVE. The changes made here include some modifications to the API to make it better useable from there, but are not intended to cause any functional change for PBS. proxmox-widget-toolkit: Stefan Reiter (2): window: add FileBrowser FileBrowser: rem

[pve-devel] [PATCH common 2/2] JSONSchema: don't cycle-check 'download' responses

2021-04-01 Thread Stefan Reiter
Signed-off-by: Stefan Reiter --- Note that this happens before the result is put in '->{data}' so that part of the previous patch is not necessary here. src/PVE/JSONSchema.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm in

[pve-devel] [PATCH http-server 1/2] allow 'download' to be passed from API handler

2021-04-01 Thread Stefan Reiter
PVE::HTTPServer in pve-manager wraps the API return value in a 'data' element, look for a 'download' element there too to allow an API call to instruct the HTTP server to return a file via path or filehandle. Signed-off-by: Stefan Reiter --- This will be needed for the single file restore API.

Re: [pve-devel] [PATCH storage 1/2] rbd: fix #3286 add namespace support

2021-04-01 Thread Thomas Lamprecht
On 01.04.21 15:40, Aaron Lauterer wrote: > This patch introduces support for Cephs RBD namespaces. > > A new storage config parameter 'namespace' defines the namespace to be > used for the RBD storage. > > The namespace must already exist in the Ceph cluster as it is not > automatically created.

Re: [pve-devel] [PATCH storage 2/2] rbd: add integration test for namespace handling

2021-04-01 Thread Thomas Lamprecht
On 01.04.21 15:40, Aaron Lauterer wrote: > This test is intended to be run on a hyperconverged PVE cluster to test > the most common operations of VMs using a namespaced Ceph RBD pool. > > Signed-off-by: Aaron Lauterer > --- > > Could probably be done nicer here and there but it worked (except f

[pve-devel] [PATCH storage 1/2] smartctl: remove to-be-replaced disk_tests

2021-04-01 Thread Oguz Bektas
Signed-off-by: Oguz Bektas --- test/disk_tests/cciss/cciss!c0d0/device/model | 1 - .../disk_tests/cciss/cciss!c0d0/device/vendor | 1 - .../cciss/cciss!c0d0/queue/rotational | 1 - test/disk_tests/cciss/cciss!c0d0/size | 1 - test/disk_tests/cciss/cciss!c0d0_udevadm

[pve-devel] [PATCH v2 storage 2/2] smartctl: use json parsing

2021-04-01 Thread Oguz Bektas
adapt the smartctl endpoint to run smartctl with the --json or -j flag to parse it more reasonably. additionally add the $format parameter to assist in switching to the new json parsed output for nvme devices in PVE 7.0 (until 7.0 removing the 'text' field completely would be a breaking change, so

Re: [pve-devel] [PATCH v5 qemu-server 2/5] disk reassign: add API endpoint

2021-04-01 Thread Aaron Lauterer
On 3/31/21 11:23 AM, Fabian Grünbichler wrote: sorry for the long pause - haven't checked the GUI part, but that should be unaffected by my comments in-line. thanks and yes, the GUI should be oblivious to any changes here On December 15, 2020 1:48 pm, Aaron Lauterer wrote: The goal of thi

[pve-devel] [PATCH storage 2/2] smartctl: use json parsing

2021-04-01 Thread Oguz Bektas
adapt the smartctl endpoint to run smartctl with the --json or -j flag to parse it more reasonably. also add the $format parameter to assist in switching to the new json parsed output for nvme devices in PVE 7.0 (until 7.0 removing the 'text' field completely would be a breaking change, so we stil

[pve-devel] [PATCH storage 2/2] rbd: add integration test for namespace handling

2021-04-01 Thread Aaron Lauterer
This test is intended to be run on a hyperconverged PVE cluster to test the most common operations of VMs using a namespaced Ceph RBD pool. Signed-off-by: Aaron Lauterer --- Could probably be done nicer here and there but it worked (except for the sometimes racy rollback ...) and should help to

[pve-devel] [PATCH storage 1/2] rbd: fix #3286 add namespace support

2021-04-01 Thread Aaron Lauterer
This patch introduces support for Cephs RBD namespaces. A new storage config parameter 'namespace' defines the namespace to be used for the RBD storage. The namespace must already exist in the Ceph cluster as it is not automatically created. The main intention is to use this for external Ceph cl

Re: [pve-devel] [PATCH v3 manager 2/4] api: vzdump: add call to get currently configured vzdump defaults

2021-04-01 Thread Thomas Lamprecht
On 11.03.21 10:22, Fabian Ebner wrote: > on a given node (and storage). > > Signed-off-by: Fabian Ebner > --- > > New in v3 > > PVE/API2/VZDump.pm | 89 ++ > 1 file changed, 89 insertions(+) > > diff --git a/PVE/API2/VZDump.pm b/PVE/API2/VZDump.pm >

[pve-devel] applied: [PATCH v7 storage] Optionally allow blockdev in abs_filesystem_path

2021-04-01 Thread Thomas Lamprecht
On 26.03.21 13:32, Dominic Jäger wrote: > This is required to import from LVM storages, for example > > Signed-off-by: Dominic Jäger > --- > v6->v7: Feedback Fabian G > - Variables with _ instead of camelCase > - single if instead of if/else > > PVE/Storage.pm | 8 > 1 file changed,

[pve-devel] applied: [PATCH v3 manager 1/4] vzdump: storage info: move out activate storage call

2021-04-01 Thread Thomas Lamprecht
On 11.03.21 10:22, Fabian Ebner wrote: > Otherwise storage_info() cannot be used for (at least) PBS storages from an > API > call without 'protected => 1', because the password cannot be read from > '/etc/pve/priv'. Note that the function itself does not need the storage to be > active, because it

Re: [pve-devel] [PATCH v7 qemu-server] Add API for import wizards

2021-04-01 Thread Fabian Grünbichler
On April 1, 2021 12:19 pm, Dominic Jäger wrote: > On Wed, Mar 31, 2021 at 05:12:28PM +0200, Fabian Grünbichler wrote: >> this is starting to shape up nicely. as promised, I now took a stab at >> (roughly!) integrating this into our regular flow (see diff below): >> >> >> - we could likely dr

Re: [pve-devel] [PATCH qemu-server 1/6] cloudinit: add cloudinit section for current generated config.

2021-04-01 Thread aderumier
Le jeudi 01 avril 2021 à 10:54 +0200, Thomas Lamprecht a écrit : > > actually, why isn't the pending section enough for this? > > If stuff can be hot plugged then we can do so and if only that > changed we > can just remove it from pending, as normally? Well, for example, if you change the vm na

Re: [pve-devel] [PATCH v7 qemu-server] Add API for import wizards

2021-04-01 Thread Dominic Jäger
On Wed, Mar 31, 2021 at 05:12:28PM +0200, Fabian Grünbichler wrote: > this is starting to shape up nicely. as promised, I now took a stab at > (roughly!) integrating this into our regular flow (see diff below): > > > - we could likely drop the separate import_disk API call, and let the >

Re: [pve-devel] [PATCH qemu-server 1/6] cloudinit: add cloudinit section for current generated config.

2021-04-01 Thread Thomas Lamprecht
On 28.03.21 17:11, Alexandre Derumier wrote: > Instead using vm pending options for pending cloudinit generated config, > > write current generated cloudinit config in a new [special:cloudinit] SECTION. > > Currently, some options like vm name, nic mac address can be hotplugged, > so they are not