Re: [pve-devel] [pbs-devel] [PATCH v2 proxmox-backup-qemu 05/11] access: use bigger cache and LRU chunk reader

2021-03-17 Thread Dietmar Maurer
What about using a memory mapped files as cache. That way, you do not need to care about available memory? > >> Maybe we could get the available memory and use that as hint, I mean as > >> memory > >> usage can be highly dynamic it will never be perfect, but better than just > >> ignoring > >> i

Re: [pve-devel] [PATCH v2 proxmox-backup-qemu 05/11] access: use bigger cache and LRU chunk reader

2021-03-17 Thread Thomas Lamprecht
On 17.03.21 14:37, Stefan Reiter wrote: > On 16/03/2021 21:17, Thomas Lamprecht wrote: >> On 03.03.21 10:56, Stefan Reiter wrote: >>> Values chosen by fair dice roll, seems to be a good sweet spot on my >>> machine where any less causes performance degradation but any more >>> doesn't really make i

Re: [pve-devel] [PATCH v2 proxmox-backup-qemu 05/11] access: use bigger cache and LRU chunk reader

2021-03-17 Thread Stefan Reiter
On 16/03/2021 21:17, Thomas Lamprecht wrote: On 03.03.21 10:56, Stefan Reiter wrote: Values chosen by fair dice roll, seems to be a good sweet spot on my machine where any less causes performance degradation but any more doesn't really make it go any faster. Keep in mind that those values are p

[pve-devel] [PATCH v2 storage] fix #3348: NFS: select correct transport to check for service

2021-03-17 Thread Fabian Ebner
Suggested-by: Thomas Lamprecht Signed-off-by: Fabian Ebner --- Changes from v1: * use existing helper functions to determine the correct transport type PVE/Storage/NFSPlugin.pm | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/PVE/Storage/NFSPlugin.pm b/PVE/St

[pve-devel] [PATCH qemu-server] vzdump: improve error logging for query-proxmox-support

2021-03-17 Thread Stefan Reiter
Only show "not supported by QEMU version" message if we determine that to be the actual cause, just print the error otherwise. Signed-off-by: Stefan Reiter --- PVE/VZDump/QemuServer.pm | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/PVE/VZDump/QemuServer.pm b/PVE

[pve-devel] [PATCH storage] fix #3348: Revert "NFS: avoid using obsolete rpcinfo option"

2021-03-17 Thread Fabian Ebner
This reverts commit 816dadb17f8e28d7a0a092c055c0c07b6038e64c. With '-T' one needs to specify either 'tcp' or 'tcp6', and using 'tcp' doesn't work for an IPv6-only server. Simply switch back to using '-t', because $server might also just be a host name, so it's not really worth adding extra code (a

[pve-devel] applied: [PATCH pve-docs] pvesm: mark pbs storage as stable

2021-03-17 Thread Thomas Lamprecht
On 16.03.21 13:26, Dylan Whyte wrote: > Signed-off-by: Dylan Whyte > --- > > pvesm.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cg

Re: [pve-devel] [pbs-devel] [PATCH-SERIES] improve warnings handling in UI and add to PVE

2021-03-17 Thread Fabian Ebner
Am 16.03.21 um 15:02 schrieb Dominik Csapak: series looks good to me, the only thing that might be not ideal is the value.replace('WARNINGS', '') call. it seems very brittle though in reality it will probably not be a problem Reviewed-By: Dominik Csapak Thanks for the review. I'm also not 10