Re: [pve-devel] cloudinit: question about cloudinit pending values && hostname/mac address changes

2021-03-05 Thread aderumier
Hi, I just send a small patch, adding a new hotplug option: cloudinit, to autoregenerate config drive when cloudinit option are updated. What do you think about it ?  (Like this user can choose the behaviour) Le mardi 23 février 2021 à 10:29 +0100, Thomas Lamprecht a écrit : > On 23.02.21 10:06

[pve-devel] [PATCH qemu-server] add clouinit hotplug feature

2021-03-05 Thread Alexandre Derumier
This add a new cloudinit hotplug feature, to auto-regenerate the cloudinit drive when cloudinit options are changed. Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/Qem

[pve-devel] applied: [PATCH manager 7/7] ui: MachineEdit: add option for machine version pinning

2021-03-05 Thread Thomas Lamprecht
On 04.03.21 13:52, Stefan Reiter wrote: > Hidden behind "Advanced" options, as to not confuse inexperienced users. > > Signed-off-by: Stefan Reiter > --- > www/manager6/qemu/MachineEdit.js | 69 > 1 file changed, 69 insertions(+) > > applied, and reworked quite

[pve-devel] applied: [PATCH manager 6/7] ui: create MachineEdit window

2021-03-05 Thread Thomas Lamprecht
On 04.03.21 13:52, Stefan Reiter wrote: > no functional change intended > > Signed-off-by: Stefan Reiter > --- > www/manager6/Makefile | 1 + > www/manager6/qemu/HardwareView.js | 16 + > www/manager6/qemu/MachineEdit.js | 38 +++ > 3 files c

[pve-devel] applied: [PATCH manager 5/7] api: register Qemu::Machine call

2021-03-05 Thread Thomas Lamprecht
On 04.03.21 13:52, Stefan Reiter wrote: > as 'machine-types', so it is clear this refers to QEMU machines, not the > local machine (as one might think, this being a 'node' API call). > > Signed-off-by: Stefan Reiter > --- > > Requires dependency bump on updated qemu-server. > > PVE/API2/Nodes.

[pve-devel] NAK: [PATCH qemu-server 4/7] add postinst with Windows device incompatibility workaround

2021-03-05 Thread Thomas Lamprecht
On 04.03.21 13:52, Stefan Reiter wrote: > ...for QEMU 5.2 > > Add a postinst with some inline perl (to avoid having to install a > seperate file to run) that conservatively does its best to set the > machine version for all VMs the bug might affect to 5.1. > > Signed-off-by: Stefan Reiter > ---

[pve-devel] applied: [PATCH pve-qemu 2/7] add ACPI compat patch for 5.1 and older machine types

2021-03-05 Thread Thomas Lamprecht
On 04.03.21 13:52, Stefan Reiter wrote: > Signed-off-by: Stefan Reiter > --- > > This is required to make the whole deal work, otherwise even setting back the > machine version to 5.1 or lower won't actually fix the issue. > > ...restore-device-paths-for-pre-5.1-vms.patch | 108

[pve-devel] applied: [PATCH qemu-server 3/7] api: add Machine module to query machine types

2021-03-05 Thread Thomas Lamprecht
On 04.03.21 13:52, Stefan Reiter wrote: > The file is provided by pve-qemu-kvm. > > Signed-off-by: Stefan Reiter > --- > PVE/API2/Qemu/Machine.pm | 49 > PVE/API2/Qemu/Makefile | 2 +- > 2 files changed, 50 insertions(+), 1 deletion(-) > create mode 1

[pve-devel] applied: [PATCH pve-qemu 1/7] add static supported machines file

2021-03-05 Thread Thomas Lamprecht
On 04.03.21 13:52, Stefan Reiter wrote: > Same rationale as the CPU flags file, avoids calling QEMU binary just to > query machine types. > > Signed-off-by: Stefan Reiter > --- > debian/parse-machines.pl | 21 + > debian/rules | 4 +++- > 2 files changed, 24 inse

[pve-devel] applied: [PATCH v2 manager 2/3] partially fix #2745: vzdump: use default for remove parameter

2021-03-05 Thread Thomas Lamprecht
On 03.03.21 12:50, Fabian Ebner wrote: > The initial default from the $confdesc is 1 anyways, and like > this changing the default in /etc/vzdump.conf to 0 actually works. > > Signed-off-by: Fabian Ebner > --- > PVE/VZDump.pm | 2 -- > 1 file changed, 2 deletions(-) > > applied, thanks!

Re: [pve-devel] [PATCH v2 manager 3/3] fix #2745: ui: backup: allow users to specify remove=1

2021-03-05 Thread Thomas Lamprecht
On 03.03.21 12:50, Fabian Ebner wrote: > A user with Datastore.AllocateSpace, VM.Audit, VM.Backup can already remove > backups from the GUI manually, so it shouldn't be a problem if they can set > the remove flag when starting a manual backup in the GUI. > > Signed-off-by: Fabian Ebner > --- > >

[pve-devel] applied: [PATCH v2 guest-common 1/3] mention prune behavior for the remove parameter

2021-03-05 Thread Thomas Lamprecht
On 03.03.21 12:50, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > > First version here (it's been a while): > https://lists.proxmox.com/pipermail/pve-devel/2020-October/045585.html > > Changes from v1: > * Space lines more evenly to get below 80 char limit. > > PVE/VZDump/Common

Re: [pve-devel] qm set in bytes

2021-03-05 Thread Gandalf Corvotempesta
It's not rounded, i get an error saying i have to match the block size Il ven 5 mar 2021, 17:55 Thomas Lamprecht ha scritto: > On 05.03.21 17:25, Gandalf Corvotempesta wrote: > > Ciao, > > i'm almost done in creating a script to directly import a XenServer VM > > storage to Proxmox (without expo

Re: [pve-devel] qm set in bytes

2021-03-05 Thread Thomas Lamprecht
On 05.03.21 17:25, Gandalf Corvotempesta wrote: > Ciao, > i'm almost done in creating a script to directly import a XenServer VM > storage to Proxmox (without exporting the XVA file, decompress, > convert and so on). > > I just need to know how to create ad attach a ZFS volume to an > existing PVE

[pve-devel] qm set in bytes

2021-03-05 Thread Gandalf Corvotempesta
Ciao, i'm almost done in creating a script to directly import a XenServer VM storage to Proxmox (without exporting the XVA file, decompress, convert and so on). I just need to know how to create ad attach a ZFS volume to an existing PVE VM, in bytes. In example, my source disk is 4311744512 how ca

[pve-devel] applied: [PATCH widget-toolkit] panel/DiskList: return empty text for status on partitions

2021-03-05 Thread Thomas Lamprecht
On 05.03.21 12:03, Dominik Csapak wrote: > instead of returning 'unknown' > > Signed-off-by: Dominik Csapak > --- > src/panel/DiskList.js | 5 + > 1 file changed, 5 insertions(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.p

[pve-devel] [PATCH v5 qemu-server] Add API for import wizards

2021-03-05 Thread Dominic Jäger
Extend qm importdisk/importovf functionality to the API. Signed-off-by: Dominic Jäger --- v4->v5: Feedback by Fabian Grünbichler Use more existing helpers, parse more, change signature of import helper function, more detailed errors esp. for API, ... Remaining todo: Some error cases still requir

[pve-devel] [PATCH v5 manager] gui: Add import for disk & VM

2021-03-05 Thread Dominic Jäger
Add GUI wizard to import whole VMs and a window to import single disks in Hardware View. Signed-off-by: Dominic Jäger --- v4->v5: unchanged Remaining todo: Refactor PVE/API2/Nodes.pm | 40 +++ www/manager6/Makefile | 2 + www/manager6/Workspace.js

[pve-devel] [PATCH v5 storage] Optionally allow blockdev in abs_filesystem_path

2021-03-05 Thread Dominic Jäger
This is required to import from LVM storages Signed-off-by: Dominic Jäger --- v4->v5: New PVE/Storage.pm | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index 8ee2c92..7c2e24e 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -609,7

[pve-devel] [PATCH widget-toolkit] panel/DiskList: return empty text for status on partitions

2021-03-05 Thread Dominik Csapak
instead of returning 'unknown' Signed-off-by: Dominik Csapak --- src/panel/DiskList.js | 5 + 1 file changed, 5 insertions(+) diff --git a/src/panel/DiskList.js b/src/panel/DiskList.js index b67fbd1..cbf163c 100644 --- a/src/panel/DiskList.js +++ b/src/panel/DiskList.js @@ -11,6 +11,11 @@ E

Re: [pve-devel] [PATCH qemu-server 4/7] add postinst with Windows device incompatibility workaround

2021-03-05 Thread Fabian Ebner
Am 04.03.21 um 13:52 schrieb Stefan Reiter: ...for QEMU 5.2 Add a postinst with some inline perl (to avoid having to install a seperate file to run) that conservatively does its best to set the machine version for all VMs the bug might affect to 5.1. Signed-off-by: Stefan Reiter --- Requires