Re: [pve-devel] cloudinit: question about cloudinit pending values && hostname/mac address changes

2021-02-23 Thread aderumier
>>normally the CI service reads this only once at startup and then >>should >>wait on events? >>Anything basing on a CD ROM device should be able to handle ejects or >>inject at any time... >>@Alexandre, did you test how good the Cloudinit clients handle this? I'm able to change the cdrom with

[pve-devel] [PATCH v3 container] fix #3313: recover unprivileged bit from old config during pct restore

2021-02-23 Thread Oguz Bektas
since pct defaults to privileged containers, it restores the container as privileged when `--unprivileged 1` is not passed. instead we should check the old configuration and retrieve it from there. this way, when one creates an unprivileged container on GUI, it will be still restored as unprivile

Re: [pve-devel] [PATCH v2 container] fix #3313: recover unprivileged bit from old config during pct restore

2021-02-23 Thread Thomas Lamprecht
On 23.02.21 15:36, Oguz Bektas wrote: > hi, > > On Tue, Feb 23, 2021 at 03:21:28PM +0100, Thomas Lamprecht wrote: >> On 23.02.21 13:29, Oguz Bektas wrote: >>> since pct defaults to privileged containers, it restores the container >>> as privileged when `--unprivileged 1` is not passed. >>> >>> ins

Re: [pve-devel] [PATCH v2 container] fix #3313: recover unprivileged bit from old config during pct restore

2021-02-23 Thread Oguz Bektas
hi, On Tue, Feb 23, 2021 at 03:21:28PM +0100, Thomas Lamprecht wrote: > On 23.02.21 13:29, Oguz Bektas wrote: > > since pct defaults to privileged containers, it restores the container > > as privileged when `--unprivileged 1` is not passed. > > > > instead we should check the old configuration a

Re: [pve-devel] [PATCH v2 container] fix #3313: recover unprivileged bit from old config during pct restore

2021-02-23 Thread Thomas Lamprecht
On 23.02.21 13:29, Oguz Bektas wrote: > since pct defaults to privileged containers, it restores the container > as privileged when `--unprivileged 1` is not passed. > > instead we should check the old configuration and retrieve it > from there. > > this way, when one creates an unprivileged cont

Re: [pve-devel] [PATCH v2 container] fix #3313: recover unprivileged bit from old config during pct restore

2021-02-23 Thread Fabian Ebner
Works for me and also fixes the "template restore as non-root" issue that apparently nobody complained about. It was a bit confusing to think about $orig_mp_param, whose assignment is now also not guarded by $is_root anymore. But if $orig_mp_param is used, i.e. if we enter the if ($stora

[pve-devel] [PATCH v2 container] fix #3313: recover unprivileged bit from old config during pct restore

2021-02-23 Thread Oguz Bektas
since pct defaults to privileged containers, it restores the container as privileged when `--unprivileged 1` is not passed. instead we should check the old configuration and retrieve it from there. this way, when one creates an unprivileged container on GUI, it will be still restored as unprivile

Re: [pve-devel] cloudinit: question about cloudinit pending values && hostname/mac address changes

2021-02-23 Thread Thomas Lamprecht
On 23.02.21 10:06, Wolfgang Bumiller wrote: > >> On 02/23/2021 9:27 AM Thomas Lamprecht wrote: >> >> >> On 21.02.21 18:47, aderum...@odiso.com wrote: >>> I have some question about cloudinit hotplug pending values. >>> >>> Currently, when vm is running, we keep cloudinit specific values >>> (ip

Re: [pve-devel] cloudinit: question about cloudinit pending values && hostname/mac address changes

2021-02-23 Thread Wolfgang Bumiller
> On 02/23/2021 9:27 AM Thomas Lamprecht wrote: > > > On 21.02.21 18:47, aderum...@odiso.com wrote: > > I have some question about cloudinit hotplug pending values. > > > > Currently, when vm is running, we keep cloudinit specific values > > (ipconfigX, dns, ssh,...) in pending until we reg

Re: [pve-devel] [PATCH container] fix #3313: recover unprivileged bit from old config during pct restore

2021-02-23 Thread Thomas Lamprecht
On 22.02.21 16:03, Oguz Bektas wrote: > since pct defaults to privileged containers, it restores the container > as privileged when `--unprivileged 1` is not passed. > > instead we should check the old configuration and retrieve it > from there. > > this way, when one creates an unprivileged cont

Re: [pve-devel] cloudinit: question about cloudinit pending values && hostname/mac address changes

2021-02-23 Thread Thomas Lamprecht
On 21.02.21 18:47, aderum...@odiso.com wrote: > I have some question about cloudinit hotplug pending values. > > Currently, when vm is running, we keep cloudinit specific values > (ipconfigX, dns, ssh,...) in pending until we regenerate image > manually. > > But some other change, like vm name