Re: [pve-devel] [PATCH qemu-server 2/4] savevm: periodically print progress

2021-02-05 Thread Thomas Lamprecht
much thanks in general for following up on my request, this irked me since almost ever. a few nits inline. On 04.02.21 13:52, Stefan Reiter wrote: > Signed-off-by: Stefan Reiter > --- > PVE/QemuConfig.pm | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/PVE/QemuConfig.pm

Re: [pve-devel] [PATCH qemu-server 1/4] vzdump: use renderers from Tools instead of duplicating code

2021-02-05 Thread Thomas Lamprecht
On 04.02.21 13:52, Stefan Reiter wrote: > CLIFormatter, though maybe not perfectly named, already has functions > doing the same task - use those. > > Signed-off-by: Stefan Reiter > --- > > Wanted to move these to a shared location to use in the next patch, found that > we already had functions

Re: [pve-devel] [PATCH pve-manager 1/2] api2: add suspendall endpoint

2021-02-05 Thread Thomas Lamprecht
On 05.02.21 11:35, Hannes Laimer wrote: Missing reference to bug #804 which this patch addresses. https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages Mentioning that this is mostly a 1:1 copy of the stop-, start-, all methods would also be good; improves confidence in

Re: [pve-devel] [PATCH pve-manager 0/2] add pause bulk action

2021-02-05 Thread Thomas Lamprecht
On 05.02.21 11:35, Hannes Laimer wrote: > Add "Pause" to available bulk actions, only VMs can be paused(suspended). > as mentioned off-list, this is not pause (or at least should not be), but hibernation or also called suspension. There exists also a pause in QEMU, which is just pausing running

[pve-devel] [PATCH pve-manager 1/2] api2: add suspendall endpoint

2021-02-05 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- PVE/API2/Nodes.pm | 113 ++ 1 file changed, 113 insertions(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 8172231e..0c11fe35 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -1943,6 +1943,119 @@ __

[pve-devel] [PATCH pve-manager 0/2] add pause bulk action

2021-02-05 Thread Hannes Laimer
Add "Pause" to available bulk actions, only VMs can be paused(suspended). Hannes Laimer (2): api2: add suspendall endpoint ui: add "Bulk Pause" action to node PVE/API2/Nodes.pm | 113 www/manager6/Utils.js | 1 + www/manager6/form/VM

[pve-devel] [PATCH pve-manager 2/2] ui: add "Bulk Pause" action to node

2021-02-05 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- www/manager6/Utils.js | 1 + www/manager6/form/VMSelector.js | 10 ++ www/manager6/node/CmdMenu.js| 15 +++ www/manager6/node/Config.js | 13 + 4 files changed, 39 insertions(+) diff --git a/www/manager6/Utils.js

[pve-devel] [PATCH v4 manager] gui: Add import wizard for disk & VM

2021-02-05 Thread Dominic Jäger
Add GUI wizard to import whole VMs and a window to import single disks in Hardware View. Signed-off-by: Dominic Jäger --- The wizard works, but there is still quite some refactoring to do v3->v4: * Allow only root * Adapt to API changes PVE/API2/Nodes.pm | 40 +++ www/

[pve-devel] [PATCH v4 qemu-server] Add API for disk & VM import

2021-02-05 Thread Dominic Jäger
Extend qm importdisk/importovf functionality to the API. qm can be adapted to use this later. Signed-off-by: Dominic Jäger --- Biggest v3->v4 changes: * New code instead of bloating update_vm_api * Don't change anything in the existing schema, use new parameter "diskimages" * Because this can hap

Re: [pve-devel] [PATCH qemu-server v2] copy conntrack information on migration

2021-02-05 Thread Mira Limbeck
On 2/5/21 9:11 AM, Fabian Ebner wrote: Am 03.02.21 um 15:25 schrieb Mira Limbeck: Requires the pve-conntrack-tool. On migration the conntrack information from the source node is dumped and sent to the target node where it is then inserted. This helps with open connections during migration when t

Re: [pve-devel] [PATCH manager 4/4] ui: snapshot: show task viewer for progress log

2021-02-05 Thread Fabian Ebner
Am 04.02.21 um 13:52 schrieb Stefan Reiter: Signed-off-by: Stefan Reiter --- www/manager6/window/Snapshot.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/www/manager6/window/Snapshot.js b/www/manager6/window/Snapshot.js index 2fa97041..a5fddd0f 100644 --- a/www/manage

Re: [pve-devel] [PATCH qemu-server v2] copy conntrack information on migration

2021-02-05 Thread Fabian Ebner
Am 03.02.21 um 15:25 schrieb Mira Limbeck: Requires the pve-conntrack-tool. On migration the conntrack information from the source node is dumped and sent to the target node where it is then inserted. This helps with open connections during migration when the firewall is active. A new 'migrate-c