[pve-devel] [PATCH v2 pve-installer] installer: minor language fixup

2020-12-10 Thread Dylan Whyte
just some nitpicky changes. v2: - remove tag files @Thomas: Like you thought, they are autogenerated by some vim plugin. They usually sit quitely in the untracked files, but this time, I guess I somehow I managed to add them in without noticing.. Apologies! Signed-off-by: Dylan Whyte --- html-p

Re: [pve-devel] [pve-manager] sdn: Adding phpIPAM as IPAM provider

2020-12-10 Thread Bruce Wainer
Great thanks, I thought I had seen it in one of the patches but when I looked back at some of the more recent submissions it looked like only the internal IPAM was being implemented at first. Bruce On Thu, Dec 10, 2020 at 3:33 AM alexandre derumier wrote: > Hi, > phpIPAM is already implemented :

[pve-devel] applied-series: [PATCH http-server v3 0/4] improve error handling in accept_connections

2020-12-10 Thread Thomas Lamprecht
On 10.12.20 15:02, Stoiko Ivanov wrote: > v2->v3: > * incorporated Thomas patient and excellent feedback (Thanks!!): > * replaced the two error-flags by a single handle_creation flag, based > on the observation that the code after AnyEvent::Handle->new() does not die > (and that we'd probably

Re: [pve-devel] [PATCH pve-installer] installer: minor language fixup

2020-12-10 Thread Thomas Lamprecht
On 26.11.20 10:29, Dylan Whyte wrote: > just some nitpicky changes. > > Signed-off-by: Dylan Whyte > --- > html-common/tags| 1 + > html-pbs/page1.htm | 2 +- > html-pbs/tags | 1 + > html-pve/page1.htm | 8 > html-pve/passwd.htm | 10 +- > html-pve/tags |

[pve-devel] applied-series: [PATCH installer 0/3] memorize keyboard layout and run setupcon in background

2020-12-10 Thread Thomas Lamprecht
On 10.11.20 15:15, Stoiko Ivanov wrote: > This patchset addresses the issue found by Oguz with setupcon slowing down the > GUI. > > After some discussion off-list with Thomas and Oguz 2 thinks were considered > worth improving: > * memorize the chosen keyboard layout and don't jump back to the one

[pve-devel] [RFC pve-qemu] disable jemalloc

2020-12-10 Thread Stefan Reiter
jemalloc does not play nice with our Rust library (proxmox-backup-qemu), specifically it never releases memory allocated from Rust to the OS. This leads to a problem with larger caches (e.g. for the PBS block driver). It appears to be related to this GitHub issue: https://github.com/jemalloc/jemal

[pve-devel] [PATCH http-server v3 2/4] accept-phase: fix conn_count "leak"

2020-12-10 Thread Stoiko Ivanov
When handling new connections in 'accept_connections' the number of active connections (conn_count) got increased before the callback, which would eventually decrease it got registered in AnyEvent::Handle->new. Any error/die before registering the callback would skip the decrement, and leave the p

[pve-devel] [PATCH http-server v3 3/4] accept-phase: shutdown socket on early error

2020-12-10 Thread Stoiko Ivanov
if an error happens before AnyEvent::Handle registers the cleanup callback, we should shutdown/close the socket, when handling it. Using close, instead of shutdown($sock, SHUT_WR) here, since we are in an error-state, and would not read from the socket anyways. (Additionally close sends just on pa

[pve-devel] [PATCH http-server v3 0/4] improve error handling in accept_connections

2020-12-10 Thread Stoiko Ivanov
v2->v3: * incorporated Thomas patient and excellent feedback (Thanks!!): * replaced the two error-flags by a single handle_creation flag, based on the observation that the code after AnyEvent::Handle->new() does not die (and that we'd probably still shutdown the socket if it did) * replaced th

[pve-devel] [PATCH http-server v3 1/4] add debug print helper

2020-12-10 Thread Stoiko Ivanov
and uniformly use it Suggested-by: Thomas Lamprecht Signed-off-by: Stoiko Ivanov --- PVE/APIServer/AnyEvent.pm | 32 +--- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/PVE/APIServer/AnyEvent.pm b/PVE/APIServer/AnyEvent.pm index c55da7f..b8c28ce 1006

[pve-devel] [PATCH http-server v3 4/4] add debug log for problems during accept

2020-12-10 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- PVE/APIServer/AnyEvent.pm | 4 1 file changed, 4 insertions(+) diff --git a/PVE/APIServer/AnyEvent.pm b/PVE/APIServer/AnyEvent.pm index d3b48b7..8a1af54 100644 --- a/PVE/APIServer/AnyEvent.pm +++ b/PVE/APIServer/AnyEvent.pm @@ -1544,6 +1544,7 @@ sub check_ho

Re: [pve-devel] [PATCH pve_flutter_frontend v2 0/3] Add first welcome screen

2020-12-10 Thread Thomas Lamprecht
On 20.11.20 14:27, Aaron Lauterer wrote: > This patch series introduces a "first welcome screen" shown on first > start. > > Additionally, a class that stores the proxmox corporate identity (CI) > colors is introduced. > > Changes to v1: > * rework welcome screens, mainly use buttons instead of t

[pve-devel] [PATCH qemu-server] qm destroy: Extend --purge description

2020-12-10 Thread Dominic Jäger
Add replication jobs & HA. This makes the enumeration complete. Signed-off-by: Dominic Jäger --- PVE/API2/Qemu.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 00d98ab..693348d 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@

Re: [pve-devel] [pve-manager] sdn: Adding phpIPAM as IPAM provider

2020-12-10 Thread alexandre derumier
Hi, phpIPAM is already implemented :) (currently phpIPAM && netbox) On 09/12/2020 20:01, Bruce Wainer wrote: Hello, In your new SDN environment, are there plans for a plugin for phpIPAM? If not, can you provide any starting points for developing one? Thank you, Bruce Wainer __

[pve-devel] [PATCH docs] qm/pct: Add explanation for --purge

2020-12-10 Thread Dominic Jäger
This was apparently not clear enough. For example, see #3184. A bit long, but I think this is a better place for additional information about ACL and firewall than the GUI tooltip or the API parameter description. Signed-off-by: Dominic Jäger --- pct.adoc | 10 ++ qm.adoc | 8

[pve-devel] [PATCH manager] safe destroy: Add HA to purge tooltip

2020-12-10 Thread Dominic Jäger
This makes the enumeration complete. Signed-off-by: Dominic Jäger --- www/manager6/window/SafeDestroy.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/window/SafeDestroy.js b/www/manager6/window/SafeDestroy.js index cc32f6e0..4506fad3 100644 --- a/www/manager6