Re: [pve-devel] [RFC PATCH] fix #3106: correctly queue incoming connections

2020-11-03 Thread Dietmar Maurer
Answering myself, this works as expected. I now simply use Arc::new(()) to count references. > On 11/03/2020 6:45 PM Dietmar Maurer wrote: > > > > > +Ok((sock, _addr)) => { > > > +sock.set_nodelay(true).unwrap(); > > > +let _ = set_tcp_

[pve-devel] [PATCH qemu-server 1/3] vmstatus: add hostcpu value

2020-11-03 Thread Alexandre Derumier
--- PVE/QemuServer.pm | 11 +++ 1 file changed, 11 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index af74d64..0c2b1db 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2647,8 +2647,11 @@ sub vmstatus { my $pstat = PVE::ProcFSTools::read_proc_pid_sta

[pve-devel] [PATCH pve-container 1/1] vmstatus: add pressure stats

2020-11-03 Thread Alexandre Derumier
--- src/PVE/LXC.pm | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 5cfcf28..ad1460c 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -291,6 +291,24 @@ sub vmstatus { } else { $d->{cpu} = 0; } + + if

[pve-devel] [PATCH qemu-server 0/3] vmstatus: add pressure + hostcpu/hostmem

2020-11-03 Thread Alexandre Derumier
Need pve-common patches serie. Alexandre Derumier (3): vmstatus: add hostcpu value vmstatus: add hostmem value vmstatus: add pressure stats PVE/QemuServer.pm | 34 ++ 1 file changed, 34 insertions(+) -- 2.20.1 ___

[pve-devel] [PATCH pve-container 0/1] vmstatus: add pressure stats

2020-11-03 Thread Alexandre Derumier
need pve-common patches serie Alexandre Derumier (1): vmstatus: add pressure stats src/PVE/LXC.pm | 18 ++ 1 file changed, 18 insertions(+) -- 2.20.1 ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com

[pve-devel] [PATCH pve-common 0/1] Cgroups: add get_pressure_stat

2020-11-03 Thread Alexandre Derumier
This following my cgroup patch series from last week. This get pressure stat for CT or VM through cgroup. (pressure stats are only available in cgroupv2, even in hybrid hierarchy) Alexandre Derumier (1): add get_pressure_stat src/PVE/CGroup.pm | 43 ++

[pve-devel] [PATCH qemu-server 3/3] vmstatus: add pressure stats

2020-11-03 Thread Alexandre Derumier
--- PVE/QemuServer.pm | 18 ++ 1 file changed, 18 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 64d3635..f1b778e 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2696,6 +2696,24 @@ sub vmstatus { $d->{cpu} = $old->{cpu}; $

[pve-devel] [PATCH pve-common 1/1] add get_pressure_stat

2020-11-03 Thread Alexandre Derumier
--- src/PVE/CGroup.pm | 43 +++ 1 file changed, 43 insertions(+) diff --git a/src/PVE/CGroup.pm b/src/PVE/CGroup.pm index 4823be2..457502e 100644 --- a/src/PVE/CGroup.pm +++ b/src/PVE/CGroup.pm @@ -358,6 +358,49 @@ sub get_memory_stat { return $res; }

[pve-devel] [PATCH qemu-server 2/3] vmstatus: add hostmem value

2020-11-03 Thread Alexandre Derumier
--- PVE/QemuServer.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 0c2b1db..64d3635 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2658,6 +2658,11 @@ sub vmstatus { if ($pstat->{vsize}) { $d->{mem} = int(($psta

Re: [pve-devel] [RFC PATCH] fix #3106: correctly queue incoming connections

2020-11-03 Thread Dietmar Maurer
> > +Ok((sock, _addr)) => { > > +sock.set_nodelay(true).unwrap(); > > +let _ = set_tcp_keepalive(sock.as_raw_fd(), > > PROXMOX_BACKUP_TCP_KEEPALIVE_TIME); > > +let acceptor = Arc::clone(&acceptor); > > +

Re: [pve-devel] [RFC PATCH] fix #3106: correctly queue incoming connections

2020-11-03 Thread Dietmar Maurer
> On Tue, Nov 03, 2020 at 02:25:21PM +0100, Dietmar Maurer wrote: > > > > -let connections = > > > > proxmox_backup::tools::async_io::HyperAccept(connections); > > > > +let connections = accept_connections(listener, acceptor); > > > > +let connections = > > > >

Re: [pve-devel] [RFC PATCH] fix #3106: correctly queue incoming connections

2020-11-03 Thread Wolfgang Bumiller
On Tue, Nov 03, 2020 at 02:25:21PM +0100, Dietmar Maurer wrote: > > > -let connections = > > > proxmox_backup::tools::async_io::HyperAccept(connections); > > > +let connections = accept_connections(listener, acceptor); > > > +let connections = > > > hyper::serv

[pve-devel] [RFC qemu] migration/block-dirty-bitmap: migrate other bitmaps even if one fails

2020-11-03 Thread Stefan Reiter
If the checks in bdrv_dirty_bitmap_check fail, that only means that this one specific bitmap cannot be migrated. That is not an error condition for any other bitmaps on the same block device. Fixes dirty-bitmap migration with sync=bitmap, as the bitmaps used for that are obviously marked as "busy"

[pve-devel] applied: [PATCH widget-toolkit 1/1] Utils: remove product specific task descriptions

2020-11-03 Thread Thomas Lamprecht
On 30.10.20 14:02, Dominik Csapak wrote: > we use 'override_task_descriptions' in the specific products to > add the ones that are not used everywhere > > took the chance and sorted the remaining alphabetically > > Signed-off-by: Dominik Csapak > --- > src/Utils.js | 89 +++-

Re: [pve-devel] [RFC PATCH] fix #3106: correctly queue incoming connections

2020-11-03 Thread Dietmar Maurer
> > -let connections = > > proxmox_backup::tools::async_io::HyperAccept(connections); > > +let connections = accept_connections(listener, acceptor); > > +let connections = > > hyper::server::accept::from_stream(connections); > > If we move the `from_stream` in

Re: [pve-devel] [RFC PATCH] fix #3106: correctly queue incoming connections

2020-11-03 Thread Wolfgang Bumiller
generally ACKed, but I have some notes: On Tue, Nov 03, 2020 at 01:26:36PM +0100, Dietmar Maurer wrote: > --- > > based, on Domink's patch, but with the following changes: > > - factor out code into separate function accept_connections() > - no select with shutdown future (no needed) > - rem

Re: [pve-devel] [RFC PATCH] fix #3106: correctly queue incoming connections

2020-11-03 Thread Dominik Csapak
looks better than mine :) comment inline On 11/3/20 1:26 PM, Dietmar Maurer wrote: --- based, on Domink's patch, but with the following changes: - factor out code into separate function accept_connections() - no select with shutdown future (no needed) - remove sender2.send_timeout() -

[pve-devel] [RFC PATCH] fix #3106: correctly queue incoming connections

2020-11-03 Thread Dietmar Maurer
--- based, on Domink's patch, but with the following changes: - factor out code into separate function accept_connections() - no select with shutdown future (no needed) - remove sender2.send_timeout() - not sure why this was there? - restict number of spawned tasks Seems to work, but I get