Re: [pve-devel] [PATCH v2 storage] Diskmanage: Use S.M.A.R.T. attributes for SSDs wearout lookup

2020-10-27 Thread Jan-Jonas Sämann
On 27.10.20 09:08, Thomas Lamprecht wrote: > On 24.10.20 21:27, Jan-Jonas Sämann wrote: >> This replaces a locally maintained hardware map in >> get_wear_leveling_info() by commonly used register names of >> smartmontool. Smartmontool maintains a labeled register database that >> contains a major

[pve-devel] [PATCH docs] ceph: add warning for min_size 1

2020-10-27 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- pveceph.adoc | 4 1 file changed, 4 insertions(+) diff --git a/pveceph.adoc b/pveceph.adoc index 84a45d5..39da354 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -462,6 +462,10 @@ state. NOTE: The default number of PGs works for 2-5 disks. Ceph throws a '

[pve-devel] [PATCH manager 4/4] ceph: gui: display warning on min_size 1

2020-10-27 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- www/manager6/ceph/Pool.js | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js index 28b0b4a5..93ed667e 100644 --- a/www/manager6/ceph/Pool.js +++ b/www/manager6/ceph/Pool.js

[pve-devel] [PATCH manager 3/4] ceph: gui: use separate reload function

2020-10-27 Thread Alwin Antreich
on existing buttons. Signed-off-by: Alwin Antreich --- www/manager6/ceph/Pool.js | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js index d1fb2f3e..28b0b4a5 100644 --- a/www/manager6/ceph/Pool.js +++ b/www/manager6/ce

[pve-devel] [PATCH manager 1/4] ceph: add get api call for single pool

2020-10-27 Thread Alwin Antreich
Information of a single pool can be queried. Signed-off-by: Alwin Antreich --- PVE/API2/Ceph.pm | 105 +++ 1 file changed, 105 insertions(+) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index c3a3091d..e44714f6 100644 --- a/PVE/API2/Ceph.pm +++ b/

[pve-devel] [PATCH manager 2/4] ceph: gui: ability to edit an existing pool

2020-10-27 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- www/manager6/ceph/Pool.js | 82 ++- 1 file changed, 56 insertions(+), 26 deletions(-) diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js index 11bcf9d5..d1fb2f3e 100644 --- a/www/manager6/ceph/Pool.js +++ b/www

Re: [pve-devel] [PATCH qemu 1/2] PVE: Don't expect complete_cb to be called outside coroutine

2020-10-27 Thread Stefan Reiter
On 10/27/20 3:16 PM, Wolfgang Bumiller wrote: On Thu, Oct 22, 2020 at 02:11:17PM +0200, Stefan Reiter wrote: We're at the mercy of the rest of QEMU here, and it sometimes decides to call pvebackup_complete_cb from a coroutine. This really doesn't matter to us, so don't assert and crash on it. S

Re: [pve-devel] [PATCH qemu 2/2] PVE: Don't call job_cancel in coroutines

2020-10-27 Thread Stefan Reiter
On 10/27/20 3:17 PM, Wolfgang Bumiller wrote: On Thu, Oct 22, 2020 at 02:11:18PM +0200, Stefan Reiter wrote: ...because it hangs on cancelling other jobs in the txn if you do. Signed-off-by: Stefan Reiter --- pve-backup.c | 26 +- 1 file changed, 25 insertions(+), 1

Re: [pve-devel] [PATCH qemu 2/2] PVE: Don't call job_cancel in coroutines

2020-10-27 Thread Wolfgang Bumiller
On Thu, Oct 22, 2020 at 02:11:18PM +0200, Stefan Reiter wrote: > ...because it hangs on cancelling other jobs in the txn if you do. > > Signed-off-by: Stefan Reiter > --- > pve-backup.c | 26 +- > 1 file changed, 25 insertions(+), 1 deletion(-) > > diff --git a/pve-backu

Re: [pve-devel] [PATCH qemu 1/2] PVE: Don't expect complete_cb to be called outside coroutine

2020-10-27 Thread Wolfgang Bumiller
On Thu, Oct 22, 2020 at 02:11:17PM +0200, Stefan Reiter wrote: > We're at the mercy of the rest of QEMU here, and it sometimes decides to > call pvebackup_complete_cb from a coroutine. This really doesn't matter > to us, so don't assert and crash on it. > > Signed-off-by: Stefan Reiter > --- > p

Re: [pve-devel] [PATCH storage] lvmthin: Match snapshot remove regex to allowed names

2020-10-27 Thread Thomas Lamprecht
On 27.10.20 11:12, Dominic Jäger wrote: > We allow snapshot names that match pve-configid but during qm destroy we have > not removed all snapshots that match pve-configid so far. For example, the > name > x-y was allowed but the resulting snap_vm-105-disk-0_x-y was not removed. > > Reported-by:

[pve-devel] [PATCH manager] ui: Add verify SSL cert checkbox for active directory

2020-10-27 Thread Dominic Jäger
Like for LDAP, the option is too important to be hidden in CLI. Signed-off-by: Dominic Jäger --- The verify parameter seems to be implemented in the LDAP code [0] as well as in the AD code [1] [0] https://git.proxmox.com/?p=pve-access-control.git;a=blob;f=PVE/Auth/LDAP.pm;h=97d077886cd904863b65

[pve-devel] [PATCH storage] lvmthin: Match snapshot remove regex to allowed names

2020-10-27 Thread Dominic Jäger
We allow snapshot names that match pve-configid but during qm destroy we have not removed all snapshots that match pve-configid so far. For example, the name x-y was allowed but the resulting snap_vm-105-disk-0_x-y was not removed. Reported-by: Hannes Laimer Signed-off-by: Dominic Jäger --- Some

Re: [pve-devel] [PATCH v2 storage] Diskmanage: Use S.M.A.R.T. attributes for SSDs wearout lookup

2020-10-27 Thread Thomas Lamprecht
On 24.10.20 21:27, Jan-Jonas Sämann wrote: > This replaces a locally maintained hardware map in > get_wear_leveling_info() by commonly used register names of > smartmontool. Smartmontool maintains a labeled register database that > contains a majority of drives (including versions). The current loo