[pve-devel] applied: [PATCH v4 storage 2/7] Add prune_backups to storage API

2020-07-24 Thread Thomas Lamprecht
Am 7/9/20 um 2:45 PM schrieb Fabian Ebner: > Implement it for generic storages supporting backups > (i.e. directory-based storages) and add a wrapper for PBS. > > Signed-off-by: Fabian Ebner > --- > > Changes from v3: > * prune_mark: merge loops > * allow filtering by type > * more e

Re: [pve-devel] [PATCH v4 storage 3/7] Add API and pvesm call for prune_backups

2020-07-24 Thread Thomas Lamprecht
Am 7/9/20 um 2:45 PM schrieb Fabian Ebner: > For the pvesm call use a wrapper and a --dry-run option to redirect > to the correct API call. > > Signed-off-by: Fabian Ebner > --- > > Changes from v3: > * allow filtering by type > * pvesm: redirect to correct API call according to --dry-ru

[pve-devel] applied: [PATCH v4 storage 1/7] Introduce prune-backups property for directory-based storages

2020-07-24 Thread Thomas Lamprecht
Am 7/9/20 um 2:45 PM schrieb Fabian Ebner: > Signed-off-by: Fabian Ebner > --- > > Changes from v3: > * use property string validator > > PVE/Storage/CIFSPlugin.pm | 1 + > PVE/Storage/CephFSPlugin.pm| 1 + > PVE/Storage/DirPlugin.pm | 5 +-- > PVE/Storage/GlusterfsPlugin.

[pve-devel] applied: [PATCH manager 2/3] api/services: fallback to restart in reload

2020-07-24 Thread Thomas Lamprecht
And document that it is preferred Signed-off-by: Thomas Lamprecht --- PVE/API2/Services.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Services.pm b/PVE/API2/Services.pm index e5b3c3da..df9606f4 100644 --- a/PVE/API2/Services.pm +++ b/PVE/API2/Services.pm @

[pve-devel] applied: [PATCH manager 3/3] ui: node/services: use safer reload as restart command

2020-07-24 Thread Thomas Lamprecht
avoids service interruptions Signed-off-by: Thomas Lamprecht --- www/manager6/node/Config.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js index be09615f..ef3ac32c 100644 --- a/www/manager6/node/Config.js +++ b/www/manager6/node/Con

[pve-devel] applied: [PATCH manager 1/3] api/services: improve essential service check, allow reload and start

2020-07-24 Thread Thomas Lamprecht
reload is actually preferred, and even if most of the time this even won't reach the API, allowing to start them is still definitively fine! Signed-off-by: Thomas Lamprecht --- PVE/API2/Services.pm | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/PVE/API2/Se

Re: [pve-devel] Enabling mips/mipsel support in Hypervisor

2020-07-24 Thread Thomas Lamprecht
Am 7/24/20 um 1:14 PM schrieb Skyler Mäntysaari: > So how can I get it to build also mips/mipsel qemu-system image? Adapt: https://git.proxmox.com/?p=pve-qemu.git;a=summary (note uses the real QEMU repository as git submodule) Then for management one would need to adapt the qemu-server package or

Re: [pve-devel] applied: [PATCH manager] Allow setting device class on osd create

2020-07-24 Thread Alwin Antreich
On Fri, Jul 24, 2020 at 02:38:50PM +0200, Thomas Lamprecht wrote: > Am 7/24/20 um 2:24 PM schrieb Alwin Antreich: > > On Fri, Jul 24, 2020 at 11:54:10AM +0200, Thomas Lamprecht wrote: > >> Am 7/24/20 um 11:46 AM schrieb Alwin Antreich: > >>> On Fri, Jul 24, 2020 at 11:34:33AM +0200, Thomas Lamprech

Re: [pve-devel] applied: [PATCH manager] Allow setting device class on osd create

2020-07-24 Thread Thomas Lamprecht
Am 7/24/20 um 2:24 PM schrieb Alwin Antreich: > On Fri, Jul 24, 2020 at 11:54:10AM +0200, Thomas Lamprecht wrote: >> Am 7/24/20 um 11:46 AM schrieb Alwin Antreich: >>> On Fri, Jul 24, 2020 at 11:34:33AM +0200, Thomas Lamprecht wrote: Am 7/23/20 um 3:25 PM schrieb Alwin Antreich: > In some

Re: [pve-devel] applied: [PATCH manager] Allow setting device class on osd create

2020-07-24 Thread Alwin Antreich
On Fri, Jul 24, 2020 at 11:54:10AM +0200, Thomas Lamprecht wrote: > Am 7/24/20 um 11:46 AM schrieb Alwin Antreich: > > On Fri, Jul 24, 2020 at 11:34:33AM +0200, Thomas Lamprecht wrote: > >> Am 7/23/20 um 3:25 PM schrieb Alwin Antreich: > >>> In some situations Ceph's auto-detection doesn't recogniz

Re: [pve-devel] Enabling mips/mipsel support in Hypervisor

2020-07-24 Thread Dietmar Maurer
> So how can I get it to build also mips/mipsel qemu-system image? > That to me did not really tell me how it's disabled but what would be > needed so I can build the support? We do not support MIPS, so you need to find out yourself what is required.

Re: [pve-devel] Enabling mips/mipsel support in Hypervisor

2020-07-24 Thread Skyler Mäntysaari
So how can I get it to build also mips/mipsel qemu-system image? That to me did not really tell me how it's disabled but what would be needed so I can build the support? On 24/07/2020 8.10, Fabian Grünbichler wrote: On July 24, 2020 2:23 am, Skyler Mäntysaari wrote: Hi all, I would like to a

[pve-devel] [PATCH proxmox-backup-qemu v2 1/3] refactor incremental checks

2020-07-24 Thread Fabian Grünbichler
in preparation for adding more checks to check_incremental Signed-off-by: Fabian Grünbichler --- src/backup.rs | 5 - src/commands.rs | 11 +++ 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/src/backup.rs b/src/backup.rs index 717e099..dab1da0 100644 --- a/src/back

[pve-devel] [PATCH proxmox-backup-qemu v2 2/3] add archive_name helper

2020-07-24 Thread Fabian Grünbichler
since we're about to introduce a third duplicate of this line.. Signed-off-by: Fabian Grünbichler --- src/commands.rs | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/commands.rs b/src/commands.rs index dd00ca9..e2584ab 100644 --- a/src/commands.rs +++ b/src/com

[pve-devel] [PATCH proxmox-backup-qemu v2 0/3] fix #2866: invalidate bitmap on crypt_mode change

2020-07-24 Thread Fabian Grünbichler
changes since v1: - refactor code for de-duplication - drop print to STDERR - split into three patches Fabian Grünbichler (3): refactor incremental checks add archive_name helper fix #2866: invalidate bitmap on crypt_mode change src/backup.rs | 8 +++- src/commands.rs | 44 +

Re: [pve-devel] applied: [PATCH manager] Allow setting device class on osd create

2020-07-24 Thread Thomas Lamprecht
Am 7/24/20 um 11:46 AM schrieb Alwin Antreich: > On Fri, Jul 24, 2020 at 11:34:33AM +0200, Thomas Lamprecht wrote: >> Am 7/23/20 um 3:25 PM schrieb Alwin Antreich: >>> In some situations Ceph's auto-detection doesn't recognize the device >>> class correctly. The option allows to set it directly on

[pve-devel] [PATCH proxmox-backup-qemu v2 3/3] fix #2866: invalidate bitmap on crypt_mode change

2020-07-24 Thread Fabian Grünbichler
signed and plain backups share chunks, so bitmap reusal is okay for those combinations. switching from encrypted to not encrypted or vice-versa could have pretty fatal consequences - either referencing plain-text chunks in 'encrypted' backups, or referencing encrypted chunks in 'unencrypted' backup

Re: [pve-devel] applied: [PATCH manager] Allow setting device class on osd create

2020-07-24 Thread Alwin Antreich
On Fri, Jul 24, 2020 at 11:34:33AM +0200, Thomas Lamprecht wrote: > Am 7/23/20 um 3:25 PM schrieb Alwin Antreich: > > In some situations Ceph's auto-detection doesn't recognize the device > > class correctly. The option allows to set it directly on osd create, > > instead of altering it afterwards.

[pve-devel] applied: [PATCH manager] Allow setting device class on osd create

2020-07-24 Thread Thomas Lamprecht
Am 7/23/20 um 3:25 PM schrieb Alwin Antreich: > In some situations Ceph's auto-detection doesn't recognize the device > class correctly. The option allows to set it directly on osd create, > instead of altering it afterwards. This way the cluster doesn't need to > shift data back and forth unnecess

[pve-devel] [PATCH manager v3] ui: fw: Close #2815: Add warning if fw is disabled

2020-07-24 Thread Dominic Jäger
Currently people add firewall rules but forget to activate the firewall on guest level. This commit adds a warning to the top bar of the firewall panel to make them aware of this if necessary. The existence of a rule alone should not yet trigger the warning. Only if it is enabled but the whole fir